Kp
a0d614e6b0
Use clamp_symmetric_value in kconfig_read_controls
...
Avoid open-coding the test.
2016-10-21 02:16:48 +00:00
Kp
a8a41aa2ff
Move git version into Python class
2016-10-21 02:16:47 +00:00
Kp
ddc16dac8b
Use range_for in multi_check_for_killgoal_winner
2016-10-21 02:16:47 +00:00
Kp
5c872830a1
Remove unused message MULTI_KILL
2016-10-21 02:16:47 +00:00
Kp
cca7fc7848
Revert high-score cool_saying size
...
Mako88 reports that e335cdacb3
broke
reading historical high score files.
Code analysis shows that the size of the high score file must match the
size of struct all_scores, but this was not enforced anywhere. Commit
e335cdacb3
changed the size of struct
all_scores. Restore it to its previous size, and add a static_assert to
break the build if anyone tries to change it again.
Reported-by: Mako88 <https://github.com/dxx-rebirth/dxx-rebirth/issues/241 >
Fixes: e335cdacb3
("Reverted 81d7db279b
and rather removed the terminator byte from string length in nm_set_item_input(). This also fixes possible 9 character length for pilot callsigns. Had to fix up COOL_SAYING_LEN as it was not considering the termintor but considering the original D2 source, this was a mess to begin with (def = 50, text string = 60, input field len = 45). Made score saying 50 characters as this seems to be the maximum witdth without overlapping.")
2016-10-20 02:11:39 +00:00
Kp
8341c88300
Move move_towards_vector division into helper
...
Mako88 reports that 2a19da88d4
changed
robot movement. That commit reordered the operations in a way that
tends to truncate small values prematurely. Restore the original order
of operations.
Reported-by: Mako88 <https://github.com/dxx-rebirth/dxx-rebirth/issues/247 >
Fixes: 2a19da88d4
("Pass object_base &to move_towards_vector")
2016-10-20 02:11:39 +00:00
Kp
d955eda96f
Fix fullscreen checkbox handling
...
Reported-by: Mako88 <https://github.com/dxx-rebirth/dxx-rebirth/issues/224 >
Fixes: 7128141c55
("Use enum for newmenu item type")
2016-10-18 02:26:30 +00:00
Kp
27d0a79acd
Factor out reporting errors caused by bad levels
2016-10-17 03:49:32 +00:00
Kp
c006d068d8
Restructure PHYSFSX read helpers into template function
2016-10-17 03:49:31 +00:00
Kp
779738fa80
Add special handling for multi_do_reappear get_ghost_id
...
multi_do_reappear is overloaded to be used both on ghosts and on live
players. This causes a diagnostic because the *_id checks expect
exactly one type: either test for ghost or test for player, but not test
for and accept both. Open code the type check to support both.
2016-10-15 21:17:02 +00:00
Kp
e4e74fe09c
Pass vcsegptridx to pae_aux
2016-10-15 21:17:02 +00:00
Kp
d6ccaf9dec
Defer show_partial_environ until after adding -g,-O2
2016-10-15 17:51:48 +00:00
Kp
2d54a0c57d
Fix infinite recursion when newmenu_scroll has only one valid item
2016-10-15 17:51:47 +00:00
Kp
aae5279bfd
Initialize Stuck_objects for D1
2016-10-15 00:53:22 +00:00
Kp
f46b5a0210
Pass player_info to hud_show_cloak_invuln
2016-10-15 00:53:22 +00:00
Kp
2d4936b6ef
Pass player_info to hud_show_keys
2016-10-15 00:53:22 +00:00
Kp
bf11f9f63f
Pass player_info to hud_get_primary_weapon_fontcolor
2016-10-15 00:53:21 +00:00
Kp
1a3939469b
Pass player_info to hud_show_weapons
2016-10-15 00:53:21 +00:00
Kp
11754d6163
Pass player_info to hud_show_afterburner
2016-10-15 00:53:21 +00:00
Kp
3a52fe0952
Pass player_info to hud_show_energy
2016-10-15 00:53:21 +00:00
Kp
6a885069b0
Remove spurious resets of player::net_killed_total
2016-10-15 00:53:21 +00:00
Kp
5e8bcb853d
Move window creation events out of window::window
...
Avoid running arbitrary creation handlers while a constructor is
in-progress.
2016-10-15 00:53:21 +00:00
Kp
01f2932824
Pass grs_canvas &to window_create
2016-10-15 00:53:20 +00:00
Kp
d903a5db3b
Pass powerup_flags to exists_fuelcen_in_mine
2016-10-15 00:53:20 +00:00
Kp
a1b5d93740
Pass powerup_flags to escort_get_goal_segment
2016-10-15 00:53:20 +00:00
Kp
e5cd034f74
Pass powerup_flags to exists_in_mine
2016-10-15 00:53:20 +00:00
Kp
03b0222896
Fold escort_set_goal_object calls to exists_in_mine
2016-10-15 00:53:20 +00:00
Kp
ad35460eb0
Pass player_info to add_bonus_points_to_score
2016-10-15 00:53:20 +00:00
Kp
25f5fc231a
Pass player_info to add_points_to_score
2016-10-15 00:53:19 +00:00
Kp
248dd5c309
Move player::hostages_rescued_total to player_info
2016-10-15 00:53:19 +00:00
Kp
f21abc94cb
Move player::hostages_on_board to player_info
2016-10-15 00:53:19 +00:00
Kp
e721fc56da
Move player::last_score to player_info
2016-10-15 00:53:19 +00:00
Kp
ecb91955ae
Move player::score to player_info
2016-10-15 00:53:19 +00:00
Kp
3dd988d1b6
Pass DXX_VERSION_SEQ only to files that use it
2016-10-15 00:53:19 +00:00
Kp
95cd7fd368
Pass SHAREPATH only to files that use it
2016-10-15 00:53:18 +00:00
Kp
ea1312beb3
Use trigger_none instead of literal -1 in load_game_data
2016-10-15 00:53:18 +00:00
Kp
aaca04ba1f
Simplify valptridx array access restrictions
2016-10-15 00:53:18 +00:00
Kp
c1d9c40931
Convert various valptridx accesses to use factory functions
2016-10-15 00:53:18 +00:00
Kp
2393b1e8c9
Use array<> in set_segment_depths
2016-10-15 00:53:18 +00:00
Kp
647991e203
Use range_for in validate_segment_all
2016-10-15 00:53:18 +00:00
Kp
599bf21b7d
Remove paranoid debug-only object checks
...
These have never been observed to trigger. Memory corruption prevention
is much better than it was when these were written.
2016-10-15 00:53:17 +00:00
Kp
5c83891c8f
Remove incomplete wall validation in load_game_data
2016-10-15 00:53:17 +00:00
Kp
a9672b7c30
Use addressof to report base address of valptridx access
2016-10-15 00:53:17 +00:00
Kp
c2e6f06b86
Use std::move to compact walls
2016-10-15 00:53:17 +00:00
Kp
61a53fb875
Use range_for in ogl_cache_level_textures
2016-10-15 00:53:17 +00:00
Kp
3eceaca1b6
Cache temporaries when processing level mutation hack
2016-10-15 00:53:17 +00:00
Kp
6515308a59
Simplify loop iteration in copy_group_walls
2016-10-15 00:53:17 +00:00
Kp
a80ed36f0a
Use range_for/vsegptr for wall_restore_all
2016-10-15 00:53:16 +00:00
Kp
4f8f27bdf6
Use range_for/vctrgptridx for write_trigger_text
2016-10-15 00:53:16 +00:00
Kp
4597ecf1f0
Use range_for/vcwallptridx for write_wall_text
2016-10-15 00:53:16 +00:00