Kp
e116e894b0
Fix invalid free when hoard data is missing
...
If hoard data is not initialized, hoard_resources_type::reset frees
GameBitmaps[0].data, which is bogus_data instead of nullptr or a valid
pointer.
Fixes: d422e8656a
("Simplify HoardEquipped")
2015-05-23 04:13:29 +00:00
Kp
02c6f2a9f3
Fix gcc-4.6 render range error
...
gcc-4.6 fails to synthesize a move constructor to initialize
reversed_render_range; later gcc accept this.
Switch to capturing the value by const auto &&, which works in both old
and new gcc.
2015-05-22 03:33:21 +00:00
Kp
6615aff8a4
Fix gcc-4.6 piggy build
...
gcc-4.6 warns about the transition to new for scope rules; later gcc
does not warn.
Replace the loops with range-based for.
2015-05-22 03:33:20 +00:00
Kp
3298802b3d
Fix gcc-4.6 object build
...
gcc-4.6 chokes on implicitly converting vobjptridx_t to int/uint16_t;
later gcc accepts this. Cast the vobjptridx_t directly to short to
force gcc-4.6 to find the correct conversion operator.
2015-05-22 03:33:20 +00:00
Kp
665a0de228
Fix gcc-4.6 multi build
...
gcc-4.6 chokes on implicitly converting objptridx_t to short; later gcc
accepts this. Cast the objptridx_t directly to short to force gcc-4.6
to find the correct conversion operator.
2015-05-22 03:33:20 +00:00
Kp
76540314c1
Fix gcc-4.6 gamerend build
...
gcc-4.6 chokes on casting vobjptridx_t to long; later gcc accepts this.
Change the format string to short, then switch the conversion to
objnum_t, which has an exact match for the converting operator.
2015-05-22 03:33:20 +00:00
Kp
4cd329d2b4
Fix gcc-4.6 gamecntl build
...
gcc-4.6 chokes on constexpr operator int(); later gcc accepts this.
menu_fix_wrapper is never converted in constexpr context, so remove the
constexpr specifier.
Fixes: 12ad357b8d
("Move Wimp Menu to macro")
2015-05-22 03:33:20 +00:00
Kp
ae604225c8
Fix gcc-4.6 interpreter build
...
gcc-4.6 chokes on `static constexpr type value{};`, but accepts
`static constexpr auto value = type{};`
Fixes: 77ec36b9c3
("Convert g3_draw_morphing_model to class")
2015-05-22 03:33:19 +00:00
Kp
d422e8656a
Simplify HoardEquipped
2015-05-22 03:33:19 +00:00
Kp
dc4a344ec8
Use destructor for hoard resources
2015-05-22 03:33:19 +00:00
Kp
cc2a5e9790
Use gr_free_bitmap_data for Orb_icons
2015-05-22 03:33:19 +00:00
Kp
bc886e5ade
Skip sliding invisible textures
2015-05-17 20:37:59 +00:00
Kp
c53b734abb
Compute slide segments early
...
Store slide flag in segment to save one byte per segment.
2015-05-17 20:37:59 +00:00
Kp
a7f9b34aff
Refactor slide_textures
2015-05-17 20:37:59 +00:00
Kp
8e49c191ce
Remove unused copy_side_except_vertex_ids
2015-05-17 20:37:59 +00:00
Kp
44625e2617
Remove unnecessary Mouse::button_state
2015-05-14 02:23:13 +00:00
Kp
265ad59e9c
Remove set_default_handler
...
standard_handler is the only handler. Use it directly.
2015-05-14 02:23:13 +00:00
Kp
7f403bc1af
Optimize clearing player animation angles
2015-05-14 02:23:13 +00:00
Kp
577321d74b
Remove obsolete con_close
2015-05-14 02:23:13 +00:00
Kp
5ffbb6dd05
Enable tail call in con_add_buffer_line
2015-05-14 02:23:13 +00:00
Kp
e4d7d20bd2
Factor out console color lookup
2015-05-14 02:23:13 +00:00
Kp
8ddcf7b323
Simplify console open check
2015-05-14 02:23:13 +00:00
Kp
fa591d585a
Shorten event_toggle_focus
2015-05-14 02:23:13 +00:00
Kp
68d35d8e05
Move negation of mouse_toggle_cursor argument into callee
2015-05-14 02:23:13 +00:00
Kp
e50b0d479e
Inline event_mouse_get_delta
2015-05-14 02:23:13 +00:00
Kp
2a8b79f868
Inline event_mouse_get_button
2015-05-14 02:23:13 +00:00
Kp
0ece005dfa
Use screen_mode for screen resolution
2015-05-14 02:23:13 +00:00
Kp
e592f3a0bb
Inline call to gr_set_mode(0)
2015-05-14 02:23:13 +00:00
Kp
2d9af1e348
Propagate gr_init argument
2015-05-14 02:23:13 +00:00
Kp
739879d701
Move input config menu to macro
2015-05-14 02:23:13 +00:00
Kp
cb873563c8
Move reticle menu to macro
2015-05-14 02:23:13 +00:00
Kp
e64e54f521
Move input sensitivity menu to macro
2015-05-14 02:23:13 +00:00
Kp
ac3b1d6aa3
Switch do_cockpit_window_view to vobjptr_t
...
Only the wake_up_rendered_objects hack needed a vobjptridx_t. Switch to
vobjptr_t.
2015-05-13 03:20:28 +00:00
Kp
5810faf33d
Make Ai_last_missile_camera object*
2015-05-13 03:20:28 +00:00
Kp
bfeddc3501
Test for exploding wall damaging control center
...
apply_damage_to_controlcen requires a valid `who`, but exploding walls
have none.
Fixes: 3eb8f4813e
("Pass vcobjptr_t to apply_damage_to_controlcen")
2015-05-09 19:55:58 +00:00
Kp
38e8967fba
Split event_toggle_focus
2015-05-09 17:39:03 +00:00
Kp
67240cea48
Shorten mouse_get_delta
2015-05-09 17:39:03 +00:00
Kp
9151b7f300
Remove write-only old_delta_x, old_delta_y
2015-05-09 17:39:03 +00:00
Kp
fd51d9dcd5
Shorten kc_change_mouseaxis
2015-05-09 17:39:03 +00:00
Kp
7f00061f6f
Shorten mouse_flush
2015-05-09 17:39:03 +00:00
Kp
e111d6ec22
Shorten mouse_cursor_autohide
2015-05-09 17:39:03 +00:00
Kp
f248006df5
Remove unused mouse_get_btns
2015-05-09 17:39:03 +00:00
Kp
53036c593e
Use unsigned comparison in mouse_in_window
2015-05-09 17:39:03 +00:00
Kp
4ca7924907
Pass graphics_config_menuset items by userdata
2015-05-09 17:39:02 +00:00
Kp
29f239d6b1
Raise PHYSFSX_exists bool check to caller
...
All callers use a constant value, so raise the check into the caller to
let the optimizer delete the unnecessary branch.
2015-05-09 17:39:02 +00:00
Kp
a4ba74f94a
Expand void ternary operator into if/else
2015-05-09 17:39:02 +00:00
Kp
e57afde68b
Hoist store in gr_internal_string0_template
2015-05-09 17:39:02 +00:00
Kp
8ac92b098f
Cache variables in gr_internal_string0_template
2015-05-09 17:39:02 +00:00
Kp
bd5573356d
Reduce gr_internal_string0_template variable scope
2015-05-09 17:39:02 +00:00
Kp
4228ed2324
Switch gr_internal_string0_template to count down loop
2015-05-09 17:39:02 +00:00