Commit graph

134 commits

Author SHA1 Message Date
duianto
a82d2292b6 [base] Fix void helm-use-fuzzy
problem:
The spacemacs-completion layer defines the variable:
helm-use-fuzzy

But the spacemacs-base distribution doesn't use the
spacemacs-completion layer by default.

helm-use-fuzzy is used in the helm layer.

When a helm buffer is opened, for example: `SPC SPC`
Then a warnings buffer opens:
>Error (use-package): helm/:config: Symbol’s value as variable is void: helm-use-fuzzy

solution:
Make sure that helm-use-fuzzy is bound and true.
2020-12-30 20:54:00 +01:00
Keshav Kini
ca7e66ba98 Revert helm-ag/helm-grep binding of RET to default
Currently 'helm-ag-mode-jump-other-window is bound both to RET and to C-o (its
original default binding), while 'helm-ag-mode-jump isn't bound at all (its
original default binding is RET).  This commit removes our customization so that
both 'helm-ag-mode-jump-other-window and 'helm-ag-mode-jump have bindings in the
mode.

The same change is also made for the analogous helm-grep functions, for the same
reason.
2020-11-27 19:19:36 +01:00
Lucius Hu
3c35407968
Minor changes on helm layer (#14088)
* Added `helm-ag-success-exit-status` when using `rg`

It's been advised by the upstream of `helm-ag` to set
`helm-ag-success-exit-status` to `'(0 2)`.

This commit adds this.

ref: https://github.com/emacsorphanage/helm-ag#helm-agel-with-other-searching-tools

Signed-off-by: Lucius Hu <lebensterben@users.noreply.github.com>

* Use `magit-status-setup-buffer` instead of `vcr-dir`

This is suggested by the package itself.
Ref: 4da1a53f2f/helm-ls-git.el (L184-L189)

Co-authored-by: Lucius Hu <lebensterben@users.noreply.github.com>
2020-10-26 23:11:54 +01:00
Boris Sergeyev
3e033e39f6 [helm] helm-swoop, ignore helm-full-frame' and pop-up-windows'
because current implementation does not support full-frame usage:
see https://github.com/syl20bnr/spacemacs/issues/2157
2020-10-22 19:49:49 +02:00
Robert O'Connor
82ba73a1c0
update copyright to 2020 2020-09-23 21:25:01 +02:00
Nicholas Kirchner
516da8dfbd [helm] Add the helm-org package so that helm-spacemacs-faq works
There is a (require 'helm-org) directive in helm-spacemacs-faq.el
which is triggered by the key sequence 'SPC h f'.
2020-09-08 11:03:55 +02:00
Ivan Yonchovski
182bf1fe15 Do not enable fuzzy matching for locate if it is not wanted 2020-09-04 22:46:03 +02:00
syl20bnr
52ec07bb44 [core] Fix installation of unused layer dependencies after SPC h SPC
Fix bug where layer dependencies of all layers (even the unused ones)
are installed after SPC h SPC and then SPC f e R
2020-08-29 21:51:52 -04:00
duianto
5150ac6c50 [helm] Hide helm-ff-cache-mode mode-line indicator 2020-07-18 09:40:14 +02:00
Maximilian Wolff
d4a590a2fd
[helm] Fix helm with universal argument 2020-07-12 10:18:25 +02:00
Miloš Mošić
d4634b5711 Fix incf causing an error message
This was the only place where `incf` was used instead of `cl-incf`,
it fixes the "Symbol’s function definition is void: incf" error
2020-06-24 23:15:53 +02:00
Maximilian Wolff
c7ed2fc597
[helm] Provide fuzzy matching for Helm-M-x
Following the advice from duianto #13100 we are
setting completion-styles for helm-M-x to include
the emacs version specific fuzzy strategy as last
resort.

Before no fuzzy matching occured within command
searches.
2020-05-11 12:36:56 +02:00
duianto
27178f23e9 Fix helm-spacemacs-help-faq, SPC h f
The function: helm-org-get-candidates was removed upstream.

Improvements:
Recenter the target candidate.

Reversed the helm headings list, to match the order of the
questions in FAQ.org, so that the Common questions are
listed first.

Removed the : (colon) after the heading: How do I
in FAQ.org, to match the other parent headings.
2020-01-25 17:37:47 +01:00
Richard Kim
278be41010 [helm] Created spacemacs/helm-dir-do-grep to fix issue #13167
This is used if someone does not have ag, pt, rgrep, etc.
2020-01-20 15:53:20 +01:00
Zach Latta
1d2a1fa6e4 Fix capitalization of GitHub
Change instances of "Github" to "GitHub".
2020-01-20 09:14:12 +01:00
Jacek Swierk
cefcce2caa
[helm] Fix rg interaction with its config file
If a user uses ripgrep persistent configuration file that sets options
helm overrides the argument parser for ripgrep might incorrectly parse
the command line used by helm.

The problem is encountered whenever an argument option occurs multiple
times and the last one is of this form: '--arg value' or '-a v'. If that
last argument is followed by the positional argument (input) then its
value will be treated as the input resulting in error due to too many
positional arguments.

In other worlds, this would fail to be parsed correctly:
    rg --max-columns=10 --max-columns 20 input
    rg --max-columns 10 --max-columns 20 input

While this works as expected:
    rg --max-columns=10 --max-columns=20 input
    rg --max-columns 10 --max-columns=20 input

The solution would be to use arguments in the form of '--arg=value'
which will never be treated as a positional argument.

Fixes #10953
2020-01-02 23:18:36 +01:00
duianto
68a2f37670
Fix helm-find-files-edit action C-c C-e 2019-12-20 18:39:11 +01:00
kimr
da80634370
converted cl to cl-lib 2019-12-14 20:20:51 +00:00
Brian Wignall
4df6c9035f
Fix typos 2019-12-05 22:23:04 +01:00
duianto
979f4db640
[helm] Fix searching in projects with C-s from SPC p p
Fixes #11878

The issue seems to have been caused by helm making sure that
the functions that are called with: helm-exit-and-execute-action
are actions.

Ensure action is available before running it
d6dfb8f1e3
2019-12-05 22:17:11 +01:00
duianto
6649e78f3e
Document helm and ivy colors/faces key bindings
Helm:
SPC C l   calls helm-colors
SPC h d F calls spacemacs/helm-faces

Ivy:
SPC C e   calls counsel-colors-emacs
SPC C f   calls counsel-colors-faces
SPC C w   calls counsel-colors-web
SPC h d F calls counsel-describe-face

Thanks Miciah for the SPC h d F suggestion.
2019-12-03 22:21:42 +00:00
Maximilian Wolff
dd7a5d98be
Revise helm recompile package action and bind recompile-elpa
The newly introduced function to compile an elpa package
was very much redundant with the existing recompile-elpa function.

I have adapted recompile-elpa so that it can be used for the helm action too.

In addition I have bound recompile-elpa to `SPC c C-c` to allow users to
easily recompile their entire elpa directory if the need arises.

I have also removed the error handling in the helm action in favor of
standard error reporting via the *Compile-Log* buffer.
2019-11-24 02:07:15 +01:00
Gia Thanh Vuong
94de754504
[core] [helm] add action to recompile an elpa package
How to use: `SCP h p` select package then `F3` or `C-z` and choose `Recompile`

Motivation: Some packages when compiling need other packages to be loaded first.
The pacakage maintainers should make sure of this requirement but sommetimes
they don't. It also doesn't help when Spacemacs is lazy loading and compiles
updated pacakges on startup. So the manual fix for this problem is recompile the
package once Spacemacs has fully loaded. This requires user go to the package
install location to delete elc files and then do a `spacemacs/recompile-elpa`.
This commit will do that chore for them.

This will make fixing the problem with `org-plus-contrib` or `dumb-jump` update
every now and then easier.
2019-11-23 23:40:50 +01:00
duianto
5bcc96e9a9 [helm] Add helm-ls-git-ls to SPC g f f
The HELM Lsgit buffer has three sections:
- Git status (files: modified, deleted, etc.)
- Buffers in git project
- Git files
2019-10-28 21:26:04 +01:00
deb0ch
6857914441 completion: add command for unfiltered buffers list under SPC b U 2019-09-08 10:19:10 -04:00
deb0ch
22713541f8 completion: filter helm-mini with useful/useless buffers regexp 2019-09-08 10:19:10 -04:00
Junxuan
6b2f849efd update helm-xref to set the correct xref-show-xrefs-function
helm-xref currently provides two functions and the user is expected
to use the correct one based on their emacs version. The lazy loading
logic has to be updated to set the correct xref-show-xrefs-function.
2019-08-05 20:34:04 +02:00
duianto
277eca6cea Update README.org (Updated)
- Added a changelog.develop entry to the various documentation changes section.
- Fixed a typo.
- Improved some of the wording.
- Mentioned that save or discard leaves helm-ag-edit not just iedit state.
2019-08-03 22:16:44 +02:00
Lucius Hu
c8cdf8dc2b Update README.org to state how to discard changes made in iedit
- Added an entry on how to discard changes made in `iedit` states via `helm-ag`
2019-08-03 21:04:46 +02:00
syl20bnr
009777f6cf Add pre-dump for org, emacs-lisp and helm 2019-07-26 16:33:10 -04:00
duianto
bbd75935e8 [helm] Load helm before completion-at-point
When trying to complete a path at the `:e ` evil-ex-completion prompt by
pressing `TAB`.

Before: The default Emacs `*Completions*` buffer opens.
After: The `HELM Completion At Point` buffer opens.

And sorted the transient hooks alphabetically.
2019-06-02 21:20:08 +02:00
emacspace
c7c348a676 documentation formatting: Sun May 26 20:58:52 UTC 2019 2019-05-27 01:23:35 +03:00
Juha Jeronen
b4907d0540 Fix spacemacs//helm-open-buffers-in-windows
Opening more files than available windows, showed:
Symbol’s value as variable is void: cl-return

Fix #12358
2019-05-25 12:30:36 +02:00
Anton-Latukha
f6660f82d4
Switch to the new layers generator 2019-05-15 21:08:21 +03:00
syl20bnr
953573ade5 [helm] Document SPC s C and sort key bindings 2019-05-12 11:35:35 -04:00
Yang Qian
ada180786e Introduce key binding sC for helm-swoop-clear-cache
helm-swoop cannot detect the buffer has changed when calling git checkout to
change the file content, so helm-swoop won't clear the cache, we have to clear
the cache manually by evaluating `helm-swoop--clear-cache`. As it is
inconvenient, so I introduce a new key binding to to this.

Signed-off-by: Yang Qian <yang.qian@citrix.com>
2019-05-06 11:09:55 +02:00
JAremko
5d02b1c4bb Add more tags 2019-05-03 03:44:19 +03:00
syl20bnr
c987fbecdf Revert "Bind ~SPC f F~ to =helm-find= for recursive directory search functionality."
This reverts commit 3a23e0cc6b.

This change completely break `SPC f F` in two ways:
1) it breaks the convention followed at various places to have capital letter
   bindings to prefill the helm prompt
2) it breaks the main functionality of the bindings which is very important:
   press `SPC f F` on a path will brings you directly to the directory of this
   file. It allows to quickly nagivate to files references in files.
2019-04-24 10:13:30 -04:00
jjzmajic
3a23e0cc6b Bind ~SPC f F~ to =helm-find= for recursive directory search functionality.
I realize this may be controversial, but as I understand it (correct me if I'm
wrong), all `SPC f F` does differently compared to `SPC f f` is call the vanilla
version of `helm-find-files` that does take `thing-at-point` into account. But I
presume we removed this feature in `spacemacs/helm-find-files` for a reason.

Also, it makes sense as a *forte* version of `helm-find-files` when you can't
find something in your current directory and decide to drill deeper. This
complies with the general tone of uppercase/lowercase bindings in Spacemacs, and
provides more utility than te subtle distinction between different
implementations of `helm-find-files`.
2019-04-20 22:15:29 +02:00
syl20bnr
388b6b878e Fix helm transient state cleanup
Fixes #12034

Be more specific about the transient map to cancel. Fixes conflict with new
transient map driven magit key bindings.
2019-04-04 12:16:08 -04:00
duianto
f8ed4739fe Load helm before read-file-name and completing-read
Fixes helm not being loaded before calls to:
read-file-name and completing-read.

These are some commands that call either of those two functions:
spacemacs/rename-current-buffer-file (SPC f R)

In a Treemacs window:
treemacs-add-project-to-workspace (C-c C-p a)

In a Magit buffer:
magit-checkout (b b)

Thanks Miciah for a more elegant solution.

This commit also reverts:
Fix helm loading for layouts transient state #11705
because it's not needed anymore.

And the previously commented out transient hook minibuffer-setup-hook (it
doesn't seem to ever have been used) is removed because:
- It loads helm after a command is called that uses helm (instead of before)
- (spacemacs|hide-lighter helm-mode) has previously been moved to the
helm/init-helm :config section.
2019-04-03 21:27:08 +02:00
Miciah Masters
17ec4da516 Delete helm-wikipedia-suggest key binding
Helm has removed the helm-wikipedia-suggest command, so delete Spacemacs's
key binding for the command.

4ef8299d78

* CHANGELOG.develop: Add entry.
* doc/DOCUMENTATION.org: Delete documentation for the key binding for
helm-wikipedia-suggest.
* layers/+completion/helm/packages.el (helm/init-helm): Delete the key
binding for helm-wikipedia-suggest.
2019-04-03 08:19:40 +02:00
duianto
d55f39eed3 Change helm-apropos from SPC h d d to SPC h d a
Change the binding to be more mnemonic.

It calls helm-[a]propos and it pretty much describes [a]ll.
2019-02-18 16:42:12 -05:00
emacspace
45276bd96f documentation formatting: Wed Dec 5 03:03:03 UTC 2018 2018-12-04 22:06:14 -05:00
Codruț Constantin Gușoi
aac242c2b7 Workaround for opening files from buffers without winum 2018-11-09 21:57:14 +02:00
duianto
a16cf09dde Hide helm modeline indicator text 2018-10-27 20:53:43 +02:00
Boris Buliga
ecce0197f8
add actions to open funcs.el and layers.el from layers help 2018-10-18 19:33:29 +03:00
JAremko
cd39f80c24 Reformat documentation 2018-10-11 00:13:43 +03:00
bmag
044237139b Fix regression: void function helm-current-directory on C-x C-f
Invoking C-x C-f (spacemacs/helm-find-files) right after startup, before helm is
loaded, caused a void function error for helm-current-directory. This fixes it.
2018-09-06 10:57:27 +03:00
Dan Girshovich
1ad673fcb7 add guard to check winum is loaded to fix #10446 2018-08-01 23:19:26 -04:00