This function is making asynchronous commands fail because it tries to
add string literal to spacemacs-useful-buffers-regexp while add-to-list
only works when first argument is a symbol and the second is an
element. Otherwise, it throws this error and stop all async commands to
do any further work at this point:
if: Wrong type argument: symbolp
This commit fixes the following issues:
- Don't add spacemacs//mark-repl-as-useful to
buffer-list-update-hook. We only need this function to switch to next
or previous buffer. So, better check when and only when those commands
are actually used.
- As a result, we remove the function since it's unneeded anymore.
- Do the checking in of comint-mode in spacemacs-useful-buffer-p
function. Better do it in one place than scatter the logic in a hook
and this function.
- Change useless-buffer-p to accept an actual buffer object and check
for buffer name inside.
- base16-theme
- monokai-theme
- zenburn-theme
It is not necessary to add them to the layer now because
the configuration layer engine does not treat themes listed
in `dotspacemacs-themes` as orphans anymore.
The command bound to C-z is much more useful than the one bound to Tab,
so it makes sense to swap them. It's also recommended here: https://tuhdo.github.io/helm-intro.html
When you are typing in a browser and then you realize you really want
Emacs to compose this piece of text, then you would want to copy from
browser to an Emacs buffer, edit it inside Emacs and finally copy to
clipboard and paste it into the original application. These keys help
you to do exactly that.
Otherwise when the widget list is deleted to insert new widgets, the
separator "widget" is essentially text with properties and can cause
error when trying to delete, which breaks quick help and release note
buttons, making the buttons not function anymore.
Bind term-send-eof only in insert mode
This is a useful binding to have, and is bound similarly to
term-send-esc (`C-c C-e`) and term-interrupt-subjob (`C-c C-c`).
