Commit graph

1954 commits

Author SHA1 Message Date
smile13241324
25dbbd1e5a [conda] Revise conda layer
Conda layer needed some additions to be spacemacs
conform. In detail I did:
* Add missing features block and TOC declaration in README
* Change bindings to extent the existing python bindings
  rather than adding new general bindings.
* Make conda layer require python layer
2019-10-19 21:06:57 +02:00
Zach Pearson
b4ff40b941 Add conda layer (to work with anaconda environments) 2019-10-19 20:00:00 +02:00
Miloš Mošić
b9f3ed61f4 [elixir] Enable evil-matchit in elixir mode 2019-10-19 10:47:28 +02:00
Gia Thanh Vuong
18715b872b bind c-ret to cider-repl-newline-and-indent in repl
For evil insert mode
2019-10-19 00:32:51 +02:00
alex argunov
92b7b65d13 Add available formatters to typescript readme 2019-10-18 22:39:44 +02:00
Zach Pearson
ef1cecce01 Add a way to start an EIN Jupyter server from Spacemacs's UI 2019-10-18 20:59:09 +02:00
Aaron Jensen
1bd3777006 Fix tide with tsx files
This was broken in
ac30247811
if you do not specify a backend explicitly
2019-10-18 20:36:05 +02:00
wenpin
a45948c759 fix typo
There are two `dap-firefox-setup` while `dap-chrome-setup` never show up
2019-10-16 21:04:14 +02:00
Boris Buliga
5785f1788f [python] update jedi instructions
Following 150390968b
2019-10-14 22:18:11 +02:00
Thijs Vermeir
f753076772 fix documentation in markdown layer 2019-10-13 16:22:44 +02:00
Miciah Masters
552fd5953c Update references to macOS
Apple renamed "Mac OS X" to "OS X" in 2012 and then to "macOS" in 2016.
Update references to use the current name.
2019-10-13 12:04:40 +02:00
Miciah Masters
c7516a84c6 Fix documentation for key bindings
* layers/+lang/mercury-layer/README.org: Fix key bindings.
2019-10-13 10:46:45 +02:00
Martin Račák
1fec4ec135 Fix conditional backend setup
* Use spacemacs//python-backend to check which backend is being used
* Set leader keys for anaconda in :config to avoid overwriting by tags layer
2019-10-12 15:21:40 +02:00
Martin Račák
c95534ace5 Revert "Use anaconda-mode-find-definition for SPC-m-g-g"
This reverts commit 9bafd3f561.
2019-10-12 15:21:40 +02:00
Rakan Alhneiti
9bafd3f561 Use anaconda-mode-find-definition for SPC-m-g-g 2019-10-11 22:03:59 +02:00
Thanh Vuong
ba1fba2455 add lsp for html buffer 2019-10-09 15:29:29 +02:00
Daniel Caixinha
7dd4118820 Add instructions to PlantUML README to set exec-mode accordingly 2019-10-06 21:16:05 +02:00
syl20bnr
584392bd92 [core] Fix layer dependencies based on layer variables
There was a edge case with the declaration of the `lsp` layer in `layers.el`
files.
The `hy` layer depends on the `python` layer which in turn depends on the `lsp`
layer if and only if the `python-backend` layer variable is set to `lsp`.
When the `hy` layer was declared first then it declares the `python` layer
without its layer variables, thus the `lsp` layer was not declared because the
`python-backend` variable was not set.

The fix is to gather all the layer dependencies and resolve them only after all
the used layers have been declared.

* new function `configuration-layer/declare-layer-dependencies`
* replace all calls to `configuration-layer/declare-layer` by the new function
  except for distribution layers (we declare layer dependencies right away in
  distribution layers)
2019-09-30 02:00:48 -04:00
syl20bnr
ac30247811 [lsp] When used, make LSP the default backend for all supported lang
* Added a new function to each language to select the backend
* Use these new functions in all `pcase`.
2019-09-30 00:49:44 -04:00
syl20bnr
9606dd344e [dap] Refactor configuration dap config in layers
* use local-vars-hook coupled to setup function for dap
* define new private layer variable `spacemacs--dap-supported-modes` to
  configure key bindings. This allows to move the key bindings definition from
  `funcs.el` to `packages.el`
* remove duplication of DAP key bindings in READMEs by pointing to the dap layer
  documentation
* alphabetically sort package configuration
2019-09-30 00:34:26 -04:00
syl20bnr
2b70cd5f45 [java] Remove unconfigured eldoc package 2019-09-30 00:34:26 -04:00
smile13241324
58e342f242 [dart] Explain LSP dependency and make layer require LSP layer
The dart layer requires the official LSP server as the
emacs mode alternative is not longer properly maintained.
Therefore I have added some more description of how to
install the server properly and let the layer load
the LSP layer automatically.

In addition I have removed the unsupported variable
`dart-server-enable-analysis-server` from the
documentation.

See https://github.com/bradyt/dart-mode/wiki/LSP for
details.
2019-09-28 23:01:49 +02:00
smile13241324
aa244a91a5 [shell-scripts] Load lsp layer when an lsp backend has been selected 2019-09-28 22:21:51 +02:00
smile13241324
9730173e94 [shell-scripts] Make readme describe the available backends more clearly 2019-09-28 22:04:51 +02:00
Georgy Lukyanov
bee9bea1b6 Fix #9429: Make agda layer retain indentation on paste.
Add `(add-to-list 'spacemacs-indent-sensitive-modes 'agda2-mode)`
into the definition of `agda/init-agda`.
2019-09-28 14:23:17 +02:00
duianto
8ca2af4215 [php] Enable evil-matchit-mode 2019-09-27 13:35:29 +02:00
duianto
3142f070f5 [dart] Fix reverting a dart buffer
While getting the dart-server major mode key bindings to work.
Everything was moved from the `dart/init-dart-mode` function,
to the `dart/init-dart-server` function.

This revealed that an empty `dart/init-dart-mode` section causes
`M-x revert-buffer`
to switch the dart buffer to `fundamental-mode`.

The fix was to load `dart-mode` from the `dart/init-dart-mode`
function. And add `:after dart-mode` to the
`dart/init-dart-server` function.
2019-09-25 10:59:43 +02:00
duianto
37e326e1cf [dart][doc] Remove disabled key binding SPC m f f
The key binding was disabled because of this upstream issue:
dart-server-find-refs on int opens a dart buffer that keeps growing in size #11
https://github.com/bradyt/dart-server/issues/11
2019-09-24 07:48:55 +02:00
duianto
af52143b6c [dart] fix jump handlers 2019-09-24 07:39:37 +02:00
duianto
a069c6125a [dart] Add dart-server package
dart-mode has been split into two packages:
- dart-mode, Provides basic syntax highlighting and indentation.
- dart-server, Factors out the features from dart-mode.el that relied on
external executables, thus improving availability, reliability, testing and
development of dart-mode.el.
2019-09-23 19:18:33 +02:00
Javier Candeira
f25ad36d79 [html] Add .svelte files to web-mode auto-mode-alist :mode handler 2019-09-23 13:45:15 +02:00
Vitaly Banchenko
cba2602622 [Clojure] fix repl-buffer autoscroll when send forms.
When send form/region/buffer to repl without focus - repl buffer is
not scrolling and result not visible.

Added scrolling to the end of the repl-buffer after eval.
2019-09-22 21:52:18 +02:00
Rodolfo Hansen
9155c0b65e Lsp-scala is deprecated in favor of lsp itself 2019-09-22 21:38:18 +02:00
Mathieu
16f283898c Add flutter and lsp support to dart layer 2019-09-22 21:21:06 +02:00
Daniel Richtmann
724eb908a8 Enable experimental support for lsp within the shell-scripts layer
Note that this is only valid for bash scripts, since it uses the
`bash-language-server` defined in `lsp-clients.el`
2019-09-22 20:51:33 +02:00
torstein
909d755667 Do not use tabs in inferior python mode 2019-09-22 19:05:14 +02:00
duianto
1f0e41d7c2 [php] Add phpunit test key bindings 2019-09-22 18:55:36 +02:00
Danny KB
901b1ad6e4 [python] fix IPython shell setup on windows path with whitespaces
On systems where IPython executable path contains whitespace
(e.g, if IPython is under Local Appdata and your Windows username has
whitespace), the shell command was invalid, quoting the executable is required.
2019-09-22 18:53:44 +02:00
smile13241324
e17008ec2f [java] Fix broken "pu" binding to update user/project settings
"pu" for lsp backends called a lsp-java function which has
been deactivated in the `lsp-java` package. Replaced it with
the closest match from the same package, updating the
project settings instead.
2019-09-18 22:13:24 +02:00
smile13241324
6de34e8b2d [java] Fix various issue introduced by dropping ensime support 2019-09-18 22:00:05 +02:00
smile13241324
cf15de9f20 [java] Make lsp the default backend and drop eclim support 2019-09-18 21:21:55 +02:00
Teo Klestrup Röijezon
4bf5b7be7b Moved Ensime support to the Scala layer, removed Java support 2019-09-18 20:46:53 +02:00
lsp
054856be3d Don't start the lsp server until after mspyls is optionally required
Otherwise, lsp will attempt to use pyls when the user wanted to use mspyls
2019-09-18 19:26:12 +02:00
Koray Al
08cd88a6ea [python] Make pylookup use correct shell 2019-09-17 20:26:04 +02:00
smile13241324
bfce0f2a7d [php] Revise documentation
Describe the various backend choices in more detail.
Move project specific setup for non lsp server to the right section.
2019-09-17 19:10:26 +02:00
Thanh Vuong
d71b0a4b87 [clojure] add c-k c-j bindings company dropdown menu in repl
Make c-j and c-k bind to down and up in company dropdown menu when it shows up
in clojure repl.
2019-09-17 13:22:09 +02:00
smile13241324
efa7d4245f [elixir] Load DAP layer when LSP backend is used
The new elixir LSP server brings DAP support
therefore we now also load DAP layer when the
lsp backend has been activated in the elixir
layer.
2019-09-17 13:15:32 +02:00
smile13241324
020a8b474d [php] Make layer depend on LSP layer if lsp backend is activated 2019-09-17 13:03:01 +02:00
Daniel Richtmann
6d1c7ce57c [php] Enable experimental lsp support 2019-09-17 12:53:43 +02:00
smile13241324
f42b2db568 Make flycheck-mercury init without require 2019-09-16 22:30:43 +02:00
Ludvig Böklin
08576ce34d Add mercury layer 2019-09-16 21:50:02 +02:00
A.L
978f16dcf4 Correct function-format keybinding in EL layer 2019-09-16 20:30:51 +02:00
mpanarin
135a1fd460 [elixir] layer improevements
- declare lsp layer dependency if elixir-backind is lsp
- "C-j" now properly indents line
- add toggle breakpoint for elixir-mode

update CHANGELOG.develop
2019-09-16 18:27:28 +02:00
emacspace
560b51c324 documentation formatting: Thu Sep 12 15:09:22 UTC 2019 2019-09-12 21:44:20 +02:00
Mathieu
ab9acc0810 Fixed go-run-test-current-function for go test and gocheck 2019-09-12 15:25:57 +02:00
pancho horrillo
a7e27370e6 [go] Cleanup README.org
- Consolidate pre-requisites
- Revise document structure
- Clarify setup instructions
- Link key bindings to their supporting tools
- Remove ancient notes on go-oracle
- Fix typos
- Style fixes
- Apply suggestions from code review by @duianto

Thanks to @duianto for the comprehensive review!

Co-Authored-By: duianto <otnaiud@gmail.com>
2019-09-12 14:25:51 +02:00
Jonathan Chen
a326913a9e docs: fix spelling 2019-09-11 18:40:40 +02:00
smile13241324
c1e98e5a36 Make julia layer declare lsp layer as dependency if enabled 2019-09-10 23:00:34 +02:00
Guido Kraemer
22f51cf70a Update julia-layer 2019-09-10 22:35:18 +02:00
smile13241324
b702df7938 Make layers request lsp dependency if lsp has been selected as backend 2019-09-10 22:00:56 +02:00
yqu212
9f72af3b73 Add lazy loading of lsp-python-ms 2019-09-10 21:15:59 +02:00
emacspace
6031fe2a41 documentation formatting: Thu Sep 5 19:09:25 UTC 2019 2019-09-05 21:24:39 +02:00
pancho horrillo
4c1245e8c5 [go] Drop support for deprecated gometalinter
gometalinter¹ was deprecated on 2019-02-28, in favor of the more advanced
golangci-lint.

. Drop references to gometalinter from README.org
. Update reference to available meta-linter (golangci-lint) in LAYERS.org
. Add attribution in CHANGELOG.develop

¹: https://github.com/alecthomas/gometalinter
2019-09-05 20:49:43 +02:00
Benjamin Hipple
61ed84be65 [python] Declare lsp layer dependency when python-backend is 'lsp
Previously, if a user set `python-backend` to `'lsp`, it would not do anything
unless the user also manually added the `lsp` layer to the spacemacs `init.el`
file. This commit updates the `python` layer to correctly add the dependency
when needed, like the `c-c++` layer does.
2019-09-05 20:36:31 +02:00
Gabriel Arrillaga
ec3bb9d660 [elixir] Fix README.org
Change elixir-backend from 'alchemist to 'lsp in LSP config instructions
2019-09-05 20:07:01 +02:00
Caleb Williams
fe77ade0f0 [json] Add option to format on save 2019-09-05 18:58:08 +02:00
emacspace
1299f262ca documentation formatting: Sun Sep 1 21:18:40 UTC 2019 2019-09-01 23:08:29 -04:00
John Stevenson
7afa22e1d0 [Clojure] Update Clojure layer linter documentation
Enhancement to Clojure layer documentation for the clj-kondo linter added via
pul request #12611

Moved instructions to install section as clj-kondo and squiqgly can be added as
Clojure layer variables, just like clj-refactor and sayid.

Changed the install instructions to make them specific and to use clojure layer
variables, which is consistent with other Clojure layer options.

Elaborated on the install instructions to clarify requirements, constraints and
recommended linting tool.

Added credits to the changelog.
2019-09-01 23:07:12 +02:00
emacspace
58d5bb9204 documentation formatting: Sat Aug 31 22:49:15 UTC 2019 2019-09-01 01:13:12 +02:00
Dieter Komendera
578689c497 [clojure] Fix jumping backwards after cider-find-var
`cider-jump-to-var` was renamed to `cider-find-var` here:
ceb2d7df75 (diff-e39c33031dc8d3e78b32ebee83293cd6L809-R846)

In https://github.com/syl20bnr/spacemacs/pull/9792/ `spacemacs/clj-find-var`
was added to be used as the jump handler for clojure modes. It uses
`cider-find-var` which doesn't push jump positions onto the evil jump stack so
the no longer current defadvice was more apparent.
2019-09-01 01:10:29 +02:00
mpanarin
3ee5aedbbf Add elixir-ls as a language backend for elixir 2019-09-01 00:33:39 +02:00
emacspace
7072f61922 documentation formatting: Sat Aug 31 21:42:39 UTC 2019 2019-09-01 00:24:30 +02:00
smile13241324
53553e2307 [python] Add lsp as possible python formatter 2019-08-31 23:21:03 +02:00
smile13241324
290cacf2a9 [python] Bind formatter to == only for LSP backend 2019-08-31 22:55:34 +02:00
cormacc
c4a05f7ebf Corrected keybinding collision (format-buffer)
`spacemacs/python-format-buffer` was bound to '='.
Subsequently clobbered by lsp layer declaration of '=' as prefix with subsidiary
keybindings.
Resolved by moving `spacemacs/python-format-buffer` binding to '=='.
Updated README accordingly.

Opportunistically added 'mspyls' dir to .gitignore
2019-08-31 22:19:53 +02:00
emacspace
592fb5863c documentation formatting: Sat Aug 31 19:04:38 UTC 2019 2019-08-31 22:15:53 +02:00
Luo Tianj
b71c78655f add flycheck-clj-kondo as an optional package 2019-08-31 20:58:30 +02:00
emacspace
e61e91fbc5 documentation formatting: Thu Aug 29 23:13:44 UTC 2019 2019-08-30 01:17:29 +02:00
Sam Hedin
62ea30b479 Add cider clojuredocs keybind, remove grimoire 2019-08-27 21:31:59 +02:00
pancho horrillo
877f577bab [go] Update doc on LSP setup.
`gopls` is Google’s upcoming Go language server; the other implementation
mentioned in the `lsp-mode` doc¹ has been discontinued².

So, I've added the recommended procedure³ to install `gopls`.

¹: https://github.com/emacs-lsp/lsp-mode/
²: https://github.com/saibing/bingo
³: https://github.com/golang/go/wiki/gopls
2019-08-26 17:58:51 +02:00
Rodolfo Hansen
e2d9e32e92 Add lsp-scala and metals as a language backend for scala 2019-08-26 17:50:07 +02:00
Ryota Kayanuma
57baa4ba4a Add kivy layer
Removed the kivy package from the major-modes layer.
2019-08-26 17:09:46 +02:00
Mathieu
272c96d855 Add Testify support for layers/+lang/go 2019-08-21 21:25:49 +02:00
sunlin7
53f1445ecc Fixed the =c-c++-default-mode-for-headers= should not affect the default behavior for Emacs > 26.1+ 2019-08-16 23:55:27 +02:00
emacspace
0ca502823c documentation formatting: Mon Aug 12 19:50:23 UTC 2019 2019-08-13 01:09:55 +02:00
Michael Hauser-Raspe
a500662a69 Add minimal zig mode. 2019-08-12 14:54:36 +02:00
Michael Hauser-Raspe
3df5b43d28 Remove stray ruby file. 2019-08-10 11:32:20 +02:00
Benjamin Levy
600ca198aa Add jump handlers for nasm-mode 2019-08-09 13:28:55 +02:00
yqu212
50203d2c0f Add names to autohotkey mode prefixes 2019-08-08 12:53:16 +02:00
smile13241324
316afaa0fa Make haskell mode bind repl under "'" 2019-08-02 21:33:15 +02:00
Russell Mull
b110ac09f9 Restore standard "si" binding for cider-jack-in-clj
It appears that this is still the common binding across all +lang layers.
2019-07-31 15:55:35 +02:00
emacspace
93af3927ea documentation formatting: Sat Jul 27 13:24:53 UTC 2019 2019-07-28 01:09:03 +02:00
syl20bnr
009777f6cf Add pre-dump for org, emacs-lisp and helm 2019-07-26 16:33:10 -04:00
Thanh Vuong
ce30353b52 js, ts and react layers: linter option
this PR does two things for js-related layers:

(i) add option to disable lsp linter
javascript-lsp-linter for javascript and react layers
typescript-lsp-linter for typescript layer
when the value is t, lsp linter will be used in the layer
when nil, let flycheck pick up the best linters available such
as eslint

(ii) when syntax-checking(flycheck) layer is installed, then set
next-error-function value in react and javascript layers to nil, so that
spacemacs next-error, previous-error work A desciption of this issue can be
found at https://github.com/syl20bnr/spacemacs/issues/8078

Co-Authored-By: duianto <otnaiud@gmail.com>
2019-07-26 18:04:25 +02:00
Vityou
0835acd268 updated racket logo 2019-07-25 06:30:06 +02:00
Pepe Iborra
3e8578340d [haskell] include attrap when Dante is used 2019-07-21 20:23:30 +02:00
Guido Kraemer
e9afae2285 [python] Fixed typos 2019-07-15 22:48:12 +02:00
duianto
280050d4f2 [sql] Add SPC m g prefix: goto
And sort the prefix declarations alphabetically.
2019-07-13 16:06:53 +02:00
Michael Hauser-Raspe
ae7139612b Add sql connect to connect to saved sql connection 2019-07-13 15:53:26 +02:00
John Stevenson
cc43d5c898 [Clojure] keybinding spacemacs/clj-find-var
Update the existing `SPC m g g` keybinding to use the command
`spacemacs/clj-find-var`.  This makes finding a function definition a much
better experience as you dont have to have the REPL running to find a
definition, but when it is you can use a CIDER specific function.

`spacemacs/clj-find-var` is a wrapper that calls `cider-find-var` if the REPL is
running, otherwise it uses `dump-jump-go`.

Wrapper added in #9792
2019-07-13 15:12:55 +02:00
John Stevenson
8fd218f1e8 [Clojure] keybinding for updated repl jack-in commands
Latest CIDER release uses the following commands for starting the REPL from
within Emacs

`cider-jack-in-clj` to start a Clojure REPL
`cider-jack-in-clj&cljs` to start a Clojure and ClojureScript REPL
`cider-jack-in-cljs` to start a ClojureScript repl

The older aliases are deprecated and are being removed in the latest beta
release of CIDER

`cider-jack-in`
`cider-jack-in-clojurescript`

Keybindings for these jack-in commands have been updated and as there are three
options they have been moved under the repl > jack-in

The top level of the Clojure mode menu has the existing keybindings updated to
use the new commands.  A third top-level keybinding `&` has been added for
`cider-jack-in-clj&cljs`
2019-07-13 14:41:06 +02:00
duianto
e12278a323 Revert "[Clojure] Keybinding require Clojure repl utils in current namespace"
This reverts commit 034ee0c311.

It was rebased with the previous commits message.
2019-07-13 14:40:44 +02:00
John Stevenson
034ee0c311 [Clojure] Keybinding require Clojure repl utils in current namespace
Although the Clojure repl utils (clojure.repl) are including in the user
namespace in Clojure projects, they are not available in your application
namespace.

The existing CIDER function cider-repl-require-repl-utils adds the Clojure
repl utils into the current namespace, so you can use functions such as doc
and source.

This is often a source of confusion for those new to Clojure / CIDER.
2019-07-13 12:50:11 +02:00
John Stevenson
cd95789170 [Clojure] Keybinding require Clojure repl utils in current namespace
Although the Clojure repl utils (clojure.repl) are including in the user
namespace in Clojure projects, they are not available in your application
namespace.

The existing CIDER function cider-repl-require-repl-utils adds the Clojure
repl utils into the current namespace, so you can use functions such as doc
and source.

This is often a source of confusion for those new to Clojure / CIDER.
2019-07-13 11:52:32 +02:00
Robert Zaremba
d642095380 layer/+lang/go: refactore go-linter setup 2019-07-11 19:22:18 +02:00
JAremko
6c12121cec fix links 2019-07-08 23:56:07 +03:00
Trapez Breen
9dbc0b9d0c Fix failing lsp-python-ms setup
Configuring lsp-python-ms variables properly.
2019-07-07 11:26:26 +02:00
Vikash Balasubramanian
3ed24436cd Enables eldoc for anaconda-mode 2019-07-07 09:07:17 +02:00
Vikash Balasubramanian
5def0eaae5 Fixes flycheck support in jsonnet files 2019-07-06 18:59:38 +02:00
Jonathan Chen
28adf374fe feat(clojure-lang): add cider-eval-sexp-at-point
Adds a useful CIDER command that doesn't have an idiomatic Spacemacs command.

Ref:
https://cider.readthedocs.io/en/latest/interactive_programming/#using-cider-mode
2019-07-06 00:17:03 +02:00
JAremko
b5af9b0b5d update .org tags 2019-07-03 11:32:58 +03:00
Ivan Yonchovski
f892ba3091 Remove the fix-lsp-company-prefix since it is no longer needed
- company-lsp is now smarter and supports fuzzy matching
2019-07-01 13:28:42 +02:00
Olivier Verdier
7818fa3ccf add bindings to navigate between errors in tex mode 2019-06-28 20:32:11 +02:00
emacspace
0b0497d592 documentation formatting: Tue Jun 25 10:18:15 UTC 2019 2019-06-26 01:32:08 +02:00
Dave Aitken
f40361fd64 Add reasonml layer 2019-06-25 12:03:36 +02:00
Georgi Lyubenov
f2a6872afb Adapt agda2-auto call to agda 2.6.0 changes
* It's now agda2-auto-maybe-all. If you are not currently in a hole
it tries to `auto` all holes by default.
* Find and set an agda-version variable, to keep compatibility with
previous agda versions.
2019-06-23 16:47:33 +02:00
Jim Pudar
0f40fe9df2 Improve point handling in perltidy functions
This moves the point and content of the window close to where you were
before you ran perltidy. Of course if perltidy adds or removes a
significant amount of characters / lines as part of tidying, the point
will be moved by that amount. However in practice this I've found this
to be close enough.
2019-06-21 19:04:34 +02:00
emacspace
cbe174021c documentation formatting: Mon Jun 17 06:48:02 UTC 2019 2019-06-17 09:05:38 +02:00
cormacc
b80154bd52 Corrected instructions relating to ms language server from git 2019-06-15 23:55:20 +02:00
John Stevenson
bb34374818 Add keybinding for cider-interupt
Interrupt longer running evaluations without having to kill or reset the REPL
connection.

Placed in the evaluate section, as it is specific to the currently running
evaluation.
2019-06-13 15:27:02 +02:00
duianto
47f83609d5 [clojure][doc] markdown inline code to org verbatim
Change surrounding characters: markdown inline code to org verbatim.
2019-06-13 01:27:48 +02:00
Michael Franz Aigner
ddf7459a02 Fix lazy-loading of ruby-test-mode
This change fixes a syntax mistake in the use-package declaration of
ruby-test-mode that causes the package to be loaded immediately, instead of
deferring the load until the first ruby file is visited, as is intended.
2019-06-12 19:37:26 +02:00
Liu Chong
bd61f2e8a0 Remove cider.nrepl/cider-middleware in lein quick start setting
Don't need this `cider.nrepl/cider-middleware` in lein profiles.clj.

It will result in error, the `cider.nrepl/cider-middleware` not middleware but a vector of all cider-nrepl middlewares:

> https://github.com/clojure-emacs/cider-nrepl/blob/master/src/cider/nrepl.clj#L483
2019-06-12 19:31:16 +02:00
emacspace
3d4e6fc0df documentation formatting: Sun Jun 9 19:54:33 UTC 2019 2019-06-09 22:02:10 +02:00
sunlin7
70a5a40d54 Make projectile recognize C++ projects by search for ".ccls" file 2019-06-09 21:59:46 +02:00
smile13241324
9ebf17af49 Make javascript layer adhere to REPL conventions and fix typescript doc 2019-06-09 21:21:30 +02:00
Uros Perisic
eee7d20bfe Add and configure nodejs-repl package to javascript layer.
Add relevant keybindings and documentation, including a setting
`js2-include-node-externs` as a configuration variable for those that intend to
use `Spacemacs` for node projects, as it currently seems to be mostly aimed at
pure JS (https://github.com/syl20bnr/spacemacs/issues/483).
2019-06-09 18:29:08 +02:00
Ryan
f1d55ed002 Add eslint as option for linting typescript 2019-06-09 17:59:01 +02:00
刘冲
803d4e7202 Fix mismatched brackets in markdown README
Added a missing close bracket and removed the useless line `dotspacemacs-configuration-layers '(`
2019-06-08 21:49:23 +02:00
Magnus Therning
37dcecbec9 Put the jump handlers straight into the buffer var
Fixes #12238
Fixes #12289
2019-06-06 14:36:09 +02:00
duianto
4cb9226302 Update changelog.develop and markdown readme 2019-06-05 22:45:34 +02:00
AmaiKinono
234c7e7e10 rebind markdown-insert-list-item to M-RET M-RET 2019-06-05 22:28:49 +02:00
AmaiKinono
0fcdf44b34 Add various keycommands to markdown layer. 2019-06-05 22:28:49 +02:00
Anton Alekseev
832ddd4268 Enable prettier formatter for HTML buffers 2019-06-05 18:48:54 +02:00
emacspace
fc36771313 documentation formatting: Sun Jun 2 20:15:51 UTC 2019 2019-06-02 23:47:05 +02:00
cormacc
00b2db982d Added support for Microsoft Python Language Server
<<26/04/2019>>
Incorporated feedback from robbyoconnor and yyoncho.
Rebased.

<<08/04/2019>>
Rebased on develop tip

<<17/04/2019>>
Rebased

<<02/06/2019>>
Rebased. Incorporated feedback from duianto.
2019-06-02 21:14:50 +02:00
Boris Buliga
06730f24cc use orgtbl-mode only when org layer is used
1. Fixes #6535 - when org layer is not used, user will see an error upon
   visiting markdown file.
2. Mention orgtbl-mode in readme.
2019-06-02 20:50:51 +02:00
duianto
3868a5364f [doc] Fix typos and add missing/remove extra ~
Add missing ~ (tilde) around key bindings.
Remove an extra ~.
2019-06-01 20:40:22 +02:00
duianto
7dace901a2 [javascript][doc] Update key toggle live evaluation
The key binding was changed in this commit:
javascript: change key binding for repl live eval toggle
8bc9060af8

This updates the documentation.
From: SPC m s a
To:   SPC m T l
2019-06-01 14:49:27 +02:00
Seong Yong-ju
ff4a08d3fa Add a missing prefix for plantuml-mode 2019-05-31 18:12:41 +02:00
Seong Yong-ju
59504029b1 Configure emmet-mode for typescript-tsx-mode 2019-05-31 17:57:37 +02:00
Seong Yong-ju
1e00461dd8 Organize the header file includes in C++ buffer 2019-05-31 17:34:36 +02:00
Seong Yong-ju
80ff9053a3 Add rubocopfmt to format Ruby buffers 2019-05-31 16:58:57 +02:00
Seong Yong-ju
afa3dd0870 Add LSP support for stylesheet buffers 2019-05-31 16:37:02 +02:00
Christopher Eames
39ce04ccd9 fix indent-command. 2019-05-28 18:40:20 +02:00
benbotwin
d1934f8e30 [sql] Add send line functions
Add wrappers forcing non-pop commands to not pop to the SQLi buffer
2019-05-28 18:06:28 +02:00
emacspace
2aa62bb5ed documentation formatting: Tue May 28 14:41:10 UTC 2019 2019-05-28 17:43:54 +03:00
JAremko
ce4e6e355f tag docs 2019-05-28 17:35:49 +03:00
David Parrish
0f9315e634 Add FAQ entry for using hlint with Intero backend 2019-05-28 13:04:08 +02:00
et2010
2e6e69eeff latex layer: add company-reftex 2019-05-28 11:47:03 +02:00
Billy Kaplan
5a0ab04653 Adding Ruby LSP Backend and DAP support 2019-05-27 22:09:31 +02:00
emacspace
c7c348a676 documentation formatting: Sun May 26 20:58:52 UTC 2019 2019-05-27 01:23:35 +03:00
Ivan Yonchovski
23df5aa55e [java] Sync java lsp backend with latest lsp-java functionality
- new keybinds for the new functionality
2019-05-20 20:26:14 +02:00
JAremko
5cc823cc0f add flycheck-clojure 2019-05-18 02:17:43 +03:00
JAremko
988e6778ba
fmt docs 2019-05-15 21:10:07 +03:00
Anton-Latukha
f6660f82d4
Switch to the new layers generator 2019-05-15 21:08:21 +03:00
Anton-Latukha
2ee74f55da layers: lang: new structure: add DSL (&markup), framework, util
layers: lang: mv framework -> programming/framework

layers: programming: framework: upd
2019-05-15 21:05:09 +03:00
Anton-Latukha
ba074bc908 layers: lang: new structure: general: add pure, multi-paradigm (&js) 2019-05-15 21:04:48 +03:00
syl20bnr
c471d91757 [ocaml] Sort key bindings 2019-05-12 21:57:17 -04:00
Lyman B. Gillispie
af55934995 [ocaml] Add support for dune via dune-mode.
Dune is a popular build-tool for OCaml projects, the `dune` package adds:
 - Adds syntax highlighting
 - Template insertion
 - Some testing/compilation functions
2019-05-12 22:22:13 +02:00
syl20bnr
6bb459fcf1 [alda] Sort key bindings 2019-05-12 11:31:01 -04:00
syl20bnr
8c9f3f8c4f [alda] Add image to README.org 2019-05-12 11:29:15 -04:00
syl20bnr
0d123b28db [csharp] Change execute test key bindings to conventional ones
~SPC m t t~ is for test around point
~SPC m t l~ is to re-execute the last test
2019-05-12 10:09:10 -04:00
syl20bnr
6d8040f2db Replace some if by when where appropriate 2019-05-12 10:01:05 -04:00
syl20bnr
949b194bbd [common-lisp] Document new key bindings for evaluation 2019-05-12 09:54:39 -04:00
emacspace
7a9c455277 documentation formatting: Sun May 12 07:27:10 UTC 2019 2019-05-12 09:29:46 +02:00
duianto
5f0c40abb1 [alda] Update readme.org
Removed Table of Contents, the documentation bot will insert the correct TOC.
2019-05-12 09:19:30 +02:00
Andrew Hill (AstroEngiSci)
875ce4c85f Add Alda configuration layer 2019-05-12 00:30:20 +02:00
Brandon T. Willard
289cd5ad42 Update Hy key maps and use-package settings
These changes adjust the `hy-mode` key-map and make use of `use-package`'s
`:mode` and `:interpreter` settings.

Regarding key-maps, the REPL prefix `s` has been added alongside `e`, since `s`
seems at least as conventional among layers as `e`.  Although `e` is used for
Elisp and Clojure, it isn't used for Python or Racket.  Scheme appears to use
both, so there's some precedence for the approach used here.
2019-05-06 17:06:48 +02:00
Alex Palaistras
8fb3be891d sql: Add default jump handlers for SQL layer
Recent versions of `dumb-jump` have support for jumping to definitions for generic SQL buffers, and
support in Spacemacs requires that we enable these in the `sql` layer.
2019-05-05 22:42:08 +02:00
JAremko
77c680160e Add placeholder tags 2019-05-05 20:40:47 +03:00
Bet4
6c403bd004 semantic: disable idle summary when lsp is enabled
Solved #10477
2019-05-04 17:18:28 +02:00
Bet4
bb86989775 semantic: enable company and disable idle summary when gtags is enabled 2019-05-04 17:18:28 +02:00
JAremko
5d02b1c4bb Add more tags 2019-05-03 03:44:19 +03:00
duianto
b26ea277fb Add documentation to two toggles
Two `SPC h SPC` toggles were missing their documentation:
- Nameless
- Minibuffer System Monitor (the symon package)

Now they match the other entries by showing:
- current state
- name (this was only shown before)
- documentation
- key binding (only minibuffer-system-monitor shows a key binding)

The nameless key binding `SPC m T n` only works in emacs-lisp-mode. It's key
binding might need to be described another way.
2019-05-01 01:24:12 +02:00
Artur Juraszek
033e960c94 Keyword flycheck-ocaml with :toggle instead of using a when 2019-04-30 18:50:39 +02:00
JAremko
fbff2ca7bc Doc fixes + some tags for testing
Add new LAYERS.org generator [WIP]
2019-04-28 07:03:09 +03:00
JAremko
aa7f1d7e0f Reword changelong message in CI 2019-04-28 07:03:09 +03:00
emacspace
6f6b064c7e documentation formatting: Sat Apr 27 00:15:28 UTC 2019 2019-04-27 02:23:35 +02:00
duianto
28571f4465 [csharp] Hide mode-line indicator: omnisharp 2019-04-27 02:07:37 +02:00
duianto
603d36c5dc [csharp] Add SPC m t which key prefix: csharp/tests 2019-04-27 01:57:34 +02:00
Saulius Menkevičius
708aabe64c Add more key mappings for unit test functionality in csharp layer. 2019-04-26 22:21:39 +02:00
Trapez Breen
9665670f8e Adding format on save to javascript layer.
Adding formatting on save option to javascript layer, similar to typescript
layer. One small syntax error fix in typescript layer.
2019-04-25 20:26:07 +02:00
Bet4
44cd57d2e2 Remove the use of 'spacemacs|advise-commands' 2019-04-25 19:30:29 +02:00
Bernhard Schommer
31bff63404 [ocaml] Fix typo in diagnostic message. 2019-04-24 16:33:00 +02:00
emacspace
202da65b1c documentation formatting: Sun Apr 21 20:04:25 UTC 2019 2019-04-22 23:16:20 +02:00
JAremko
23842fa77e Simplify descriptions of layers 2019-04-21 22:09:34 +03:00
John Stevenson
831107f478 [clojure] keybinding - cider-undef - remove symbol from current ns
Adds `SPC m e u` to the Clojure layer to call `cider-undef`, removing an
existing definition from the current namespace.

This provides a Spacemacs style keybinding for the existing Emacs style
keybinding `C-c C-u`
2019-04-20 15:26:55 +02:00
Aaron Jensen
f977732687 emacs-lisp: Initialize flycheck-package 2019-04-18 21:46:32 +02:00
emacspace
912f69ef9d documentation formatting: Thu Apr 18 19:16:31 UTC 2019 2019-04-18 21:39:10 +02:00
Ivan Yonchovski
e80a4fa0ab [rust] dap layer integration 2019-04-18 21:32:32 +02:00
Thanh Vuong
9bb9038920 Move "import-js" to own layer for js based layers
Refactor import-js to its own layer import-js so it can be optional
used for the tree layers Javascript, React and Typescript layers.
2019-04-18 21:08:43 +02:00
smile13241324
072c01f5f5 Fix binding for "capitalize keywords" in sql-layer
Noticed a new warning during startup saying
that sqlup-mode is using "=c" where "=" is no
prefix key. Noticed that the entire binding
was not carried out in this case.

Therefore I have removed "=" from the binding
but left it on "c" until enough text
manipulations are available, then it should
be moved to "x text manipulation" group instead.
2019-04-18 18:58:40 +02:00
Mike Macpherson
c339656172 python: Add support for black formatter 2019-04-18 18:34:09 +02:00
Newres Al Haider
f5cd5959b3 Add Prolog layer 2019-04-18 18:14:18 +02:00
Trapez Breen
d25b329c17 Shadow python-mode-hook during python-send-shell-* 2019-04-18 17:56:47 +02:00
emacspace
0b90e116f5 documentation formatting: Wed Apr 17 13:48:54 UTC 2019 2019-04-17 23:36:35 -04:00
Seong Yong-ju
610ecbbf70 Add godoc installation into go layer README 2019-04-17 15:37:52 +02:00
Seong Yong-ju
e48fa85d96 Add missing prefix for js2-mode 2019-04-17 15:37:15 +02:00
Trapez Breen
2206095be8 Added instruction on installing importmagic and epc.
Importmagic and epc isn't really optional if error messages are to be avoided.
2019-04-17 09:14:01 +02:00
trapez.breen
a8b7c0d591 Adding the same setup to typescript-tsx files as to typescript files.
Changed typescript major mode formating to "=".
2019-04-17 00:13:58 +02:00
Ivan Yonchovski
2129f203c4 [javascript] integration with dap layer
- Fixed also instructions on language server selection
2019-04-16 23:46:48 +02:00
duianto
e726a70685 Revert "Remove form-feed characters"
This reverts commit bd91a0b2b8.

The form-feed characters are used in multiple places.
2019-04-16 22:35:42 +02:00
emacspace
3e97b8e8f3 documentation formatting: Mon Apr 15 20:21:30 UTC 2019 2019-04-15 22:56:31 +02:00
Ivan Yonchovski
f4264b5df1 [c++] dap layer integration
- in addition to that I have removed the line that removes clangd from the
server list since it is not needed in latest lsp-mode since it has smaller
priority than ccls/cquery.
2019-04-15 22:13:23 +02:00
Ivan Yonchovski
03e6bc0691 [java] init backends conditionally
- otherwise there are shortcut collisions
2019-04-15 21:20:32 +02:00
Ivan Yonchovski
59c4f1f283 Use dap mode layer for python debugging
- I had to remove the "db" keybinding manually before setting the dap bindings.
  An alternative approach is to use a different binding for it.
2019-04-15 20:56:27 +02:00
Francesc Elies Henar
01bd56f120 [csv] binds SPC m h to csv-header-line 2019-04-13 14:31:55 +02:00
emacspace
6cde1e49bc documentation formatting: Fri Apr 12 19:31:31 UTC 2019 2019-04-12 22:02:05 +02:00
smile13241324
6a32d31da8 Fix accidental activation of flycheck-pos-tip-mode in emacs lisp layer
The issue was that `flycheck-package` explicitly
activated `flycheck-pos-tip-mode` however
this package is owned by `syntax checking layer`
and should only be activated by it directly.
2019-04-12 20:31:37 +02:00
Bruno Tavares
9e2da23c12 Removes workarounds and update flycheck integration
This commit removes the workarounds needed on older versions of `dart-mode` library, now that many of the fixes have landed.

This commit also fixes the integration with flycheck, as there is a new function used on the `develop` branch.
2019-04-12 18:00:00 +02:00
Bruno Tavares
7841d3ba6a Introduces Dart layer
This is a initial implementation of a Dart later.
A [previous implementation] has been deprecated, using a forked version of `dart-mode`.

This layer uses the [dart-mode] linked on the [Dart tools] page.
The layer works with a Flutter installation as well.

Ideally, we would be able to offer a `lsp` backend as an option to use, instead
of using the Dart Analyzer, but I'm still figuring out how to implement and
integrate this.

This layer has [some] [fixes] to make it work, and it is waiting for upstream to
take patches.

- Resolves https://github.com/syl20bnr/spacemacs/issues/8333
- Resolves https://github.com/syl20bnr/spacemacs/issues/8395
- Resolves https://github.com/syl20bnr/spacemacs/issues/10452

---
[previous implementation]: https://github.com/syl20bnr/spacemacs/pull/8406
[dart-mode]: https://github.com/bradyt/dart-mode
[Dart tools]: https://www.dartlang.org/tools
[some]: https://github.com/bradyt/dart-mode/pull/67
[fixes]: https://github.com/bradyt/dart-mode/pull/66
2019-04-12 18:00:00 +02:00
Uros Perisic
66b3a0ba01 Make spacemacs/nim-compile-run work with current buffer file.
Naming the main file `main.nim` is a `C` convention, not a `Nim` convention. In
fact, `Nimble` defaults to naming the main file after the project at
initialization. I will soon add a function that parses the Nimble configuration
for project entry point and compiles that. Until then, this is a solid
compromise between flexibility and reliability. I also added a doc-string to the
function.
2019-04-11 23:13:15 +02:00
Serghei Iakovlev
6e404256e2 Update ac-php-core documentation 2019-04-11 22:51:01 +02:00
jjzmajic
8b88025ef8 Add flycheck-package' to emacs-lip' layer for writing Emacs packages.
For those with MELPA on their mind. It's easier to work when packaging errors
are reported on the fly, and we don't even have `package-lint` integration for
occasional checkups yet.

It adds no unnecessary verbosity as it is only triggered by `Package-Requires`
and `Package-Version` headers.
2019-04-11 22:46:16 +02:00
Michael Peyton Jones
36be37e142 Let lsp-mode configure company 2019-04-11 13:18:42 +02:00
Michael Peyton Jones
07bec0cb62 Haskell layer: add support for lsp backend 2019-04-11 13:18:42 +02:00
Michael Peyton Jones
bd91a0b2b8 Remove form-feed characters
As requested in the review of
https://github.com/syl20bnr/spacemacs/pull/11550.
2019-04-11 13:18:42 +02:00
Boris Buliga
ed41e61644 [haskell] remove emacs version toggle from dante
This is no longer represents the real situation as dante requires Emacs >= 25.1
2019-04-11 13:18:42 +02:00
Boris Buliga
3683c0ba23 [haskell] fix completion in literate haskell files 2019-04-11 13:18:42 +02:00
Boris Buliga
4c55d33920 [haskell] do not toggle completion backends 2019-04-11 13:18:42 +02:00
Boris Buliga
54f69e3a96 [haskell] support dynamically set backend 2019-04-11 13:18:42 +02:00
Christian E. Hopps
446299ffbd IETF related layers and packages. 2019-04-11 00:03:40 +02:00
Magnus Therning
6184a391b4 [sql] Add SQL support to org-mode 2019-04-10 23:04:02 +02:00
Seong Yong-ju
cb75920bb7 Add missing key prefixes for java-mode, gradle-mode 2019-04-10 22:48:21 +02:00
Lukas Woell
1d77bf1046 Add eval-thing-at-point functions to Common Lisp Layer
Add functions equivalent to the custom eval-funtions of the elisp layer to the
common-lisp layer.

The functions are copied from the elisp layer only `eval-last-sexp' was replaced
with its slime equivalent `slime-eval-last-expression'.

Keybindings are chosen as they are in the elisp layer.
2019-04-09 23:29:09 +02:00
emacspace
584084ab2d documentation formatting: Mon Apr 8 15:39:05 UTC 2019 2019-04-09 23:11:10 +02:00
Uros Perisic
3e827297fd Declare all prefixes for nim layer.
All prefixes for `nim-mode` were previously unnamed, and simply stated `+prefix`.
2019-04-09 22:14:30 +02:00
Martin Račák
f85acca55d Fix post-init of parinfer in the clojure layer
Reverted clojure/post-init-parinfer back to a state before the refactor, which
introduced spacemacs|forall-clojure-modes. That macro deals with modes, not
hooks, therefore we can't use it for add-hook.
2019-04-08 18:17:22 +02:00
syl20bnr
1402cbc203 [javascript] remove unneeded progn 2019-04-08 11:19:18 -04:00
Seong Yong-ju
ff3d6e2ba1 Add import-js into javascript layer 2019-04-08 11:19:18 -04:00
Alexander Dalshov
b3c185daf5 c++ ccls - rename cacheDirectory cacheFormat to cache.{directory,format} 2019-04-07 19:49:24 +02:00
Ag Ibragimov
1dadfcd0e1 [clojure] Improves spacemacs-jump-handlers
jump handlers in clojure modes now correctly work
for: `, g g` `, g G` `gd` and `gD`
2019-04-07 18:22:51 +02:00
yuhan0
7a9a95b806 Declare purescript prefixes in purescript-mode 2019-04-07 18:07:57 +02:00
hasan356
5606f4e258 Fixes #5158
Backspace in tuareg-mode does not delete the character.
2019-04-07 11:04:06 +02:00
smile13241324
350dbf6373 Move go "generate" prefix declaration to "go-gen-test" init 2019-04-07 08:43:18 +02:00
Luke Worth
0eff6c1ca7 Document cabal-new-repl as a valid haskell-process-type
See
5b9a3e3688
2019-04-07 08:26:12 +02:00
Seong Yong-ju
09835e1ed2 [sql] Add a code formatter for sql-mode
Add sql layer options for sqlfmt. Add a function spacemacs/sql-format-buffer to
format the whole buffer with sqlfmt. Add a key binding for format.
2019-04-06 16:20:23 +02:00
Thanh Vuong
a01994292d [javascript] Fix hook value to enable evil-matchit
hook value shoudle be js2-mode-hook instead of js2-mode
2019-04-06 09:54:01 +02:00
Seong Yong-ju
9941c60b5c Add missing prefixes in go-mode 2019-04-05 23:21:15 +02:00
Enze Chi
21c442050a Add go-run-args to pass command line arguments to go run
When executing the main function which requires command line arguments, user can
set `go-run-args` to pass command line arguments to compiled binary.

The example below demonstrates how to pass command line arguments by setting
`go-run-args` as file local variable:

package main

import (
	"fmt"
	"os"
	"strconv"
)

func main() {
	//Atoi converts a string to an int
	fmt.Println("Arguments:", os.Args)
	a, _ := strconv.Atoi(os.Args[1])
	b, _ := strconv.Atoi(os.Args[2])

	result := sum(a, b)
	fmt.Printf("The sum of %d and %d is %d\n", a, b, result)
}

func sum(a, b int) int {
	return a + b
}

// Local Variables:
// go-run-args: "10 5"
// End:
2019-04-05 22:59:17 +02:00
Colin Woodbury
0b2e30b115 dhall: add missing colon in README 2019-04-05 18:26:28 +02:00
Colin Woodbury
a804043540 dhall: README and logo 2019-04-05 18:26:28 +02:00
Colin Woodbury
143f136224 dhall: First pass at Dhall layer
Just a very simple pass-through to the underlying `dhall-mode`.
2019-04-05 18:26:28 +02:00
emacspace
18a998b675 documentation formatting: Thu Apr 4 16:29:54 UTC 2019 2019-04-04 23:19:59 +02:00
Timo Freiberg
4351063f6a [clojure] change run-all-tests alias to run-project-tests
The previous docstring said that there's a bug with cider-test-run-project-tests
but it seems to work fine now
2019-04-04 16:43:59 +02:00
Timo Freiberg
978df8a70e [clojure] call cider-test-* functions interactively 2019-04-04 16:18:46 +02:00
timor
7b5ce34e65 [factor] Misc fixes for factor version 0.98
Since factor 0.98, `fuel-edit-word` has been removed, since
`fuel-edit-word-at-point` has the same behavior when point is not on a symbol.
Also adjust the jump-handler definition.

factor: choose correct name for the `fuel` package

The package is called `fuel`, not `factor-mode`.

This does not make a difference for the layer itself, since it is using the
`site` pseudo-location, and thus never deals with the package files.

Now, any `post-init-fuel` functions defined somewhere else should work
correctly.

factor-layer: add missing refactor command binding, fix initial modes
2019-04-04 13:16:05 +02:00
Grant Shangreaux
71a06c8b99 update docs for Chicken 5 changes 2019-04-04 12:52:09 +02:00
Tim Heckman
e84bd90262 Set lsp-prefer-flymake to :none when Go layer is using LSP
When switching the Go layer to use the LSP backend with `golangci-lint`, I
noticed that none of my linter errors were being rendered with my source code.
Digging in further, I eventually learned it was due to `lsp-prefer-flymake`
being set to `nil` and not `:none`.

This change updates the Go layer, when using LSP and golangci-lint, to set
`lsp-prefer-flymake` to `:none`. If this is not set, the golangci-lint errors
will not be reported.

This is an alternative to #12043.

Fixes #11680

Signed-off-by: Tim Heckman <t@heckman.io>
2019-04-04 12:46:49 +02:00