When the bépo layout is set from the `keyboard-layout` layer, the
message `(wrong-type-argument keymapp nil)` shows up. After some
digging, it turns out Spacemacs tries to set shortcuts for `nil`
`map` variables in this function.
This commit ensures it is impossible to try to set a shortcut for an
inexisting keymap.
This commit has been tested with Emacs 27.0.90.
It also removes an unused `if` statement
keyboard-layout was broken by commit da80634, which replaced cl by
cl-lib. Some function calls weren’t replaced. There may be old calls
remaining in other layers.
Magit now uses Transient instead of magit-popup, and we must adapt. Also had to
replace the recently removed magit-diff-buffer-file-popup with
magit-diff-buffer-file (similar but doesn't offer a popup before displaying the
diff).
Note some upstream packages haven't adapted to this change, but when they do we
might need similar fixes:
- magithub
- magit-gitflow
- magit-svn
Text:
- Rewrite, add missing words, etc.
- Remove the begin and end verse block lines, but kept the verse block text,
because Github doesn's show text in .org verse blocks.
- Change _after_ to *after*, because Github doesn't show underscores in .org
files.
- Add the Colemak, Dvorak and Workman layouts vim movement key bindings, and the
key bindings for the lost (overwritten) keys.
- Fix the image link to the workman layout image, it was missing the square
brackets.
- Link replaced: The workmanlayout.com domain name seems to have been lost.
Google Chrome warns "Your connection is not private", and the advanced
information states that the security certificate is from a "just host" domain.
The most stable replacement link seems to be the workman section on the
keyboard layout wikipedia page.
- Indicate the images that have been modified, as suggested by the CC BY-SA
Attribution section.
Images:
- Add the dvorak simplified layout.
- Fix the programmer dvorak layout, the transparent key faces made it almost
invisible when viewed in Spacemacs with a dark background.
- Rename images for type, consistency, and most common usage:
use logo instead of layout for logo names, and use layout for all layout
images, instead of keymap for some and layout for others. Layout is the most
common name, wikipedia even redirects keymap to the keyboard layout page.
- Reduce their width to 640px, so that they fit within column 80.
problem:
The keyboard layouts main image, is displayed as a black rectangle, when the
readme.org file, it's opened in Spacemacs. This seems to be because there's an
issue with the transparency when a .png is saved with indexed colors.
When the transparency issue is fixed, by re-saving it as a non-indexed
(grayscale or RGB) image. Then there still is an issue, with themes that have a
dark background, i.e. spacemacs-dark. The black keys become almost invisible.
solution:
Add a 1px gray border, around the keys.
- Base Remapping Keys
`#{n, e, i, o}` <=> `#{h, j, k, l}`
- setting `avy` keys to the `colemak` home row keys
`#{a, r, s, t, n, e, i, o}`
- adjusting leader key to `tn`
- overriding evil org mode bindings especially for 'o'
- one character key guess rebindings can give back empty string
when looking for the prefix and it isn't empty, then guess the rebindings --
this fix lets the check not pass and return `'(nil nil)`, allowing the
`(remove-if #'null)` to actually work.
- correcting magit staging when using visual line
The motivation is to clean redundent actions and bring more consistency
between `SPC b` and `SPC w` by:
- using capital letters for ace-window actions
- reusing the same letters between window and buffer when possible
- adding support for universal prefix argument to delete both window
and buffer
Details of changes:
Buffer
- `SPC b k` has been removed since the functionality is
available directly in Helm by selecting the kill buffer action
- `SPC b m` (buffer move) has been removed because the functionality
is available via `SPC w` with `SPC w h/j/k/l`, `SPC w H/J/K/L` and
`SPC w M` (see window section for the new `SPC w M`).
- `SPC b K` (kill other buffers) is now `SPC b m` to map with `SPC w m`
(kill other window or maximize). Using the universal prefix argument
`SPC u SPC b m` will also kill the windows.
- `SPC b C-k` (kill buffer matching regexp) is now simply on `SPC b k`.
- `SPC b D` now kills a buffer using ace-window.
- `SPC b d` and `SPC b D` now accept an universal prefix argument to
also delete the window. So `SPC u SPC b d` and `SPC u SPC b D` delete
the buffer and the window.
Window
- `SPC w M` now swap the window using ace-window.
- old `SPC w M` (center window) is now on `SPC w c` and `SPC w C` uses
ace-window.
- `SPC w SPC` (select window) is now on `SPC w W` since it uses
ace-window.
- `SPC w d` and `SPC w D` now accepts an universal prefix argument to
delete the window and the buffer.
