Kp
b6a7f63e5d
Pass UI_DIALOG& to ui_gadget_calc_keys
2020-10-12 03:28:26 +00:00
Kp
d7bff3daf3
Pass UI_DIALOG& to ui_dialog_do_gadgets
2020-10-12 03:28:25 +00:00
Kp
f79e0343d9
Pass UI_DIALOG& to ui_gadget_send_event
2020-10-12 03:28:25 +00:00
Kp
6ff47e2a18
Pass UI_DIALOG& to ui_add_gadget_listbox
2020-10-12 03:28:25 +00:00
Kp
33beedc9fd
Pass UI_DIALOG& to ui_draw_listbox
2020-10-12 03:28:25 +00:00
Kp
b30d60a521
Pass UI_DIALOG& to ui_gadget_add
2020-10-12 03:28:25 +00:00
Kp
b19e0698a1
Simplify out ui_dialog_get_window
...
UI_DIALOG now extends window, so the conversion is implicit.
2020-10-12 03:28:25 +00:00
Kp
8547c918c2
Make ui_file_browser inherit from UI_DIALOG
2020-10-12 03:28:25 +00:00
Kp
563ac19708
Make menu.cpp menu inherit from UI_DIALOG
2020-10-12 03:28:25 +00:00
Kp
c1ce3a2938
Pass explicit nullptr for ui_create_dialog createdata
2020-10-12 03:28:25 +00:00
Kp
1864f2dfdf
Remove unnecessary UI menu member button
2020-10-12 03:28:25 +00:00
Kp
46dc19f539
Make messagebox inherit from UI_DIALOG
2020-10-12 03:28:25 +00:00
Kp
7fb4f7b396
Use std::array for editor mine filename
2020-10-12 03:28:25 +00:00
Kp
a6abf76d0a
Use enum class for index into ObjBitmaps
2020-10-07 03:59:14 +00:00
Kp
24497fa085
Use enum class for bmread mode selector
2020-10-07 03:59:14 +00:00
Kp
c482d01be5
Move some fvi types to namespaces
2020-10-01 03:25:27 +00:00
Kp
b136994551
Move valptridx<segment> to dcx
...
segment is now dcx, so move the valptridx wrapper.
2020-10-01 03:25:27 +00:00
Kp
e6126b800f
Reorder endlevel definitions to split by dcx/dsx
2020-10-01 03:25:27 +00:00
Kp
1fc8663eff
Improve ui_add_gadget_inputbox length handling
...
Fix potential buffer overflow if `length` (now `length_of_initial_text`)
is less than the `strlen` computed length of text.
Rename variables to clarify usage.
Eliminate the unnecessary use of `strlen`.
2020-09-28 03:32:15 +00:00
Kp
88ab83c354
Remove write-only field UI_GADGET_INPUTBOX::slength
2020-09-28 03:32:15 +00:00
Kp
9a5e968646
Use std::unique_ptr for UI_GADGET_INPUTBOX::text
2020-09-28 03:32:15 +00:00
Kp
59ca93f219
Simplify copy+uppercase pattern in editor code
...
Change d_strupr to both copy and uppercase, instead of using strcpy to
copy and then a separate phase to rewrite the text as uppercase.
2020-09-28 03:32:15 +00:00
Kp
a6b8012b5d
Make editor_dialog inherit from UI_DIALOG
2020-09-21 03:18:12 +00:00
Kp
e4442a1b05
Remove code for ORTHO_VIEWS
...
Support for ORTHO_VIEWS has been broken since commit
db514a5ded
in December 2004.
`git blame HEAD -L872,+4 -- similar/editor/meddraw.cpp`:
```
db514a5ded
main/editor/meddraw.c (Bradley Bell 2004-12-19 13:54:27 +0000 872) }
db514a5ded
main/editor/meddraw.c (Bradley Bell 2004-12-19 13:54:27 +0000 873) } else
db514a5ded
main/editor/meddraw.c (Bradley Bell 2004-12-19 13:54:27 +0000 874) #if ORTHO_VIEWS
db514a5ded
main/editor/meddraw.c (Bradley Bell 2004-12-19 13:54:27 +0000 875) else if ( screen_canvas == TopViewBox->canvas )
```
When ORTHO_VIEWS is true, this code expands to `} else else if (...)`; a
double-else is not legal, so the code cannot have been compiled with
ORTHO_VIEWS enabled. All 4 of the relevant lines date to db514a5ded
,
which itself is an import of files from the D1X editor.
2020-09-21 03:18:12 +00:00
Kp
cd620e5f8c
Make trigger_dialog inherit from UI_DIALOG
2020-09-21 03:18:12 +00:00
Kp
09966079c4
Make centers_dialog inherit from UI_DIALOG
2020-09-21 03:18:12 +00:00
Kp
b97f581d56
Make hostage_dialog inherit from UI_DIALOG
2020-09-21 03:18:12 +00:00
Kp
5cdd562244
Move UI_DIALOG callback handling to virtual function
2020-09-21 03:18:12 +00:00
Kp
8760387188
Make UI_DIALOG inherit from window
2020-09-21 03:18:12 +00:00
Kp
3c1c270643
Make info_dialog_window inherit from window
2020-09-21 03:18:12 +00:00
Kp
e068c685f4
Make scores_menu inherit from window
2020-09-21 03:18:12 +00:00
Kp
08701ca190
Store kmatrix_result in a uint8_t size enum
2020-09-21 03:18:12 +00:00
Kp
b9f3e8a40a
Remove unused UI_DIALOG fields
2020-09-21 03:18:12 +00:00
Kp
d056daa162
Remove obsolete UI_DIALOG constructor, macros
2020-09-21 03:18:12 +00:00
Kp
a069daae41
Remove unused DF_BORDER
2020-09-21 03:18:12 +00:00
Kp
b3c3066a38
Fix no-joystick build
...
When joystick support is not present, `event_joystick_get_button` is not
declared in joy.h.
Fixes: c24864b180
("make menus controllable with joystick")
2020-09-11 03:08:02 +00:00
Kp
3ee3ac7b7a
Delete multi_do_death
...
It is not needed. Deathmatch players never lose their keys, so there is
no need to reapply them.
2020-09-11 03:08:02 +00:00
Kp
6a9444e5d6
Move some multiplayer functions into namespaces
2020-09-11 03:08:02 +00:00
Kp
61f186bc18
Use enum class for texture1_value
2020-09-11 03:08:02 +00:00
Kp
39cb42b878
Push partial_range construction to newmenu callers
...
In some cases, callers know the length of the range and can apply better
checks than the called code.
2020-09-11 03:08:02 +00:00
Kp
e31d030caf
Use zip for nm_messagebox_str
2020-09-11 03:08:02 +00:00
Kp
7de81a7293
Move Afterburner_charge to dsx
2020-09-11 03:08:02 +00:00
Kp
18282d5b66
Move some menu code into namespaces
2020-09-11 03:08:02 +00:00
Kp
0f2c1cdd45
Make game window inherit from dcx::window
2020-08-28 00:18:45 +00:00
Kp
b79eff0e5c
Deduplicate fades[]
...
Two identical copies were defined in different places. Use the global
one for both consumers.
2020-08-28 00:18:45 +00:00
Kp
955c7d9542
Make console window inherit from dcx::window
2020-08-28 00:18:45 +00:00
Kp
cdca112f0a
Pass LevelUniqueAutomapState to automap_clear_visited
2020-08-28 00:18:45 +00:00
Kp
ef8c0e7527
Make kmatrix window inherit from dcx::window
2020-08-28 00:18:45 +00:00
Kp
1d3e546848
Inline window_get_canvas
...
The helper returns a reference to a mutable canvas, so there is no
isolation provided by using the helper.
2020-08-28 00:18:45 +00:00
Kp
0f89331924
Inline window_set_modal
2020-08-28 00:18:45 +00:00