complete cleanup after rename.

clean up things that were broken after renaming `bg_core` to
`bg_terrain`.

also clean up after global rename that added `bg_` prefix to every mod
name.

mods/bg_api/cleanup.lua

@@ -1,19 +1,20 @@
 -- move from old modnames to new ones. (old ones didn't have the `bg_` prefix.)
-minetest.register_on_mods_loaded(function ()
-	local nodes = minetest.registered_nodes
-	local names = {}
-	for name, _ in pairs(nodes) do
-		table.insert(names, string.sub(name, 4))
-	end
-
-	-- using LBM:s doesn't work for some reason, so this ABM hack thing is used instead.
-	minetest.register_abm({
-		nodenames = names,
-		interval = 10,
-		chance = 1,
-		action = function (pos, node)
-			local name = node.name
-			minetest.set_node(pos, {name = "bg_" .. name})
-		end,
-	})
-end)
+minetest.register_lbm({
+	name = "bg_api:rename_legacy_nodes",
+	nodenames = {
+		"tree:log",
+		"tree:log_alive",
+		"tree:leaves",
+		"tree:leaves_alive",
+		"tree:sapling",
+		"tree:root",
+		"tree:nut",
+		"stoneworking:tile",
+		"stoneworking:bricks",
+	},
+	run_at_every_load = true,
+	action = function (pos, node)
+		local name = node.name
+		minetest.set_node(pos, {name = "bg_" .. name})
+	end,
+})

mods/bg_core/biome.lua

@@ -1,15 +0,0 @@
-local modname = minetest.get_current_modname()
-
-minetest.clear_registered_biomes()
-minetest.register_biome({
-	name = "unknown",
-	node_top = modname .. ":grass",
-	depth_top = 1,
-	node_filler = modname .. ":dirt",
-	depth_filler = 2,
-	node_stone = modname .. ":stone",
-	heat_point = 0,
-	humidity_point = 0,
-	y_min = -31000,
-	y_max = 31000,
-})

mods/bg_core/init.lua

@@ -1,4 +0,0 @@
-local modname = minetest.get_current_modname()
-
-load_file("node")
-load_file("biome")

mods/bg_core/mod.conf

@@ -1,3 +0,0 @@
-name = bg_core
-description = core mod for blockgame.
-depends = bg_api

mods/bg_core/node.lua

@@ -1,36 +0,0 @@
-local modname = minetest.get_current_modname()
-
-blockgame.register_node(modname .. ":stone", {
-	description = "Stone",
-	tiles = {
-		modname .. "_stone.png",
-	},
-	groups = {
-		cracky = 3,
-		stoney = 1,
-	},
-	drop = modname .. ":cobblestone",
-})
-blockgame.reg_simple_node("cobblestone", "Cobblestone", {
-	cracky = 3,
-	stoney = 1,
-})
-
-minetest.register_alias("mapgen_stone", modname .. ":stone")
-minetest.register_alias("mapgen_water_source", "air")
-
-blockgame.register_node(modname .. ":grass", {
-	description = "Grass",
-	tiles = {
-		modname .. "_grass.png",
-	},
-	groups = {
-		cracky = 3,
-		dirty = 1,
-	},
-	drop = modname .. ":dirt",
-})
-blockgame.reg_simple_node("dirt", "Dirt", {
-	cracky = 3,
-	dirty = 1,
-})

mods/bg_crafting/mod.conf

@@ -1,3 +1,3 @@
 name = bg_crafting
 description = crafting mod for blockgame.
-depends = bg_core, bg_api
+depends = bg_terrain, bg_api

mods/bg_funnel/mod.conf

@@ -1,3 +1,3 @@
 name = bg_funnel
 description = adds a funnel node to blockgame.
-depends = bg_core, bg_api, bg_tree, bg_woodworking
+depends = bg_terrain, bg_api, bg_tree, bg_woodworking

mods/bg_grass/mod.conf

@@ -1,3 +1,3 @@
 name = bg_grass
 description = adds grass spreading and related mechanics to blockgame.
-depends = bg_core, bg_api
+depends = bg_terrain, bg_api

mods/bg_player/mod.conf

@@ -1,3 +1,3 @@
 name = bg_player
 description = blockgame player-related stuff.
-depends = bg_core, bg_api
+depends = bg_terrain, bg_api

mods/bg_stoneworking/mod.conf

@@ -1,3 +1,3 @@
 name = bg_stoneworking
 description = blockgame stone related recipes and stuff.
-depends = bg_core, bg_crafting, bg_api
+depends = bg_terrain, bg_crafting, bg_api

mods/bg_terrain/cleanup.lua

@@ -0,0 +1,27 @@
+local function starts_with (str, start)
+	return string.sub(str, 1, string.len(start)) == start
+end
+
+-- rename from bg_core to bg_terrain.
+minetest.register_lbm({
+	name = "bg_terrain:rename_core_mod",
+	nodenames = {
+		"core:stone",
+		"core:cobblestone",
+		"core:dirt",
+		"core:grass",
+		"bg_core:stone",
+		"bg_core:cobblestone",
+		"bg_core:dirt",
+		"bg_core:grass",
+	},
+	run_at_every_load = true,
+	action = function (pos, node)
+		local prefix = ""
+		if starts_with(node.name, "core") then prefix = "core"
+		elseif starts_with(node.name, "bg_core") then prefix = "bg_core" end
+
+		local name = string.sub(node.name, string.len(prefix) + 1)
+		minetest.set_node(pos, {name = "bg_terrain" .. name})
+	end,
+})

mods/bg_terrain/init.lua

@@ -2,3 +2,5 @@ local modname = minetest.get_current_modname()
 
 load_file("node")
 load_file("biome")
+
+load_file("cleanup")

mods/bg_tree/mod.conf

@@ -1,3 +1,3 @@
 name = bg_tree
 description = blockgame tree mod.
-depends = bg_core, bg_crafting, bg_api
+depends = bg_terrain, bg_crafting, bg_api

mods/bg_woodworking/mod.conf

@@ -1,3 +1,3 @@
 name = bg_woodworking
 description = blockgame wood related recipes and stuff.
-depends = bg_core, bg_crafting, bg_api, bg_tree
+depends = bg_terrain, bg_crafting, bg_api, bg_tree