stellarskylark/skylark-qmk
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Update pr_checklist.md (#17122)

Browse source
This commit is contained in:
durken1 2022-05-17 15:20:13 +02:00 committed by GitHub
parent 6560903350
commit dba5b730a3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/pr_checklist.md
View file

@ -62,7 +62,7 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard
- modified `# Enable Bluetooth with the Adafruit EZ-Key HID` -> `# Enable Bluetooth` - modified `# Enable Bluetooth with the Adafruit EZ-Key HID` -> `# Enable Bluetooth`
- no `(-/+size)` comments related to enabling features - no `(-/+size)` comments related to enabling features
- remove the list of alternate bootloaders if one has been specified - remove the list of alternate bootloaders if one has been specified
- no re-definitions of the default MCU parameters if same value, when compared to the equivalent MCU in [mcu_selection.mk](https://github.com/qmk/qmk_firmware/blob/master/quantum/mcu_selection.mk) - no re-definitions of the default MCU parameters if same value, when compared to the equivalent MCU in [mcu_selection.mk](https://github.com/qmk/qmk_firmware/blob/master/builddefs/mcu_selection.mk)
- keyboard `config.h` - keyboard `config.h`
- don't repeat `MANUFACTURER` in the `PRODUCT` value - don't repeat `MANUFACTURER` in the `PRODUCT` value
- no `#define DESCRIPTION` - no `#define DESCRIPTION`