From d06bec9cd9b0c3dfbe8d89b304ecc3aaa0821f4d Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Sun, 13 Dec 2020 15:44:48 -0700 Subject: [PATCH 1/2] Update Profile, fix follower counter bug --- app/Profile.php | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/app/Profile.php b/app/Profile.php index 5b854dfcc..fb3540514 100644 --- a/app/Profile.php +++ b/app/Profile.php @@ -65,13 +65,11 @@ class Profile extends Model public function followingCount($short = false) { $count = Cache::remember('profile:following_count:'.$this->id, now()->addMonths(1), function() { - $count = $this->following_count; - if($count) { - return $count; - } $count = $this->following()->count(); - $this->following_count = $count; - $this->save(); + if($this->following_count != $count) { + $this->following_count = $count; + $this->save(); + } return $count; }); @@ -81,13 +79,11 @@ class Profile extends Model public function followerCount($short = false) { $count = Cache::remember('profile:follower_count:'.$this->id, now()->addMonths(1), function() { - $count = $this->followers_count; - if($count) { - return $count; - } $count = $this->followers()->count(); - $this->followers_count = $count; - $this->save(); + if($this->followers_count != $count) { + $this->followers_count = $count; + $this->save(); + } return $count; }); return $short ? PrettyNumber::convert($count) : $count; From 6d030cdf8123622b9dc5ef78e6cc487ecbe41405 Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Sun, 13 Dec 2020 15:45:20 -0700 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index dd281e3b6..bac195797 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -131,6 +131,7 @@ - Updated Profile model, improve counter caching. ([4a14e970](https://github.com/pixelfed/pixelfed/commit/4a14e970)) - Updated ComposeModal, fix filter bug on safari. ([8e3e7586](https://github.com/pixelfed/pixelfed/commit/8e3e7586)) - Updated StatusStatelessController, remove unused attributes. ([d0d46807](https://github.com/pixelfed/pixelfed/commit/d0d46807)) +- Updated Profile, fix follower counter bug. ([d06bec9c](https://github.com/pixelfed/pixelfed/commit/d06bec9c)) ## [v0.10.9 (2020-04-17)](https://github.com/pixelfed/pixelfed/compare/v0.10.8...v0.10.9) ### Added