spacemacs/layers/+spacemacs/spacemacs-defaults
Miciah Masters 7852c3b36e Delete compilation finish hook
Before this commit, Spacemacs assigned an anonymous function to the
compilation-finish-function variable.  This variable was deprecated
in Emacs 22.1 and removed in Emacs 27.1 in favor of the
compilation-finish-functions hook.  Consequently, the assignment has
no practical effect in Emacs 27.1.

Although we could add the Spacemacs function to the new
compilation-finish-functions hook, the function serves little purpose; it
prints a generic message when compilation succeeds:

    compilation ok.

and it prints the key binding for spacemacs/next-error when compilation
fails:

    There were errors. Use SPC e n to visit.

However Emacs already prints messages to indicate success or failure,
respectively:

    Compilation finished

or (for example)

    Compilation exited abnormally with code 1

Because the Spacemacs function prints its "There were errors" message
immediately after Emacs prints its "Compilation exited abnormally" message,
the latter was obscured.  Because the exit code in Emacs's message could be
useful and the added value of the Spacemacs function's message is minimal,
we can simply delete the Spacemacs function.

* layers/+spacemacs/spacemacs-defaults/funcs.el
(compilation-finish-function): Delete the assignment and anonymous
function.
2018-09-03 21:29:53 +01:00
..
local/help-fns+ reorganize spacemacs-base distribution into +spacemacs/spacemacs-xxx 2018-03-04 20:54:54 -05:00
README.org Fix typos 2018-06-14 00:15:49 -04:00
config.el reorganize spacemacs-base distribution into +spacemacs/spacemacs-xxx 2018-03-04 20:54:54 -05:00
funcs.el Delete compilation finish hook 2018-09-03 21:29:53 +01:00
keybindings.el Fixes keybinding conflict with `fasd` layer 2018-08-30 00:13:43 +03:00
packages.el Work around ido-mode remapping Spacemacs keys 2018-08-01 22:46:40 -04:00

README.org

spacemacs-defaults

Description

This layer configures mostly Emacs built-in packages to given them better defaults.

Features:

  • Configures packages:

    • abbrev
    • archive-mode
    • bookmark
    • conf-mode
    • dired
    • dired-x
    • display-line-numbers (only in Emacs 26.x and newer)
    • electric-indent-mode
    • ediff
    • eldoc
    • help-fns+
    • hi-lock
    • image-mode
    • imenu
    • linum (only in Emacs 25.x and older)
    • occur-mode
    • package-menu
    • page-break-lines
    • process-menu
    • recentf
    • savehist
    • saveplace
    • subword
    • tar-mode
    • uniquify
    • url
    • visual-line-mode
    • whitespace
    • winner
    • zone