a55df96caa
Fix several problems with environment variable caching. First, if a shell printed extra output besides the command output, spacemacs//init-spacemacs-env included the extra output in .spacemacs.env. For example, a login shell could print a motd, which would be erroneously included in .spacemacs.env. To avoid this, spacemacs//init-spacemacs-env now redirects the command output to a temporary file and then reads the file. Second, spacemacs//init-spacemacs-env sorted lines using the entire "name=value" string for each line whereas the correct behavior is to sort only on the "name" part. To fix this, spacemacs//init-spacemacs-env now uses sort-regexp-fields with an appropriate regexp to match the "name" part and ignore the "value" part. Third, although load-env-vars-set-env added all PATH settings in .spacemacs.env to exec-path, it set PATH to the first PATH setting in .spacemacs.env. Now load-env-vars-set-env sets PATH from exec-path so that it will reflect that combined value. Fourth, load-env-vars-set-env set exec-path and PATH without consideration to the operating system's directory separator. Now load-env-vars-set-env converts backslashes to forward slashes when adding path entries to exec-path and converts forward slashes to backslashes when setting PATH on platforms that use backslashes. Fifth, load-env-vars-set-env now normalizes exec-path by deleting trailing slashes from path entries, converting drive letters in path entries to lower-case, and deleting duplicate path entries. Sixth, Spacemacs no longer uses exec-path-from-shell, but a changelog entry said that it did. This commit corrects the changelog entry, deletes another outdated entry, and merges two entries that covered the same functionality. Finally, this commit corrects several typos and tries to improve wording in several docstrings, messages, and comments. * CHANGELOG.develop: Delete mention of exec-path-from-shell, which Spacemacs no longer uses by default. Delete mention of dotspacemacs-import-env-vars-from-shell and dotspacemacs-import-env-vars-shell-file-name, which no longer exist. Merge entries about synchronizing environment variables. * core/core-env.el (spacemacs-ignored-environment-variables): Fix typos and mention that the strings are regexps that are matched against the names of environment variables. (spacemacs//init-spacemacs-env): Use a temporary file rather than standard output in order to avoid getting motd and other noise. Sort lines using only environment variables' names, not their values. Better describe the behavior with respect to spacemacs-ignored-environment-variables, duplicate settings, and PATH. Try to make wording clearer. (spacemacs/edit-env): Fix typos in the docstring. * core/libs/load-env-vars.el (load-env-vars-set-env): Fix typos in the docstring. Delete trailing slashes from path entries in exec-path, convert drive letters to lower-case, delete duplicate path entries, and convert backslashes to forward slashes when setting exec-path. Set PATH from exec-path, converting forward slashes to backslashes on platforms that use backslashes. |
||
|---|---|---|
| .. | ||
| aprilfool | ||
| banners | ||
| gnupg | ||
| info | ||
| libs | ||
| templates | ||
| core-command-line.el | ||
| core-configuration-layer.el | ||
| core-custom-settings.el | ||
| core-debug.el | ||
| core-display-init.el | ||
| core-documentation.el | ||
| core-dotspacemacs.el | ||
| core-dumper.el | ||
| core-emacs-backports.el | ||
| core-env.el | ||
| core-fonts-support.el | ||
| core-funcs.el | ||
| core-hooks.el | ||
| core-jump.el | ||
| core-keybindings.el | ||
| core-load-paths.el | ||
| core-micro-state.el | ||
| core-progress-bar.el | ||
| core-release-management.el | ||
| core-spacemacs-buffer.el | ||
| core-spacemacs.el | ||
| core-themes-support.el | ||
| core-toggle.el | ||
| core-transient-state.el | ||
| core-use-package-ext.el | ||
| core-versions.el | ||