7852c3b36e
Before this commit, Spacemacs assigned an anonymous function to the
compilation-finish-function variable. This variable was deprecated
in Emacs 22.1 and removed in Emacs 27.1 in favor of the
compilation-finish-functions hook. Consequently, the assignment has
no practical effect in Emacs 27.1.
Although we could add the Spacemacs function to the new
compilation-finish-functions hook, the function serves little purpose; it
prints a generic message when compilation succeeds:
compilation ok.
and it prints the key binding for spacemacs/next-error when compilation
fails:
There were errors. Use SPC e n to visit.
However Emacs already prints messages to indicate success or failure,
respectively:
Compilation finished
or (for example)
Compilation exited abnormally with code 1
Because the Spacemacs function prints its "There were errors" message
immediately after Emacs prints its "Compilation exited abnormally" message,
the latter was obscured. Because the exit code in Emacs's message could be
useful and the added value of the Spacemacs function's message is minimal,
we can simply delete the Spacemacs function.
* layers/+spacemacs/spacemacs-defaults/funcs.el
(compilation-finish-function): Delete the assignment and anonymous
function.
|
||
|---|---|---|
| .. | ||
| spacemacs-completion | ||
| spacemacs-defaults | ||
| spacemacs-editing | ||
| spacemacs-editing-visual | ||
| spacemacs-evil | ||
| spacemacs-language | ||
| spacemacs-layouts | ||
| spacemacs-misc | ||
| spacemacs-modeline | ||
| spacemacs-navigation | ||
| spacemacs-org | ||
| spacemacs-project | ||
| spacemacs-purpose | ||
| spacemacs-visual | ||