This repository has been archived on 2024-10-22. You can view files and clone it, but cannot push or open issues or pull requests.
spacemacs/layers/+spacemacs/spacemacs-editing/funcs.el
Miciah def07cbfa3 Fix smart-closing-parenthesis extra parenthesis
Fix issue #9477: spacemacs/smart-closing-parenthesis sometimes adds an
extra closing parenthesis.

spacemacs/smart-closing-parenthesis may call sp-up-sexp twice: first to
find the position of an existing closing delimiter or the position at which
one would be inserted, and second to insert a delimiter if necessary or
else move point after the existing closing delimiter.

The problem is that each call to sp-up-sexp may insert a delimiter, but
spacemacs/smart-closing-parenthesis is supposed to insert at most one.

The solution is to undo any edit performed by the first call to sp-up-sexp.

* layers/+spacemacs/spacemacs-editing/funcs.el: Undo any edit performed by
the first call to sp-up-sexp.
2018-08-04 10:48:00 -04:00

94 lines
2.9 KiB
EmacsLisp
Raw Blame History

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

;;; funcs.el --- Spacemacs editing Layer functions File
;;
;; Copyright (c) 2012-2018 Sylvain Benner & Contributors
;;
;; Author: Sylvain Benner <sylvain.benner@gmail.com>
;; URL: https://github.com/syl20bnr/spacemacs
;;
;; This file is not part of GNU Emacs.
;;
;;; License: GPLv3
;; smartparens
(defun spacemacs/smartparens-pair-newline (id action context)
(save-excursion
(newline)
(indent-according-to-mode)))
(defun spacemacs/smartparens-pair-newline-and-indent (id action context)
(spacemacs/smartparens-pair-newline id action context)
(indent-according-to-mode))
(defun spacemacs/smart-closing-parenthesis ()
"Insert a closing pair delimiter or move point past existing delimiter.
If the expression at point is already balanced and there is a
closing delimiter for that expression on the current line, move
point forward past the closing delimiter.
If the expression is balanced but there is no closing delimiter
on the current line, insert a literal ')' character.
If the expression is not balanced, insert a closing delimiter for
the current expression.
This command uses Smartparens navigation commands and therefore
recognizes pair delimiters that have been defined using `sp-pair'
or `sp-local-pair'."
(interactive)
(let* ((sp-navigate-close-if-unbalanced t)
(current-pos (point))
(current-line (line-number-at-pos current-pos))
next-pos next-line)
(save-excursion
(let ((buffer-undo-list)
(modified (buffer-modified-p)))
(unwind-protect
(progn
(sp-up-sexp)
(setq next-pos (point)
next-line (line-number-at-pos)))
(primitive-undo (length buffer-undo-list)
buffer-undo-list)
(set-buffer-modified-p modified))))
(cond
((and (= current-line next-line)
(not (= current-pos next-pos)))
(sp-up-sexp))
(t
(insert-char ?\))))))
(defun spacemacs//conditionally-enable-smartparens-mode ()
"Enable `smartparens-mode' in the minibuffer, during `eval-expression'."
(if (eq this-command 'eval-expression)
(smartparens-mode)))
(defun spacemacs//adaptive-smartparent-pair-overlay-face ()
(set-face-attribute 'sp-pair-overlay-face nil
:inherit 'lazy-highlight
:background nil
:foreground nil))
;; uuidgen
;; TODO spacemacs/uuidgen-3 and spacemacs/uuidgen-5
(defun spacemacs/uuidgen-1 (arg)
"Return a time based UUID (UUIDv1).
If ARG is non nil then use CID format."
(interactive "P")
(let ((uuid (uuidgen-1)))
(if arg
(insert-uuid-cid uuid)
(insert uuid))))
(defun spacemacs/uuidgen-4 (arg)
"Return an UUID from random numbers (UUIDv4).
If ARG is non nil then use CID format."
(interactive "P")
(let ((uuid (uuidgen-4)))
(if arg
(insert-uuid-cid uuid)
(insert uuid))))