Commit graph

103 commits

Author SHA1 Message Date
Lucius Hu
652de66ab2 ruby: refactor
- Moved backend determination to `config.el`
- Replaced unnecessary backquote construct with simple quotation
- Replaced `pcase` form with only one-arm with `when` or `unless` form
2021-04-04 12:48:21 +02:00
syl20bnr
97cd83e169 Apply GPLv3 terms explicitly to all elisp files 2021-03-25 22:59:32 -04:00
syl20bnr
d55a9e2e67 Update header for year 2021 2021-03-25 22:59:32 -04:00
Sid Raval
9b6a49d6c0
Support prettier formatter for Ruby layer (#14252)
* First working pass

- Runs prettier on save when in ruby-mode.
- Adds `node_modules/.bin/` to local `exec-path`
  - This means project-local `prettier` executables are preferred

* Making ruby layer prettier formatting configurable

- Adds a variable to control whether prettier is used to format-on-save.
- Documents use, configuration, and keybindings in the README

* Add to CHANGELOG.develop

* Delete spurious comment

* Use prettier as a dependency only when config variable is present
2021-01-09 08:34:04 +01:00
Codruț Constantin Gușoi
b3bbbd229d Update changelog with most important changes 2020-07-17 21:02:28 +01:00
Codruț Constantin Gușoi
698a981e8c Adds text insertion functinos and keys 2020-07-17 21:02:28 +01:00
Codruț Constantin Gușoi
69078f8d9b Disable the magic comment insertion by default 2020-07-17 21:02:28 +01:00
Codruț Constantin Gușoi
f4f9f74075 Use refactor prefix for the quote and block toggles 2020-07-17 21:02:28 +01:00
Codruț Constantin Gușoi
ecb06efbb4 Fix ruby mode handling for special files 2020-07-17 21:02:28 +01:00
Maximilian Wolff
b82bc40b3c
Fix ignored popwin declarations
Popwin automatically configures pupo purposes
if properly configured. While I was checking
the existing configs I have found that the
settings will be ignored if the config is not
done via a post-config hook.

A quick search revealed a lot of popwin configs
which never had any effect.

This commit fixes these and with this also
restores the missing pupo configs.
2020-07-03 21:51:33 +02:00
Maximilian Wolff
1fd90fc1dc
Update instructions for dap integration and update existing layers
The previous way of adding dap to a layer did add the mode
unconditionally to `spacemacs--dap-supported-modes` causing
dap bindings to be added also when no lsp backend was used.
2020-05-16 23:40:38 +02:00
Maximilian Wolff
0c774416d7
Make ruby layer load dap layer when lsp is used as backend
Before the ruby layer was only requiring standalone lsp layer,
however with the latest changes dap support has been added
therefore I have updated the layer file to require the full
dap layer instead which in turn requires the lsp layer.
2019-12-21 23:51:13 +01:00
Seong Yong-ju
82d4df4b0f
Fix key bindings in Ruby layer 2019-12-21 23:36:36 +01:00
syl20bnr
9606dd344e [dap] Refactor configuration dap config in layers
* use local-vars-hook coupled to setup function for dap
* define new private layer variable `spacemacs--dap-supported-modes` to
  configure key bindings. This allows to move the key bindings definition from
  `funcs.el` to `packages.el`
* remove duplication of DAP key bindings in READMEs by pointing to the dap layer
  documentation
* alphabetically sort package configuration
2019-09-30 00:34:26 -04:00
Michael Franz Aigner
ddf7459a02 Fix lazy-loading of ruby-test-mode
This change fixes a syntax mistake in the use-package declaration of
ruby-test-mode that causes the package to be loaded immediately, instead of
deferring the load until the first ruby file is visited, as is intended.
2019-06-12 19:37:26 +02:00
Seong Yong-ju
80ff9053a3 Add rubocopfmt to format Ruby buffers 2019-05-31 16:58:57 +02:00
Billy Kaplan
5a0ab04653 Adding Ruby LSP Backend and DAP support 2019-05-27 22:09:31 +02:00
Seong Yong-ju
de346e33c6 Fix issues in ruby layer
Add a prefix for rake and refactor/RuboCop/robe commands. Add test and toggle
prefix for enh-ruby-mode. Use enh-ruby-toggle-block in enh-ruby-mode, instead of
ruby-toggle-block. Remove the prefix in prefixes "ruby/".
2018-09-03 20:17:30 +01:00
Brandon Conway
6302748f99 Add seeing is believing 2018-08-11 12:53:50 +03:00
p-sdk
e090ffbd2d ruby: add popwin config for bundler, projectile-rails and rubocop 2018-07-10 00:36:10 +03:00
Codruț Constantin Gușoi
05f27afa56 Creates a toggle prefix for ruby 2018-07-09 23:50:41 +03:00
Codruț Constantin Gușoi
f715c1f12e Revert "Remove duplicate robe keybinding"
This reverts commit 7d63001515.
2018-07-09 23:48:05 +03:00
Codruț Constantin Gușoi
7d63001515 Remove duplicate robe keybinding
Robe had 2 keybindings for starting a server: `SPC m ,` and `SPC m s s`
but the first one was already defined for another purpose so it overwrote
it.
2018-07-09 23:43:17 +03:00
Miciah Masters
e0b751bee3 Avoid non-idempotent use of push in init code
Replace push with add-to-list in layer init functions and related code.

Modify spacemacs|add-toggle to check for and update an existing toggle in
spacemacs-toggles and only create a new toggle if none already existed.

Replace a conditional push onto erc-packages with use of :toggle.

When initializing which-key, set which-key-replacement-alist to its default
or customized setting before adding all the Spacemacs replacements.  We
want to keep the stock replacements but avoid adding duplicates of the
Spacemacs replacements.

Replace the emacs-lisp-mode-hook lambda with a named function to avoid
adding duplicate hooks (which can add duplicate definitions of the
evil-surround pair).
2018-06-05 22:17:13 -04:00
p-sdk
4e3990ce52 ruby: add key bindings for ruby-send-{buffer,line}-and-go 2018-05-31 01:09:50 +03:00
p-sdk
000e5022c9 ruby: add key binding for ruby-send-line 2018-05-20 00:01:29 -04:00
syl20bnr
ebe4c60264 Revert "Defer packages by default using use-package-always-defer"
This reverts commit 29c78ce841 and all other fixes
that have been made afterwards.

The motivation is that use-package is seen by many as a replacement for
`require`. Is use-package always defer the loading of packages then is breaks
this use case, this does not respect POLA so even if it was making Spacemacs
loading faster (up to 3s faster on some startup on my machine) we just cannot
use it, it would be irresponsible. Spacemacs should be easy to use, loading
performance will come with time but it is not a priority.
2018-03-03 23:40:10 -05:00
syl20bnr
29c78ce841 Defer packages by default using use-package-always-defer
Warning now `:defer t` is implied, to force a package to load `:demand t` is
now necessary.
2018-02-27 23:32:52 -05:00
Alejandro Arrufat
f93fb228ce Feature: Add "send to buffer" leader key in ruby layer
Currently ruby-send-to-buffer function is not assigned to any key
it is useful to be able to send the the buffer directly to the ruby
console.

It assigns SPC-msb to ruby-send-to-buffer function
2018-02-24 19:49:39 -05:00
David Balatero
2b3d83ccf6 Add gtags to enh-ruby-mode as well as ruby-mode 2018-01-22 23:14:40 -05:00
Paul
03f79d0aa6 ruby: add ruby-hash-syntax
Add a command to toggle between old and new hash syntax in the active region.
2018-01-18 00:15:16 -05:00
syl20bnr
41e546f040 Move all use-package hook declaration to pre-init functions
Had to create dummy init functions at some places since the owner of a package
is the last layer that defines the init function of a package. And a package
can be installed only if it has an owner.
2018-01-10 23:57:18 -05:00
syl20bnr
326965d4ce Happy New Year 2018! 2018-01-04 02:00:25 -05:00
Robbert van der Helm
c61ae1a1c1 Add ivy support to the gtags layer
It would be much better to have a single function for each layer that
initializes ggtags, helm-gtags and counsel-gtags for a mode.
2017-12-17 22:03:01 -05:00
Paul
4b347759b9 ruby: change documentation lookup key binding
`SPC m h h` is conventional key binding to show documentation for thing under
point. It is called by `spacemacs/evil-smart-doc-lookup`, so this change makes
`K` in normal state work as expected.
2017-07-06 12:30:11 +02:00
syl20bnr
e2e532bb49 core: change <function>p to <function>-p suffixes for consistency
Also defined aliases for backward compatibility with `usedp` functions.
2017-07-02 10:09:39 -04:00
Daniel Luna
34d842c6f5 [ruby-layer] Adding ruby-refactor package and associated keybindings
This commit adds a series of refactoring commands for Ruby under
"ruby/refactor", by use of the `ruby-refactor` package.
2017-05-24 14:41:55 +02:00
Eivind Fonn
b1f1674109 Ruby debug highlighting: dynamic check
Move check into function, and add to local-vars hook instead of the mode hook.
This makes the variable changeable at runtime and also as part of local vars.
2017-05-24 09:43:06 +02:00
Alexander Berezovsky
26bb5912f0 Highlight ruby debugger keywords 2017-05-24 09:42:47 +02:00
Muneeb Shaikh
50f5a04f9a ruby: add to org-babel-load-languages 2017-04-28 23:04:13 -04:00
syl20bnr
f45ce1a88e syntax-checking: rename function add-flycheck-hook to enable-flycheck
spacemacs/add-flycheck-hook was not really hooking anything, change the name
to better reflect what it does.
Also changed the push for a add-to-list to avoid duplicates.
2017-03-19 12:40:36 -04:00
syl20bnr
fb27ede558 Bump year in copyright headers
Happy New Year 2017!
2017-01-05 23:08:17 -05:00
syl20bnr
74fdbb6795 Refactor and simplify company backends declaration
Enabling a company backend for a specific mode was a tedious tasks with code
scattered at different locations, one for local variable definitions, one for
company hook function definitions and another where the backends were pushed to
the local variables (which was problematic, since we ended up pushing the same
backends over and over again with `SPC f e R`, pushes have been replaced by
add-to-list calls in the new macro).

All these steps are now put together at one place with the new macro
spacemacs|add-company-backends, check its docstring for more info on its
arguments.

This macro also allows to define arbitrary buffer local variables to tune
company for specific modes (similar to layer variables via a keyword :variables)

The code related to company backends management has been moved to the
auto-completion layer in the funcs.el file. A nice side effect of this move is
that it enforces correct encapsulation of company backends related code. We can
now easily detect if there is some configuration leakage when the
auto-completion layer is not used. But we loose macro expansion at file loading
time (not sue it is a big concern though).

The function spacemacs|enable-auto-complete was never used so it has been
deleted which led to the deletion of the now empty file core-auto-completion.el.

The example in LAYERS.org regarding auto-completion is now out of date and has
been deleted. An example to setup auto-completion is provided in the README.org
file of the auto-completion layer.
2017-01-02 00:39:04 -05:00
Pawan Dubey
f592beda02
Add Minitest support to Ruby Layer
Added support for Minitest to the Ruby layer with the
minitest-mode package. Defined appropriate keybindings.

Fixes syl20bnr/spacemacs#6969
2016-10-11 22:18:22 +03:00
syl20bnr
9066d073b2 Fix (void-variable spacemacs-jump-handlers-....)
Move the variable definitions to config.el and eval-after-load the
key binding on SPC m g g.
2016-09-04 22:31:47 -04:00
Eivind Fonn
5a869764dd Further improve gtags layer
- Add option to disable by default
- Use local-vars hook to allow per-project enable/disable
- Don’t enable helm-gtags-mode (no need)
- Move emacs bindings from helm-gtags-mode-map to ggtags-mode-map
2016-08-22 15:11:25 +02:00
Eivind Fonn
928983da47 Refactor jump to definition
This commit defines:

- spacemacs-default-jump-handlers: a list of functions that can jump to
  definition in ALL modes.

- spacemacs-jump-handlers-MODE: a list of functions that can jump to
  definition in MODE.

- spacemacs-jump-handlers: a buffer-local list of functions that can
  jump to definition. This is made up of the values of the two previous
  variables whenever a given major mode is activated.

- spacemacs/jump-to-definition: a function that tries each function in
  spacemacs-jump-handlers in order, and stops when one of them takes us
  somewhere new.

- spacemacs|define-jump-handlers: a macro that
  * defines spacemacs-jump-handlers-MODE, possibly filled with initial
    functions
  * defines a function that is added to the hook of the given MODE
  * binds “SPC m g g” of that MODE to spacemacs/jump-to-definition

This is an attempt to harmonize all the different approaches to jumping.
Specifically,

- Existing intelligent jump packages that work for only a single mode
  should go to the beginning of spacemacs-jump-handlers-MODE. E.g.
  anaconda for python, ensime for scala, etc.

- Packages like gtags that work for several modes (but potentially not
  all) and which is dumber than the intelligent jumpers should go the
  the END of spacemacs-jump-handlers-MODE.

- Packages like dumb-jump that work for all modes should go to
  spacemacs-default-jump-handlers.

In all cases the order of the jump handlers in each list should be from
most to least intelligent.

Fixes #6619
2016-08-22 15:08:25 +02:00
Christian E. Hopps
b22702bc9e Expand gtags use to many more languages 2016-07-17 17:31:59 +02:00
syl20bnr
89dc1af9a6 Remove spacemacs/add-to-local-vars-hook and use (format ...)
It is better to directly hook function using the conventional hook
functions.

Replace usage of (concat ...) by a (format ...) from which is more
readable.
2016-06-26 14:04:13 -04:00
d12frosted
a8b0eaacec fix support of conditional config in ruby layer 2016-06-26 13:51:12 -04:00