This commit drastically simplify the previous commit by removing
the layer variable syntax-checking-check-on-buffer-change and
the associated usage of it.
This effectively make spacemacs use the default flycheck setting.
If the user wants to customize this behavior then she can modify
directly the flycheck variable.
Add a variable `syntax-checking-check-on-buffer-change` to the
`syntax-checking` layer which conditionally sets the variable
`flycheck-check-syntax-automatically` to:
- `'(save mode-enabled)` when nil
- `'(save idle-change new-line mode-enabled)` (the package default)
when non-nil
The various settings determine when Flycheck evaluates the buffer:
- `save` triggers a buffer check after buffer save.
- `mode-enabled` triggers a buffer check when `flycheck-mode` is
enabled.
- `idle-change` triggers a buffer check after the editor has been idle
for `flycheck-idle-change-delay`
- `new-line` triggers a buffer check whenever a new line is inserted
into the buffer
Otherwise the window displayed by Helm i.e. help windows in by executing
persistent action in helm-M-x or helm-descbinds are messed up.
This change also preserves the fix introduced by #2081 for helm-resume.
Which works with helm as well so we don't need to set it to
magit-ido-completing-read (triggers a warning of magit about
a required third-party we don't need).
Works with magit-next for now.
Tests to update and evilify functions robustness need to be improved.
Does not work 100% with magit-mode-map because it is created with
`make-keymap` and not `make-sparse-keymap` and `map-keymap` does not
seem to work with `make-keymap`.
Set git-use-magit-next to t in the layer variable to use it.
For now magit-ghpull from github layer is disabled.
A LOT of issues with next magit and evil remain to be fixed
Currently, pressing TAB does not move to next widget. Similarly,
pressing RET does not run the button at point. Use `kbd` function to
properly convert to internal key representation in Emacs that is usable
in both GUI and terminal.
Also move the key bindings to spacemacs/keybindings.el since it's a more
suitable place.
Since we can use helm-gtags to jump to any valid symbol on
shell/compilation buffer. For example, if a test case fails and it
outputs a function where the failure occurs, we can move point on that
failed function and jump directly to it.
- Use =L= instead of =l= for ~cider-inspector-pop~.
- Add `cider-inspect` key-binding mention in README
- Add key-binding for `cider-debug-defun-at-point`
Bindings are technically for lisp-mode and scheme-mode rather than
slime-mode since evil-leader/set-key-for-mode doesn't seem to work
with minor modes.
