Commit graph

85 commits

Author SHA1 Message Date
Miciah Masters
e0b751bee3 Avoid non-idempotent use of push in init code
Replace push with add-to-list in layer init functions and related code.

Modify spacemacs|add-toggle to check for and update an existing toggle in
spacemacs-toggles and only create a new toggle if none already existed.

Replace a conditional push onto erc-packages with use of :toggle.

When initializing which-key, set which-key-replacement-alist to its default
or customized setting before adding all the Spacemacs replacements.  We
want to keep the stock replacements but avoid adding duplicates of the
Spacemacs replacements.

Replace the emacs-lisp-mode-hook lambda with a named function to avoid
adding duplicate hooks (which can add duplicate definitions of the
evil-surround pair).
2018-06-05 22:17:13 -04:00
Codruț Constantin Gușoi
3873ed52fe Revert back to in documentation 2018-06-02 16:37:56 +03:00
Adam Sokolnicki
a80f4f6aa4 Move projectile-rails keybindings under the web framework key SPC m f
Closes #7424
2018-06-02 16:26:35 +03:00
Adam Sokolnicki
eda1fd1da5 Set leader keys for projectile-rails minor mode instead of ruby's major mode 2018-06-02 16:26:35 +03:00
Aaron Jensen
95a40af341 Revert "Move yas-activate-extra-mode setup to javascript layer" (#10746)
This reverts commit e4eca01e82.
2018-06-01 20:34:48 -04:00
Miciah Dashiel Butler Masters
78297be625 Fix various typos
* Fix various isolated typos

"apppend" -> "append"

"availabe" -> "available"

"Descripti using ternon" -> "Description"

"you have not them" -> "you don't have them"

"new on" -> "new one"

"plained" -> "curved"

"repel" -> "REPL"

"vairable" -> "variable"

* Fix a few errors in the CoffeeScript layer readme

Add a missing "the".

Correct a reference to the layer as "javascript" to "coffeescript".

Fix the syntax on the link to CoffeeLint.

* Fix typos: "dofile" -> "dotfile"

* Fix typos: "formated" and "formating"

"formated" -> "formatted"

"formating" -> "formatting"

* hy: Fix docstrings in funcs.el

Fix copy-and-pasted docstring text for
spacemacs/hy-shell-eval-current-form-and-go and
spacemacs/hy-shell-eval-region-and-go.

* Fix typos: "indendation" -> "indentation"

* Fix typos: "the the", "a a"

Fix duplicated (or misplaced) articles.

* Fix typos: "wether" -> "whether"

* Fix typos: "intialize" -> "initialize"
2018-05-23 22:12:30 -04:00
syl20bnr
8267b501dd web-beautify: rename spacemacs-web-beautify--modes 2018-05-20 00:41:17 -04:00
syl20bnr
b97ad90c92 web-beautify: fix definition of web-beautify key bindings
Needs to use `pre-init` function in order to have the variable
spacemacs-web-beautify--modes to be populated before the init function of
web-beautify is actually called.
2018-05-19 01:53:33 -04:00
syl20bnr
30e366fd40 react: add spacemacs prefix to functions in funcs.el 2018-05-19 01:16:18 -04:00
syl20bnr
8fd934c209 react: set emmet-expand-jsx-className? to t 2018-05-19 01:15:04 -04:00
syl20bnr
5f75e617a3 Fix documentation formating 2018-05-18 01:58:00 -04:00
syl20bnr
542ada133d New layer web-beautify extracted from javascript layer
Make html, javascript, json and react layers depend on it
2018-05-18 01:25:29 -04:00
syl20bnr
101a55e0ff react: make react layer depend on node layer 2018-05-18 01:25:29 -04:00
syl20bnr
e2a1224f64 react: remove unused function spacemacs//setup-rjsx-mode 2018-05-18 01:25:29 -04:00
syl20bnr
e4eca01e82 Move yas-activate-extra-mode setup to javascript layer 2018-05-18 01:25:29 -04:00
syl20bnr
c15b65435e react: make react layer depends on new tern layer 2018-05-18 01:25:29 -04:00
Ting Zhou
8616f07b86 Add: use rjsx-mode for react framework
Fix: add yas-activate-extra-mode
Add: add lsp support for react layer
Add: Add rjsx-mode key-bindings doc
Clean: rename spacemacs//set-lsp-key-bindings to spacemacs//setup-lsp-jump-handler
Fix: remove buggy hooks
Clean: move fix-lsp-company-prefix to lsp layer
Fix: rjsx-mode company
Fix: rjsx-mode lsp backend
2018-05-18 01:25:29 -04:00
syl20bnr
ebe4c60264 Revert "Defer packages by default using use-package-always-defer"
This reverts commit 29c78ce841 and all other fixes
that have been made afterwards.

The motivation is that use-package is seen by many as a replacement for
`require`. Is use-package always defer the loading of packages then is breaks
this use case, this does not respect POLA so even if it was making Spacemacs
loading faster (up to 3s faster on some startup on my machine) we just cannot
use it, it would be irresponsible. Spacemacs should be easy to use, loading
performance will come with time but it is not a priority.
2018-03-03 23:40:10 -05:00
syl20bnr
29c78ce841 Defer packages by default using use-package-always-defer
Warning now `:defer t` is implied, to force a package to load `:demand t` is
now necessary.
2018-02-27 23:32:52 -05:00
smile13241324
3586495ed6 Fix doc for django, scala, sml, floobits, puppet and evernote layer 2018-01-28 23:00:32 -05:00
Cheng,Rong
293b98151a Make auto-completion triggers more friendly in "react" layer
Auto completion menu triggers too frequently in react-mode, for example, the
completion menu will pop up right after user finishes typing a javascript
statement.

The root cause is that the 'company-minimum-prefix-length variable has been set
to 0 in "html" layer, which is used by "react" layer.

Overriding this variable to 2, as defined in "auto-completion" layer, will
resolve this issue.
2018-01-17 23:46:54 -05:00
syl20bnr
326965d4ce Happy New Year 2018! 2018-01-04 02:00:25 -05:00
Benjamin Reynolds
9341e1d751 Fix documentation issues with ruby, rails, and swift layers
See #9476
2017-09-11 22:35:46 +03:00
J. Patrick Lanigan
df7af0ad20 Fix features format in misc README.org's
See #9346
2017-08-22 21:27:13 +03:00
JAremko
06301b2212 Improve exporting/testing 2017-08-18 20:50:21 +03:00
d12frosted
fc978543ca
[ror] add key binding to find serializer
Fixes #9239
2017-08-08 19:11:41 +03:00
Jam Risser
bff4cf5857 Use JSX header without breaking React
Using the header below is now deprecated in React.
```js
/** @jsx React.DOM */
```

However, there are situations where I have to use the *.js extension, and need to tell my text editor that the file has JSX.

I suggest switching to JSX mode if it detects a header starting with `@jsx`. Then I'll be able to do the following without breaking react.

```js
/** @jsx */
2017-07-06 14:36:15 +02:00
jupl
09ce56df3d Use add-node-modules-path to automatically find local executables 2017-06-07 16:49:11 +02:00
panjan
12f823ba3c react: improved react file recognition 2017-05-30 10:27:07 +02:00
JAremko
6c5a0b2b14 update docs to the new toc-org format 2017-05-22 18:35:37 +03:00
BorisVerk
ac81e671e8 added names to django mode prefixes 2017-05-18 18:54:38 +02:00
syl20bnr
cf2b967b3b react: respect 80 chars per line in README 2017-05-14 22:20:00 -04:00
Evan Niessen-Derry
e6048e0863 Add an example for non-standard node bin locations
If you install your node bins in places outside of the system path, you
need to add those locations to the exec path before packages are loaded
or else spacemacs won't recognize them as existing when it initializes
the layers.
2017-05-14 22:18:43 -04:00
syl20bnr
f45ce1a88e syntax-checking: rename function add-flycheck-hook to enable-flycheck
spacemacs/add-flycheck-hook was not really hooking anything, change the name
to better reflect what it does.
Also changed the push for a add-to-list to avoid duplicates.
2017-03-19 12:40:36 -04:00
Eivind Fonn
1458b3ff73 Remove deferred for projectile-rails 2017-02-11 11:19:04 +01:00
Adam Sokolnicki
26e64d3918 Use projectile-rails-global-mode if available 2017-02-11 11:18:03 +01:00
syl20bnr
fb27ede558 Bump year in copyright headers
Happy New Year 2017!
2017-01-05 23:08:17 -05:00
syl20bnr
74fdbb6795 Refactor and simplify company backends declaration
Enabling a company backend for a specific mode was a tedious tasks with code
scattered at different locations, one for local variable definitions, one for
company hook function definitions and another where the backends were pushed to
the local variables (which was problematic, since we ended up pushing the same
backends over and over again with `SPC f e R`, pushes have been replaced by
add-to-list calls in the new macro).

All these steps are now put together at one place with the new macro
spacemacs|add-company-backends, check its docstring for more info on its
arguments.

This macro also allows to define arbitrary buffer local variables to tune
company for specific modes (similar to layer variables via a keyword :variables)

The code related to company backends management has been moved to the
auto-completion layer in the funcs.el file. A nice side effect of this move is
that it enforces correct encapsulation of company backends related code. We can
now easily detect if there is some configuration leakage when the
auto-completion layer is not used. But we loose macro expansion at file loading
time (not sue it is a big concern though).

The function spacemacs|enable-auto-complete was never used so it has been
deleted which led to the deletion of the now empty file core-auto-completion.el.

The example in LAYERS.org regarding auto-completion is now out of date and has
been deleted. An example to setup auto-completion is provided in the README.org
file of the auto-completion layer.
2017-01-02 00:39:04 -05:00
syl20bnr
c725823e73 javascript and react: reformat code and move funcs to funcs.el
Some conventional cleanup.
Note that the function `spacemacs/js2-refactor-set-key-bindings` has been
removed since it is not used anywhere.
2017-01-01 22:45:23 -05:00
Justin Burkett
7bf00ad878 which-key: Update usage of replacement alists
See 19186917eb
2016-11-25 12:32:10 +02:00
Joe Selman
fff5cf3079 Declare prefix for ruby-mode and enh-ruby-mode in rails layer
Fixes #7375
2016-10-17 13:23:28 +02:00
syl20bnr
7d8b6bd0f6 react: Fix emmet -> emmet-mode 2016-10-09 21:44:35 -04:00
Kai Pruess
0d70306b90 Add emmet-mode to react-mode
Closes syl20bnr/spacemacs#5130
2016-10-08 19:45:58 +02:00
syl20bnr
03143b61f2 Fix (error: (void-variable spacemacs-jump-handlers-react-mode)) 2016-09-05 22:19:56 -04:00
syl20bnr
564cbc40ed core: better behavior for dotspacemacs-download-packages
See end of this message for important breaking changes.

Previous behavior was to configure any installed package which caused
a lot of bad side effects and could make spacemacs unusable. This
behavior made little sense and does not fit with spacemacs.

This commit fixes this behavior by separating installed packages from
configured packages. In short dostspacemacs-download-packages variable
now only affect package installation. Packages are now configured if and
only if they are effectively *used* (i.e. listed in variable
dotspacemacs-configuration-layers or dotspacemacs-additional-packages).

IMPORTANT CHANGE: functions `configuration-layer/declare-used-layer` and
`configuration-layer/declare-used-layers` have been removed. These
functions have been introduced in develop branch only so the impact
should be minimal.
2016-08-19 21:04:33 -03:00
Muneeb Shaikh
48d06e4ee9 rails: add which key prefixes for rails
* layers/+frameworks/ruby-on-rails/packages.el (ruby-on-rails/init-projectile-rails):
  added which-key prefixes for rails
* layers/+frameworks/ruby-on-rails/packages.el (ruby-on-rails/post-init-which-key):
  diminish `projectile-rails` prefix in which-key menu to make commands
  visible (since we're in rails menu, it makes sense to diminish common
  prefix)
2016-08-05 21:29:02 +02:00
syl20bnr
1c4f685b13 core: refactor layer system
TL;DR Should get 20~25% speed improvement on startup, should get a big
improvement when using ivy or helm SPC h SPC. Users with layers.el files
in their layers must use `configuration-layer/declare-used-layer`
instead of `configuration-layer/declare-layer`

The implementation of the layer system made heavy use of `object-assoc`
and `object-assoc-list` functions which are not efficient. This PR
mainly replaces those object lists with hash maps in order to index the
objects by their name and achieve an O(1) access time.

The old object lists `configuration-layer--layers` and
`configuration-layer--packages` have been each by two variables each:
- `configuration-layer--indexed-layers` which is a hash-map of all the
layer objects and `configuration-layer--used-layers` which is a list of
all _used_ layers symbols,
- symmetrically `configuration-layer--indexed-packages` which is a
hash-map of all the package objects and
`configuration-layer--used-packages` which is a list of all _used_
packages symbols.

The hash map `configuration-layer--layer-paths` is gone, now we create
directly layer objects when discovering the layers and set the :dir
property. Note that previously the layer paths were the parent directory
of the layer, now :dir is the layer path.

The function `configuration-layer//make-layer` is now similar to its
counterpart `configuration-layer//make-package` in the sense that it
takes an optional `obj` to be able to override its properties.

The functions `configuration-layer/declare-layer` and
`configuration-layer/declare-layers` now takes an optional parameter
`usedp` in order to declare used or not used layers. For convenience
new functions have been added: `configuration-layer/declare-used-layer`
and `configuration-layer/declare-used-layers`, users _must_ update all
occurrences of `configuration-layer/declare-layer` by
`configuration-layer/declare-used-layers` in their `layers.el` files.

`helm-spacemacs-help` and `ivy-spacemacs-help` are updated to match the
changes in `core-configuration-layer.el`.

Rename some variables to make them more explicit:
`configuration-layer-no-layer` -> `configuration-layer-exclude-all-layers`
`configuration-layer-distribution` -> `configuration-layer-force-distribution`
2016-07-28 23:26:54 -04:00
syl20bnr
85ace24553 react: fix tern setup
The init function should be a post-init instead of an init function.
Also simplified the configuratin quite a bit.
2016-06-21 19:04:59 -04:00
Shahin
cc2a38fc76 Add javascript-standard as a flycheck checker to react-mode
By default the only available checker in `react-mode` is
javascript-eslint. `javascript-standard` is based on `javascript-eslint`
and has some modification on rules. Since it's not defined as a checker
for this mode, it's also impossible to select it in a buffer.
2016-06-05 21:24:42 -04:00
syl20bnr
a2de9a63af Use :toggle keyword instead of when forms 2016-05-29 22:39:21 -04:00