Commit graph

428 commits

Author SHA1 Message Date
duianto a82d2292b6 [base] Fix void helm-use-fuzzy
problem:
The spacemacs-completion layer defines the variable:
helm-use-fuzzy

But the spacemacs-base distribution doesn't use the
spacemacs-completion layer by default.

helm-use-fuzzy is used in the helm layer.

When a helm buffer is opened, for example: `SPC SPC`
Then a warnings buffer opens:
>Error (use-package): helm/:config: Symbol’s value as variable is void: helm-use-fuzzy

solution:
Make sure that helm-use-fuzzy is bound and true.
2020-12-30 20:54:00 +01:00
Maximilian Wolff 1be72042e1 [ivy] Add doc for new C-SPC binding 2020-12-13 09:52:43 +00:00
Thanh Vuong 49a4fa072d [ivy] improve key bindings
bind c-spc to  ivy-call-and-recenter
this is the closest thing to helm follow mode in ivy world

unbin `g` key and map `U` for
for ivy-occur-mode-map and ivy-occur-grep-mode-map
2020-12-13 10:36:37 +01:00
Keshav Kini ca7e66ba98 Revert helm-ag/helm-grep binding of RET to default
Currently 'helm-ag-mode-jump-other-window is bound both to RET and to C-o (its
original default binding), while 'helm-ag-mode-jump isn't bound at all (its
original default binding is RET).  This commit removes our customization so that
both 'helm-ag-mode-jump-other-window and 'helm-ag-mode-jump have bindings in the
mode.

The same change is also made for the analogous helm-grep functions, for the same
reason.
2020-11-27 19:19:36 +01:00
Lucius Hu 3c35407968
Minor changes on helm layer (#14088)
* Added `helm-ag-success-exit-status` when using `rg`

It's been advised by the upstream of `helm-ag` to set
`helm-ag-success-exit-status` to `'(0 2)`.

This commit adds this.

ref: https://github.com/emacsorphanage/helm-ag#helm-agel-with-other-searching-tools

Signed-off-by: Lucius Hu <lebensterben@users.noreply.github.com>

* Use `magit-status-setup-buffer` instead of `vcr-dir`

This is suggested by the package itself.
Ref: 4da1a53f2f/helm-ls-git.el (L184-L189)

Co-authored-by: Lucius Hu <lebensterben@users.noreply.github.com>
2020-10-26 23:11:54 +01:00
madand 5884aa9aaa [ivy] Lazy load ivy-avy and ivy-hydra after ivy 2020-10-26 23:08:04 +01:00
Boris Sergeyev 3e033e39f6 [helm] helm-swoop, ignore helm-full-frame' and pop-up-windows'
because current implementation does not support full-frame usage:
see https://github.com/syl20bnr/spacemacs/issues/2157
2020-10-22 19:49:49 +02:00
duianto 331bf1b5bf [ivy] Rebind C-k to C-M-k in ivy-reverse-i-search
This enables navigating up in the `ivy-reverse-i-search` list with `C-k`.

The same rebinding from `C-k` to `C-M-k` to kill a list entry,
is also done in the `ivy-switch-buffer`.
2020-10-15 23:10:06 +02:00
Daniel Nicolai 2cdb535d04 Fix counsel find-file functions to use Spacemacs large file check
By default Ivy uses `find-file` which uses Emacs `abort-if-file-too-large`
function to check/warn before opening large files. That function however does
not take into account Spacemacs its `spacemacs-large-file-modes-list`. Instead
ivy should use `find-file-noselect` to skip Emacs it large file warning and let
it to Spacemacs its `spacemacs/check-large-file` function. Additionally [Emacs
tips on
comments](https://www.gnu.org/software/emacs/manual/html_node/elisp/Comment-Tips.html)
recommends to use 3 semicolons for comments that function as headings.
2020-10-15 23:08:05 +02:00
Wieland Hoffmann b606d82dfb [ivy] Bind SPC s l to ivy-resume
Helm already has spacemacs/resume-last-search-buffer bound to it and is in my
muscle memory. spacemacs/resume-last-search-buffer doesn't work with ivy, so
just use ivy-resume.
2020-10-10 06:11:12 +02:00
Maximilian Wolff 23f956659b
Fix formatting of ivy keybinding table 2020-10-04 11:48:37 +02:00
Daniel Nicolai 34bd5ab40d
Add C-RET keybinding for ivy-alt-done 2020-10-04 11:48:36 +02:00
Daniel Nicolai 4acea82f7b Replace spacemacs/swiper with better native swiper functions
Spacemacs uses spacemacs/swiper functions that use the less sophisticated
spacemacs//counsel-current-region-or-symbol instead of ivy's native
ivy-thing-at-point function. This commit removes those spacemacs functions and
rebinds the shortcuts to their better native equivalents.
2020-10-04 11:16:10 +02:00
Robert O'Connor 82ba73a1c0
update copyright to 2020 2020-09-23 21:25:01 +02:00
syl20bnr e3acd91118 [core] Rename spacemacs|require to spacemacs|require-when-dumping 2020-09-20 21:17:21 -04:00
thanhvg 26a9f51dff
[ivy] add ivy-avy (#13961)
ivy-avy makes it possible to select a candidate with avy by using C-' in an ivy minibuffer.

This functionality used to come with swiper, but it was split: https://github.com/melpa/melpa/pull/6951

Copy pasta from our sister project Doom: https://github.com/hlissner/doom-emacs/pull/3414
2020-09-18 19:54:06 +02:00
Nicholas Kirchner 516da8dfbd [helm] Add the helm-org package so that helm-spacemacs-faq works
There is a (require 'helm-org) directive in helm-spacemacs-faq.el
which is triggered by the key sequence 'SPC h f'.
2020-09-08 11:03:55 +02:00
Ivan Yonchovski 182bf1fe15 Do not enable fuzzy matching for locate if it is not wanted 2020-09-04 22:46:03 +02:00
syl20bnr 52ec07bb44 [core] Fix installation of unused layer dependencies after SPC h SPC
Fix bug where layer dependencies of all layers (even the unused ones)
are installed after SPC h SPC and then SPC f e R
2020-08-29 21:51:52 -04:00
duianto 5150ac6c50 [helm] Hide helm-ff-cache-mode mode-line indicator 2020-07-18 09:40:14 +02:00
Maximilian Wolff d4a590a2fd
[helm] Fix helm with universal argument 2020-07-12 10:18:25 +02:00
Miloš Mošić d4634b5711 Fix incf causing an error message
This was the only place where `incf` was used instead of `cl-incf`,
it fixes the "Symbol’s function definition is void: incf" error
2020-06-24 23:15:53 +02:00
Maximilian Wolff d314cc7eef
Make auto-complete more configurable and efficient for lsp
To optimise performance of lsp mode in emacs 27 and above
I have introduced a new dotfile variable to define the size
of data read from external processes. The default I have
set to the recommended setting from lsp-mode.

In addition I have introduced a new layer variable for
auto-complete-layer to define the minimum prefix length.

I have also added instructions to auto-complete's readme
how to set these variables to the recommended settings
for lsp-mode.

Changes inspired from #13507
2020-05-15 22:22:28 +02:00
Maximilian Wolff c7ed2fc597
[helm] Provide fuzzy matching for Helm-M-x
Following the advice from duianto #13100 we are
setting completion-styles for helm-M-x to include
the emacs version specific fuzzy strategy as last
resort.

Before no fuzzy matching occured within command
searches.
2020-05-11 12:36:56 +02:00
emacspace ff4a528bb4
documentation formatting: Sat Mar 21 19:36:41 UTC 2020 2020-03-21 20:57:20 +01:00
Daniel Nicolai 2049817b12
[ivy] Replace custom hydra-menu by original hydra-menu 2020-03-17 09:51:12 +01:00
duianto 0a06c7ca6b Fix filenames in layer file headers
Also fixed the groovy/funcs.el header which said: Java
2020-02-20 00:07:30 +01:00
duianto 96438694f4
[base] Add cl- prefix to letf and letf*
The cl package has been deprecated.

It had aliases for cl- prefixed commands without the cl- prefix.
Ex: letf or letf* instead of cl-letf or cl-letf*

On the `spacemacs-base` distribution, with the `ivy` layer.
When one tries to search with `SPC /`
(which calls `spacemacs/counsel-search`)

Then this error message is shown:
>spacemacs/counsel-search: Symbol’s function definition is void: letf*

It doesn't happen with the `helm` layer,
because it's search commands already has the `cl-` prefix.

There are also three instances of: `letf`
in the `spacemacs-editing-visual` layers functions:
- `spacemacs/toggle-centered-buffer` (`SPC w c c`)
- `spacemacs/toggle-distraction-free` (`SPC w c C`)
- `spacemacs/centered-buffer-transient-state` (`SPC w c .`)

Without the `cl-` prefix they show the error message:
>Symbol’s function definition is void: letf
2020-02-08 09:17:52 +00:00
wangtianshu 38a9f7c395 [auto-completion] Don't install company-statistics unless necessary 2020-02-07 20:14:37 +01:00
syl20bnr 0a1c93c6a2 [auto-completion] Update README 2020-02-01 10:09:55 -05:00
Benjamin Hipple 7ef83a4b59
[auto-completion] Update documentation on global-company-mode
Reword it to note that this is strongly discouraged, and include a link to the
layer opt-out mechanism that will be broken if this is enabled.

See comment here for details:
https://github.com/syl20bnr/spacemacs/pull/13164#issuecomment-578410362
2020-02-01 08:22:21 +00:00
duianto 27178f23e9 Fix helm-spacemacs-help-faq, SPC h f
The function: helm-org-get-candidates was removed upstream.

Improvements:
Recenter the target candidate.

Reversed the helm headings list, to match the order of the
questions in FAQ.org, so that the Common questions are
listed first.

Removed the : (colon) after the heading: How do I
in FAQ.org, to match the other parent headings.
2020-01-25 17:37:47 +01:00
Richard Kim 278be41010 [helm] Created spacemacs/helm-dir-do-grep to fix issue #13167
This is used if someone does not have ag, pt, rgrep, etc.
2020-01-20 15:53:20 +01:00
Zach Latta 1d2a1fa6e4 Fix capitalization of GitHub
Change instances of "Github" to "GitHub".
2020-01-20 09:14:12 +01:00
Jacek Swierk cefcce2caa
[helm] Fix rg interaction with its config file
If a user uses ripgrep persistent configuration file that sets options
helm overrides the argument parser for ripgrep might incorrectly parse
the command line used by helm.

The problem is encountered whenever an argument option occurs multiple
times and the last one is of this form: '--arg value' or '-a v'. If that
last argument is followed by the positional argument (input) then its
value will be treated as the input resulting in error due to too many
positional arguments.

In other worlds, this would fail to be parsed correctly:
    rg --max-columns=10 --max-columns 20 input
    rg --max-columns 10 --max-columns 20 input

While this works as expected:
    rg --max-columns=10 --max-columns=20 input
    rg --max-columns 10 --max-columns=20 input

The solution would be to use arguments in the form of '--arg=value'
which will never be treated as a positional argument.

Fixes #10953
2020-01-02 23:18:36 +01:00
duianto 68a2f37670
Fix helm-find-files-edit action C-c C-e 2019-12-20 18:39:11 +01:00
Nikita Leshenko aaa11a6823 Convert case' to cl-case' to fix cl-lib related errors
Broken since PR #13059
2019-12-18 12:08:05 +01:00
madand 194de4d73a
[ivy] Fix visual selection expansion across the buffer on SPC s S
and `SPC s B`

When one invokes `spacemacs/swiper-region-or-symbol` (`SPC s S`) or
`spacemacs/swiper-all-region-or-symbol` (`SPC s B`) with active visual selection
(transient-mark-mode), the selection expands over the buffer while one jumps
around with swiper. Thus I believe it is appropriate to deactivate visual
selection within the above command.

Since the mentioned commands both use identical code for getting the text to
operate on, I moved that code into a separate function.
2019-12-15 15:17:21 +01:00
madand 57e6849c68
[ivy] SPC h m: fallback to woman on Windows
`man` command displays output from the external program with the same name,
so it will generally fail to work on Windows.

`woman` is a pure elisp parser for manpages, so it will work on Windows. But
`woman` lacks colorizing of manpages, so we only use it as a fallback.
2019-12-15 15:06:26 +01:00
Spenser Truex 05fb56bfbf Remove uses of lexical-let, part of the deprecated cl package
These prevented loading, a serious bug.
2019-12-15 08:45:27 +01:00
kimr da80634370
converted cl to cl-lib 2019-12-14 20:20:51 +00:00
madand 239f60a65f [ivy][docs] Add SPC h m: search available man pages
This keybinding is documented in DOCUMENTATION.org, yet was missing in ivy layer.
2019-12-10 22:54:40 +01:00
Brian Wignall 4df6c9035f
Fix typos 2019-12-05 22:23:04 +01:00
duianto 979f4db640
[helm] Fix searching in projects with C-s from SPC p p
Fixes #11878

The issue seems to have been caused by helm making sure that
the functions that are called with: helm-exit-and-execute-action
are actions.

Ensure action is available before running it
d6dfb8f1e3
2019-12-05 22:17:11 +01:00
duianto 6649e78f3e
Document helm and ivy colors/faces key bindings
Helm:
SPC C l   calls helm-colors
SPC h d F calls spacemacs/helm-faces

Ivy:
SPC C e   calls counsel-colors-emacs
SPC C f   calls counsel-colors-faces
SPC C w   calls counsel-colors-web
SPC h d F calls counsel-describe-face

Thanks Miciah for the SPC h d F suggestion.
2019-12-03 22:21:42 +00:00
madand fd184bb94f Fix spacemacs/counsel-search with ag and rg
The commit 9c613b8 introduced a regression for ivy users that use ag or rg as
the search tool. It made `C-c C-e` and `F3` keybindings unavailable, and thus
making it impossible to make multi-file edits.

Partially fixes #12838
2019-11-24 22:07:17 +01:00
Maximilian Wolff dd7a5d98be
Revise helm recompile package action and bind recompile-elpa
The newly introduced function to compile an elpa package
was very much redundant with the existing recompile-elpa function.

I have adapted recompile-elpa so that it can be used for the helm action too.

In addition I have bound recompile-elpa to `SPC c C-c` to allow users to
easily recompile their entire elpa directory if the need arises.

I have also removed the error handling in the helm action in favor of
standard error reporting via the *Compile-Log* buffer.
2019-11-24 02:07:15 +01:00
Gia Thanh Vuong 94de754504
[core] [helm] add action to recompile an elpa package
How to use: `SCP h p` select package then `F3` or `C-z` and choose `Recompile`

Motivation: Some packages when compiling need other packages to be loaded first.
The pacakage maintainers should make sure of this requirement but sommetimes
they don't. It also doesn't help when Spacemacs is lazy loading and compiles
updated pacakges on startup. So the manual fix for this problem is recompile the
package once Spacemacs has fully loaded. This requires user go to the package
install location to delete elc files and then do a `spacemacs/recompile-elpa`.
This commit will do that chore for them.

This will make fixing the problem with `org-plus-contrib` or `dumb-jump` update
every now and then easier.
2019-11-23 23:40:50 +01:00
Carlos Ibáñez 6ca42efe7c Fix wrong initial directory 2019-11-18 15:32:25 +01:00
lovrolu bc22a259e8 Don't assume the previous binding was evil-insert-digraph 2019-11-15 20:05:23 +01:00