[CI] Fail job when CircleCI didn't set required vars

.circleci/PR_base

@@ -11,7 +11,8 @@
 ##
 ## License: GPLv3
 
-skip_for_branch_update
+skip_when_branch_update
+fail_when_undefined_pr_number
 
 pr_base=$(curl -s "${pr_data_URL}" | jq '.base.ref')
 if [[ "${pr_base}" == "\"${dev_b}\"" ]]; then

.circleci/PR_changelong

@@ -11,13 +11,15 @@
 ##
 ## License: GPLv3
 
-skip_for_branch_update
+skip_when_branch_update
 
 if [[ "$CIRCLE_PR_USERNAME" == "${bot_login}" ]]; then
     echo "Fun fact. Bots can't climb stairs or update CHANGELOG.develop"
     exit 0
 fi
 
+fail_when_undefined_pr_number
+
 if grep -q CHANGELOG.develop /tmp/changed_files; then
     echo "CHANGELOG.develop was updated as required"
 else

.circleci/PR_rebased

@@ -11,7 +11,8 @@
 ##
 ## License: GPLv3
 
-skip_for_branch_update
+skip_when_branch_update
+fail_when_undefined_pr_number
 
 upstream_head_sha=$(curl -s "${upstream_data_URL}" | jq '.commit.sha')
 pr_base_sha=$(curl -s "${pr_data_URL}" | jq '.base.sha')

.circleci/select

@@ -11,7 +11,8 @@
 ##
 ## License: GPLv3
 
-skip_for_branch_update
+skip_when_branch_update
+fail_when_undefined_pr_number
 
 echo "PATCH_URL: \"${pr_patch_URL}\""
 

.circleci/shared

@@ -48,8 +48,18 @@ select_changed_orgs () {
     done </tmp/changed_files
 }
 
-skip_for_branch_update () {
+fail_when_undefined_pr_number () {
     if [[ -z "${CIRCLE_PR_NUMBER// }" ]]; then
+        echo "CircleCI didn't set $CIRCLE_PR_NUMBER"
+        echo "nor $CIRCLE_PULL_REQUEST! This time..."
+        echo "Job restart sometimes helps."
+        echo "Aborting the job."
+        exit 1
+    fi
+}
+
+skip_when_branch_update () {
+    if [[ "${IS_BRANCH_UPDATE}" == "yes" ]]; then
         echo "Skipping for branch update."
         exit 0
     fi

.circleci/validoc/export

@@ -11,7 +11,8 @@
 ##
 ## License: GPLv3
 
-skip_for_branch_update
+skip_when_branch_update
+fail_when_undefined_pr_number
 
 select_changed_orgs
 if [ ${#changed_f_as_args[@]} -ne 0 ]; then

.circleci/validoc/validate

@@ -11,7 +11,8 @@
 ##
 ## License: GPLv3
 
-skip_for_branch_update
+skip_when_branch_update
+fail_when_undefined_pr_number
 
 select_changed_orgs
 if [ ${#changed_f_as_args[@]} -ne 0 ]; then