Tweak flycheck loading process

layers/+config-files/puppet/packages.el

@@ -38,4 +38,4 @@
   (spacemacs|add-company-hook puppet-mode))
 
 (defun puppet/post-init-flycheck ()
-  (spacemacs/add-flycheck-hook 'puppet-mode-hook))
+  (spacemacs/add-flycheck-hook 'puppet-mode))

layers/+frameworks/react/packages.el

@@ -41,7 +41,7 @@
       (add-hook 'react-mode-hook #'react/disable-jshint))))
 
 (defun react/post-init-flycheck ()
-  (spacemacs/add-flycheck-hook 'react-mode-hook))
+  (spacemacs/add-flycheck-hook 'react-mode))
 
 (defun react/post-init-js-doc ()
   (add-hook 'react-mode-hook 'spacemacs/js-doc-require)

layers/+lang/c-c++/packages.el

@@ -89,8 +89,8 @@
       :init (push 'company-c-headers company-backends-c-mode-common))))
 
 (defun c-c++/post-init-flycheck ()
-  (dolist (hook '(c-mode-hook c++-mode-hook))
-    (spacemacs/add-flycheck-hook hook))
+  (dolist (mode '(c-mode c++-mode))
+    (spacemacs/add-flycheck-hook mode))
   (when c-c++-enable-clang-support
     (spacemacs/add-to-hooks 'c-c++/load-clang-args '(c-mode-hook c++-mode-hook))))
 

layers/+lang/d/packages.el

@@ -24,7 +24,7 @@
 
 (when (configuration-layer/layer-usedp 'syntax-checking)
   (defun d/post-init-flycheck ()
-    (spacemacs/add-flycheck-hook 'd-mode-hook))
+    (spacemacs/add-flycheck-hook 'd-mode))
   (defun d/init-flycheck-dmd-dub ()
     (use-package flycheck-dmd-dub :defer t
       :init (add-hook 'd-mode-hook 'flycheck-dmd-dub-set-include-path))))

layers/+lang/emacs-lisp/packages.el

@@ -128,7 +128,7 @@
 (defun emacs-lisp/post-init-flycheck ()
   ;; Don't activate flycheck by default in elisp
   ;; because of too much false warnings
-  ;; (spacemacs/add-flycheck-hook 'emacs-lisp-mode-hook)
+  ;; (spacemacs/add-flycheck-hook 'emacs-lisp-mode)
 
   ;; Make flycheck recognize packages in loadpath
   ;; i.e (require 'company) will not give an error now

layers/+lang/erlang/packages.el

@@ -41,4 +41,4 @@
     (require 'erlang-start)))
 
 (defun erlang/post-init-flycheck ()
-  (spacemacs/add-flycheck-hook 'erlang-mode-hook))
+  (spacemacs/add-flycheck-hook 'erlang-mode))

layers/+lang/go/packages.el

@@ -10,7 +10,7 @@
         ))
 
 (defun go/post-init-flycheck ()
-  (spacemacs/add-flycheck-hook 'go-mode-hook))
+  (spacemacs/add-flycheck-hook 'go-mode))
 
 (defun go/init-go-mode()
   (when (memq window-system '(mac ns x))

layers/+lang/haskell/packages.el

@@ -37,7 +37,7 @@
       (spacemacs/set-leader-keys-for-major-mode 'haskell-mode "hf" 'helm-hoogle))))
 
 (defun haskell/post-init-flycheck ()
-  (spacemacs/add-flycheck-hook 'haskell-mode-hook))
+  (spacemacs/add-flycheck-hook 'haskell-mode))
 
 (when (configuration-layer/layer-usedp 'syntax-checking)
   (defun haskell/init-flycheck-haskell ()

layers/+lang/html/packages.el

@@ -99,14 +99,14 @@
   (add-hook 'web-mode-hook 'turn-on-evil-matchit-mode))
 
 (defun html/post-init-flycheck ()
-  (dolist (hook '(haml-mode-hook
-                  jade-mode-hook
-                  less-mode-hook
-                  sass-mode-hook
-                  scss-mode-hook
-                  slim-mode-hook
-                  web-mode-hook))
-    (spacemacs/add-flycheck-hook hook)))
+  (dolist (mode '(haml-mode
+                  jade-mode
+                  less-mode
+                  sass-mode
+                  scss-mode
+                  slim-mode
+                  web-mode))
+    (spacemacs/add-flycheck-hook mode)))
 
 (defun html/init-haml-mode ()
   (use-package haml-mode

layers/+lang/javascript/packages.el

@@ -57,8 +57,8 @@
       (push 'company-tern company-backends-js2-mode))))
 
 (defun javascript/post-init-flycheck ()
-  (dolist (hook '(coffee-mode-hook js2-mode-hook json-mode-hook))
-    (spacemacs/add-flycheck-hook hook)))
+  (dolist (mode '(coffee-mode js2-mode json-mode))
+    (spacemacs/add-flycheck-hook mode)))
 
 (defun javascript/init-js-doc ()
   (use-package js-doc

layers/+lang/latex/packages.el

@@ -157,7 +157,7 @@
   (add-hook 'LaTeX-mode-hook 'evil-matchit-mode))
 
 (defun latex/post-init-flycheck ()
-  (spacemacs/add-flycheck-hook 'LaTeX-mode-hook))
+  (spacemacs/add-flycheck-hook 'LaTeX-mode))
 
 (defun latex/post-init-flyspell ()
   (spell-checking/add-flyspell-hook 'LaTeX-mode-hook))

layers/+lang/lua/packages.el

@@ -6,7 +6,7 @@
     ))
 
 (defun lua/post-init-flycheck ()
-  (spacemacs/add-flycheck-hook 'lua-mode-hook))
+  (spacemacs/add-flycheck-hook 'lua-mode))
 
 (defun lua/init-lua-mode ()
   (use-package lua-mode

layers/+lang/nim/packages.el

@@ -8,7 +8,7 @@
   (spacemacs|add-company-hook nim-mode))
 
 (defun nim/post-init-flycheck ()
-  (spacemacs/add-flycheck-hook 'nim-mode-hook))
+  (spacemacs/add-flycheck-hook 'nim-mode))
 
 (defun nim/init-flycheck-nim ()
   (use-package flycheck-nim

layers/+lang/ocaml/packages.el

@@ -27,7 +27,7 @@
 
 (when (configuration-layer/layer-usedp 'syntax-checking)
   (defun ocaml/post-init-flycheck ()
-    (spacemacs/add-flycheck-hook 'merlin-mode-hook))
+    (spacemacs/add-flycheck-hook 'merlin-mode))
   (defun ocaml/init-flycheck-ocaml ()
     (use-package flycheck-ocaml
       :if (configuration-layer/package-usedp 'flycheck)

layers/+lang/python/packages.el

@@ -94,7 +94,7 @@
   (add-hook `python-mode-hook `turn-on-evil-matchit-mode))
 
 (defun python/post-init-flycheck ()
-  (spacemacs/add-flycheck-hook 'python-mode-hook))
+  (spacemacs/add-flycheck-hook 'python-mode))
 
 (when (configuration-layer/layer-usedp 'spacemacs-helm)
   (defun python/pre-init-helm-cscope ()

layers/+lang/ruby/packages.el

@@ -88,8 +88,8 @@
     (add-hook hook `turn-on-evil-matchit-mode)))
 
 (defun ruby/post-init-flycheck ()
-  (spacemacs/add-flycheck-hook 'ruby-mode-hook)
-  (spacemacs/add-flycheck-hook 'enh-ruby-mode-hook))
+  (spacemacs/add-flycheck-hook 'ruby-mode)
+  (spacemacs/add-flycheck-hook 'enh-ruby-mode))
 
 (defun ruby/post-init-popwin ()
   (push '("*rspec-compilation*" :dedicated t :position bottom :stick t :noselect t :height 0.4)

layers/+lang/rust/packages.el

@@ -22,7 +22,7 @@
 
 (when (configuration-layer/layer-usedp 'syntax-checking)
   (defun rust/post-init-flycheck ()
-    (spacemacs/add-flycheck-hook 'rust-mode-hook))
+    (spacemacs/add-flycheck-hook 'rust-mode))
 
   (defun rust/init-flycheck-rust ()
     (use-package flycheck-rust

layers/syntax-checking/README.org

@@ -40,6 +40,10 @@ toggled off with ~SPC t s~. You can default this to off by setting the variable
   '((syntax-checking :variables syntax-checking-enable-by-default nil)))
 #+END_SRC
 
+If you want more fine-grained control, you can configure the variable
+=flycheck-global-modes= instead. Note that this variable should be manipulated
+in =dotspacemacs/user-config=.
+
 * Key Bindings
 
 | Key Binding | Description                                                  |

layers/syntax-checking/funcs.el

@@ -9,8 +9,10 @@
 ;;
 ;;; License: GPLv3
 
-(defun spacemacs/add-flycheck-hook (hook)
-  "Add flycheck to the given HOOK, if
-`syntax-checking-enable-by-default' is true."
-  (when syntax-checking-enable-by-default
-    (add-hook hook 'flycheck-mode)))
+(defun spacemacs/add-flycheck-hook (mode)
+  "Use flycheck in MODE by default, if `syntax-checking-enable-by-default' is
+true."
+  (when (and syntax-checking-enable-by-default
+             (listp flycheck-global-modes
+                    (not (eq 'not (car flycheck-global-modes)))))
+    (push mode flycheck-global-modes)))

layers/syntax-checking/packages.el

@@ -18,20 +18,23 @@
 
 (defun syntax-checking/init-flycheck ()
   (use-package flycheck
-    :defer t
     :init
     (progn
-      (setq flycheck-standard-error-navigation nil)
+      (setq flycheck-standard-error-navigation nil
+            flycheck-global-modes nil)
+
       (spacemacs|add-toggle syntax-checking
         :status flycheck-mode
         :on (flycheck-mode)
         :off (flycheck-mode -1)
         :documentation "Enable error and syntax checking."
-        :evil-leader "ts"))
-    :config
-    (progn
+        :evil-leader "ts")
+
       (spacemacs|diminish flycheck-mode " ⓢ" " s")
 
+      (when syntax-checking-enable-by-default
+        (global-flycheck-mode 1))
+
       ;; Custom fringe indicator
       (when (fboundp 'define-fringe-bitmap)
         (define-fringe-bitmap 'my-flycheck-fringe-indicator