Revise elfeed layer

Moved dependency checks from the init functions to
the package initialisation.

Added documentation for the new `elfeed-enable-goodies`
variable and changed the default to `t`.

layers/+readers/elfeed/README.org

@@ -13,6 +13,7 @@
     - [[#with-org][With Org]]
     - [[#manually][Manually]]
   - [[#server][Server]]
+  - [[#elfeed-goodies][Elfeed goodies]]
 - [[#key-bindings][Key bindings]]
 - [[#troubleshooting][Troubleshooting]]
   - [[#database-empty-at-first-start][Database empty at first start]]
@@ -88,12 +89,21 @@ Elfeed comes with a simple [[https://github.com/skeeto/elfeed#web-interface][web
 start it by calling =elfeed-web-start= or by setting =elfeed-enable-web-interface=
 to =t= which will start the web automatically when Emacs starts.
 
+By default web interface is available on [[http://localhost:8080/elfeed/][localhost:8080/elfeed]]. You can change
+the default port by changing the value of =httpd-port=.
+
 #+BEGIN_SRC emacs-lisp
   (elfeed :variables elfeed-enable-web-interface t)
 #+END_SRC
 
-By default web interface is available on [[http://localhost:8080/elfeed/][localhost:8080/elfeed]]. You can change
-the default port by changing the value of =httpd-port=.
+** Elfeed goodies
+Elfeed layer loads a set of useful helper functions and bindings to improve your elfeed experience.
+Normally these should help you however there are some workflows where these may rather hinder you.
+In this case you can disable these by setting =elfeed-enable-goodies= to =nil=.
+
+#+BEGIN_SRC emacs-lisp
+  (elfeed :variables elfeed-enable-goodies nil)
+#+END_SRC
 
 * Key bindings
 

layers/+readers/elfeed/config.el

@@ -13,5 +13,5 @@
 
 (defvar elfeed-enable-web-interface nil
   "If non nil start a web server to consult the database in a web browser.")
-(defvar elfeed-enable-goodies nil
+(defvar elfeed-enable-goodies t
   "If non nil enable elfeed-goodies (split-pane...).")

layers/+readers/elfeed/packages.el

@@ -11,9 +11,9 @@
 
 (setq elfeed-packages
       '(elfeed
-        elfeed-goodies
+        (elfeed-goodies :toggle elfeed-enable-goodies)
         elfeed-org
-        elfeed-web
+        (elfeed-web :toggle elfeed-enable-web-interface)
         ))
 
 (defun elfeed/init-elfeed ()
@@ -46,17 +46,15 @@
         "y"  'elfeed-search-yank))))
 
 (defun elfeed/pre-init-elfeed-goodies ()
-  (when elfeed-enable-goodies
-    (spacemacs|use-package-add-hook elfeed
-      :post-config
-      (progn
-        (elfeed-goodies/setup)
-        (evil-define-key 'evilified elfeed-show-mode-map
-          "o" 'elfeed-goodies/show-ace-link)))))
+  (spacemacs|use-package-add-hook elfeed
+    :post-config
+    (progn
+      (elfeed-goodies/setup)
+      (evil-define-key 'evilified elfeed-show-mode-map
+        "o" 'elfeed-goodies/show-ace-link))))
 
 (defun elfeed/init-elfeed-goodies ()
-  (when elfeed-enable-goodies
-    (use-package elfeed-goodies :commands elfeed-goodies/setup)))
+  (use-package elfeed-goodies :commands elfeed-goodies/setup))
 
 (defun elfeed/pre-init-elfeed-org ()
   (when (boundp 'rmh-elfeed-org-files)
@@ -72,8 +70,9 @@
   (use-package elfeed-web
     :defer t
     :commands elfeed-web-stop
-    :init (when elfeed-enable-web-interface
-            ;; TODO check if the port is already in use
-            ;; hack to force elfeed feature to be required before elfeed-search
-            (require 'elfeed)
-            (elfeed-web-start))))
+    :init
+    (progn
+      ;; TODO check if the port is already in use
+      ;; hack to force elfeed feature to be required before elfeed-search
+      (require 'elfeed)
+      (elfeed-web-start))))