From 7706f0ffd2ce0356fa1829faf4ab45951eb07f73 Mon Sep 17 00:00:00 2001 From: Lucius Hu Date: Thu, 4 Aug 2022 18:50:26 -0400 Subject: [PATCH] helm: remove unnecessary setting on xref-show-xrefs-function For `helm` users, we set `xref-show-xrefs-function` according to Emacs version. This is a two-fold unnecessity: - We now only support Emacs version > 27, so `hellm-xref-show-xrefs` should not be used anyway. - `hem-xref` already set this variable according to Emacs version. See [here][ref]. This commit removes this. ref: https://github.com/brotzeit/helm-xref/blob/ea0e4ed8a9baf236e4085cbc7178241f109a53fa/helm-xref.el#L192-L197 --- layers/+completion/helm/packages.el | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/layers/+completion/helm/packages.el b/layers/+completion/helm/packages.el index 7709256fc..ca9537768 100644 --- a/layers/+completion/helm/packages.el +++ b/layers/+completion/helm/packages.el @@ -481,12 +481,7 @@ xref-find-definitions-other-window xref-find-definitions-other-frame xref-find-references - spacemacs/jump-to-definition)) - ;; Use helm-xref to display `xref.el' results. - (setq xref-show-xrefs-function (if (< emacs-major-version 27) - #'helm-xref-show-xrefs - #'helm-xref-show-xrefs-27))))) - + spacemacs/jump-to-definition))))) (defun helm/post-init-imenu () (spacemacs/set-leader-keys "ji" 'spacemacs/helm-jump-in-buffer))