TakeV/spacemacs
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Fix package loading in lang/ess

Browse source 
Originally `load-ess-on-demand` used `use-package` for the purposes of
actually loading `ess-site` and related elisp for dealing with R. But
since `use-package` doesn't return true or false when a package is
actually successfully loaded anymore, and the semantics of how it will
work aren't precisely clear, it makes sense to use `require` here
instead.

    (defun load-ess-on-demand ()
      (interactive)
      (-all? '---truthy? (list
                          (require 'ess-site)
                          (require 'ess-R-object-popup)
                          (require 'ess-R-data-view))))

All the normal hooks setup by `use-package` will work as normal. I
actually don't see a reason we should use `use-package` instead of
`require` in this specific instance. Since `use-package` often defers
loading packages, it's arguably clearer to use `require` in this
particular instance.
This commit is contained in:
Jean-Christophe Petkovich 2015-05-05 15:24:41 -04:00 committed by syl20bnr
parent 4e23326db0
commit 4a9083a109
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
contrib/lang/ess/packages.el
View file

@ -28,9 +28,9 @@
(defun load-ess-on-demand ()
(interactive)
(-all? '---truthy? (list
(use-package ess-site)
(use-package ess-R-object-popup)
(use-package ess-R-data-view))))
(require 'ess-site)
(require 'ess-R-object-popup)
(require 'ess-R-data-view))))
(evil-leader/set-key "ess" 'load-ess-on-demand)