From 06d95490dc8369c232b37f4f9506ca90d2786515 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Sun, 2 Sep 2018 11:44:18 -0700 Subject: [PATCH] +tools/lsp: remove lsp-ui-peek-expand-by-default lsp-ui has switched to (defcustom lsp-ui-peek-fontify 'on-demand ...) https://github.com/emacs-lsp/lsp-ui/pull/148 . This is no longer needed. --- layers/+tools/lsp/README.org | 1 - layers/+tools/lsp/config.el | 1 - layers/+tools/lsp/packages.el | 3 --- 3 files changed, 5 deletions(-) diff --git a/layers/+tools/lsp/README.org b/layers/+tools/lsp/README.org index 04cd2f4fb..8a894ffeb 100644 --- a/layers/+tools/lsp/README.org +++ b/layers/+tools/lsp/README.org @@ -107,7 +107,6 @@ | =lsp-ui-doc-include-signature= | nil | When nil, signature omitted from lsp-ui-doc overlay (this is usually redundant) | | =lsp-ui-sideline-enable= | t | When non-nil, the symbol information overlay is displayed | | =lsp-ui-sideline-show-symbol= | nil | When non-nil, the symbol information overlay includes symbol name (redundant for c-modes) | - | =lsp-ui-peek-expand-by-default= | nil | When non-nil, =lsp-ui-peek= expands file matches automatically (may degrade performance) | ** Diagnostics If some features do not work as expected, here is a common check list. diff --git a/layers/+tools/lsp/config.el b/layers/+tools/lsp/config.el index 02e252e4c..fdd7120e2 100644 --- a/layers/+tools/lsp/config.el +++ b/layers/+tools/lsp/config.el @@ -11,7 +11,6 @@ ;; ;; These all have toggles bound under 't' in spacemacs/lsp-define-keys-for-mode (defvar lsp-ui-remap-xref-keybindings nil "When non-nil, xref keybindings remapped to lsp-ui-peek-find-*") -(defvar lsp-ui-peek-expand-by-default t "Expand lsp-ui-peek by default (may have performance implications)") (defvar lsp-ui-doc-enable t "Enable/disable lsp-ui-doc overlay") (defvar lsp-ui-doc-include-signature nil "When non-nil, type signature included in the lsp-ui-doc overlay") (defvar lsp-ui-sideline-enable t "Enable/disable lsp-ui-sideline overlay") diff --git a/layers/+tools/lsp/packages.el b/layers/+tools/lsp/packages.el index 762edc881..d0e861901 100644 --- a/layers/+tools/lsp/packages.el +++ b/layers/+tools/lsp/packages.el @@ -55,9 +55,6 @@ (spacemacs//lsp-sync-peek-face) (add-hook 'spacemacs-post-theme-change-hook #'spacemacs//lsp-sync-peek-face) - (if lsp-ui-peek-expand-by-default - (setq lsp-ui-peek-expand-function (lambda (xs) (mapcar #'car xs)))) - (if lsp-ui-remap-xref-keybindings (progn (define-key lsp-ui-mode-map [remap xref-find-definitions] #'lsp-ui-peek-find-definitions) (define-key lsp-ui-mode-map [remap xref-find-references] #'lsp-ui-peek-find-references)))