TakeV/guix
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

gnu: darktable: Add compatibility for ROCm.

Browse source 
darktable has a few tools, which can use OpenCL, not just the main
binary. Instead of wrapping it, patch the search path. ROCm also
fails to build OpenCL kernels with just the inline keyword. Apply
upstream fix.

* gnu/packages/photo.scm (darktable) [#:phases]: Add new phases, remove
LD_LIBRARY_PATH from wrap-binary.
This commit is contained in:
Lars-Dominik Braun 2021-08-06 08:30:13 +02:00
parent 339762235d
commit e81cf4e79a
No known key found for this signature in database
GPG key ID: F663943E08D8092A
1 changed files with 19 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
gnu/packages/photo.scm
View file

@ -486,6 +486,24 @@ (define-public darktable
"-DBUILD_TESTING=On")
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'libOpenCL-path
(lambda* (#:key inputs #:allow-other-keys)
;; Statically link to libOpenCL.
(substitute* "./src/common/dlopencl.c"
(("\"libOpenCL\"")
(string-append "\"" (assoc-ref inputs "ocl-icd") "/lib/libOpenCL.so\"")))
#t))
;; The use of inline is wrong and darktable cannot compile its kernels
;; with ROCm. See upstream commit
;; https://github.com/darktable-org/darktable/commit/f0d8710f5ef34eb7e33b4064e022ebf3057b9e53
(add-after 'unpack 'opencl-inline
(lambda* (#:key inputs #:allow-other-keys)
;; This is a feature of OpenCL 1.2 and later.
(substitute* "data/kernels/CMakeLists.txt"
(("CL1\\.1") "CL1.2"))
(substitute* (find-files "data/kernels" "\\.(cl|h)$")
(("inline") "static inline"))
#t))
(add-before 'configure 'prepare-build-environment
(lambda* (#:key inputs #:allow-other-keys)
;; Rawspeed fails to build with GCC due to OpenMP error:
@ -516,11 +534,7 @@ (define-public darktable
;; For GtkFileChooserDialog.
`("GSETTINGS_SCHEMA_DIR" =
(,(string-append (assoc-ref inputs "gtk+")
"/share/glib-2.0/schemas")))
;; For libOpenCL.so.
`("LD_LIBRARY_PATH" =
(,(string-append (assoc-ref inputs "ocl-icd")
"/lib"))))
"/share/glib-2.0/schemas"))))
#t)))))
(native-inputs
`(("clang" ,clang-11)