Allow regular files as GC roots
If a root is a regular file, then its name must denote a store path. For instance, the existence of the file /nix/var/nix/gcroots/per-user/eelco/hydra-roots/wzc3cy1wwwd6d0dgxpa77ijr1yp50s6v-libxml2-2.7.7 would cause /nix/store/wzc3cy1wwwd6d0dgxpa77ijr1yp50s6v-libxml2-2.7.7 to be a root. This is useful because it involves less I/O (no need for a readlink() call) and takes up less disk space (the symlink target typically takes up a full disk block, while directory entries are packed more efficiently). This is particularly important for hydra.nixos.org, which has hundreds of thousands of roots, and where reading the roots can take 25 minutes.
This commit is contained in:
parent
4ab4b0c109
commit
a98fa2d9e2
|
@ -328,6 +328,12 @@ static void findRoots(StoreAPI & store, const Path & path, Roots & roots)
|
|||
}
|
||||
}
|
||||
|
||||
else if (S_ISREG(st.st_mode)) {
|
||||
Path storePath = settings.nixStore + "/" + baseNameOf(path);
|
||||
if (store.isValidPath(storePath))
|
||||
roots[path] = storePath;
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
catch (SysError & e) {
|
||||
|
|
Loading…
Reference in New Issue