ui: Do not display error messages with bare format strings.

On Guile 3, with, say, an error in ~/.guile, we'd get:

  $ guix repl
  guix repl: error: Unbound variable: ~S

* guix/ui.scm (call-with-error-handling): Add
'&exception-with-kind-and-args' case.
This commit is contained in:
Ludovic Courtès 2020-01-24 10:13:10 +01:00
parent 2aa1e76519
commit a07d5e558b
No known key found for this signature in database
GPG key ID: 090B11993D9AEBB5

View file

@ -770,6 +770,17 @@ (define (manifest-entry-output* entry)
(gettext (condition-message c) %gettext-domain))
(display-hint (condition-fix-hint c))
(exit 1))
;; On Guile 3.0.0, exceptions such as 'unbound-variable' come are
;; compound and include a '&message'. However, that message only
;; contains the format string. Thus, special-case it here to
;; avoid displaying a bare format string.
((cond-expand
(guile-3
((exception-predicate &exception-with-kind-and-args) c))
(else #f))
(raise c))
((message-condition? c)
;; Normally '&message' error conditions have an i18n'd message.
(leave (G_ "~a~%")