TakeV/guix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

profiles: Introduce 'profile-search-paths' and use it.

Browse source 
* guix/profiles.scm (profile-search-paths): New procedure.
* guix/scripts/environment.scm (evaluate-search-paths): Remove.
(create-environment): Replace 'paths' with 'manifest'.  Use
'profile-search-paths' instead of 'evaluate-search-paths'.
(show-search-paths): Likewise.
(launch-environment): Replace 'paths' with 'manifest'.  Make 'pure?' a
keyword parameter.
(launch-environment/fork, launch-environment/container): Likewise.
(guix-environment): Remove 'paths' variable.  Adjust callers of the
above procedures accordingly.
This commit is contained in:
Ludovic Courtès 2018-07-09 13:22:29 +02:00
parent 10f0a40c16
commit 78d55b703d
No known key found for this signature in database
GPG key ID: 090B11993D9AEBB5
2 changed files with 39 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
guix/profiles.scm
View file

@ -110,6 +110,7 @@ (define-module (guix profiles)
ca-certificate-bundle
%default-profile-hooks
profile-derivation
profile-search-paths
generation-number
generation-numbers
@ -1400,6 +1401,19 @@ (define search-paths
;; to have no substitute to offer.
#:substitutable? #f)))
(define* (profile-search-paths profile
#:optional (manifest (profile-manifest profile))
#:key (getenv (const #f)))
"Read the manifest of PROFILE and evaluate the values of search path
environment variables required by PROFILE; return a list of
specification/value pairs. If MANIFEST is not #f, it is assumed to be the
manifest of PROFILE, which avoids rereading it.
Use GETENV to determine the current settings and report only settings not
already effective."
(evaluate-search-paths (manifest-search-paths manifest)
(list profile) getenv))
(define (profile-regexp profile)
"Return a regular expression that matches PROFILE's name and number."
(make-regexp (string-append "^" (regexp-quote (basename profile))

54
guix/scripts/environment.scm
View file

@ -49,11 +49,6 @@ (define-module (guix scripts environment)
#:use-module (srfi srfi-98)
#:export (guix-environment))
(define (evaluate-profile-search-paths profile search-paths)
"Evaluate SEARCH-PATHS, a list of search-path specifications, for the
directories in PROFILE, the store path of a profile."
(evaluate-search-paths search-paths (list profile)))
;; Protect some env vars from purification. Borrowed from nix-shell.
(define %precious-variables
'("HOME" "USER" "LOGNAME" "DISPLAY" "TERM" "TZ" "PAGER"))
@ -70,8 +65,8 @@ (define (purify-environment)
(((names . _) ...)
names)))))
(define (create-environment profile paths pure?)
"Set the environment variables specified by PATHS for PROFILE. When PURE?
(define* (create-environment profile manifest #:key pure?)
"Set the environment variables specified by MANIFEST for PROFILE. When PURE?
is #t, unset the variables in the current environment. Otherwise, augment
existing environment variables with additional search paths."
(when pure? (purify-environment))
@ -84,23 +79,23 @@ (define (create-environment profile paths pure?)
(string-append value separator current)
value)
value)))))
(evaluate-profile-search-paths profile paths))
(profile-search-paths profile manifest))
;; Give users a way to know that they're in 'guix environment', so they can
;; adjust 'PS1' accordingly, for instance. Set it to PROFILE so users can
;; conveniently access its contents.
(setenv "GUIX_ENVIRONMENT" profile))
(define (show-search-paths profile search-paths pure?)
"Display SEARCH-PATHS applied to PROFILE. When PURE? is #t, do not augment
existing environment variables with additional search paths."
(define* (show-search-paths profile manifest #:key pure?)
"Display the search paths of MANIFEST applied to PROFILE. When PURE? is #t,
do not augment existing environment variables with additional search paths."
(for-each (match-lambda
((search-path . value)
(display
(search-path-definition search-path value
#:kind (if pure? 'exact 'prefix)))
(newline)))
(evaluate-profile-search-paths profile search-paths)))
(profile-search-paths profile manifest)))
(define (input->manifest-entry input)
"Return a manifest entry for INPUT, or #f if INPUT does not correspond to a
@ -379,32 +374,34 @@ (define (status->exit-code status)
(define exit/status (compose exit status->exit-code))
(define primitive-exit/status (compose primitive-exit status->exit-code))
(define (launch-environment command inputs paths pure?)
(define* (launch-environment command profile manifest
#:key pure?)
"Run COMMAND in a new environment containing INPUTS, using the native search
paths defined by the list PATHS. When PURE?, pre-existing environment
variables are cleared before setting the new ones."
;; Properly handle SIGINT, so pressing C-c in an interactive terminal
;; application works.
(sigaction SIGINT SIG_DFL)
(create-environment inputs paths pure?)
(create-environment profile manifest #:pure? pure?)
(match command
((program . args)
(apply execlp program program args))))
(define (launch-environment/fork command inputs paths pure?)
"Run COMMAND in a new process with an environment containing INPUTS, using
the native search paths defined by the list PATHS. When PURE?, pre-existing
environment variables are cleared before setting the new ones."
(define* (launch-environment/fork command profile manifest #:key pure?)
"Run COMMAND in a new process with an environment containing PROFILE, with
the search paths specified by MANIFEST. When PURE?, pre-existing environment
variables are cleared before setting the new ones."
(match (primitive-fork)
(0 (launch-environment command inputs paths pure?))
(0 (launch-environment command profile manifest
#:pure? pure?))
(pid (match (waitpid pid)
((_ . status) status)))))
(define* (launch-environment/container #:key command bash user user-mappings
profile paths link-profile? network?)
profile manifest link-profile? network?)
"Run COMMAND within a container that features the software in PROFILE.
Environment variables are set according to PATHS, a list of native search
paths. The global shell is BASH, a file name for a GNU Bash binary in the
Environment variables are set according to the search paths of MANIFEST.
The global shell is BASH, a file name for a GNU Bash binary in the
store. When NETWORK?, access to the host system network is permitted.
USER-MAPPINGS, a list of file system mappings, contains the user-specified
host file systems to mount inside the container. If USER is not #f, each
@ -496,7 +493,7 @@ (define* (launch-environment/container #:key command bash user user-mappings
(primitive-exit/status
;; A container's environment is already purified, so no need to
;; request it be purified again.
(launch-environment command profile paths #f)))
(launch-environment command profile manifest #:pure? #f)))
#:namespaces (if network?
(delq 'net %namespaces) ; share host network
%namespaces)))))))
@ -654,8 +651,7 @@ (define (guix-environment . args)
'("/bin/sh")
(list %default-shell))))
(manifest (options/resolve-packages opts))
(mappings (pick-all opts 'file-system-mapping))
(paths (manifest-search-paths manifest)))
(mappings (pick-all opts 'file-system-mapping)))
(when container? (assert-container-features))
@ -700,7 +696,7 @@ (define (guix-environment . args)
((assoc-ref opts 'dry-run?)
(return #t))
((assoc-ref opts 'search-paths)
(show-search-paths profile paths pure?)
(show-search-paths profile manifest #:pure? pure?)
(return #t))
(container?
(let ((bash-binary
@ -713,11 +709,11 @@ (define (guix-environment . args)
#:user user
#:user-mappings mappings
#:profile profile
#:paths paths
#:manifest manifest
#:link-profile? link-prof?
#:network? network?)))
(else
(return
(exit/status
(launch-environment/fork command profile
paths pure?)))))))))))))
(launch-environment/fork command profile manifest
#:pure? pure?)))))))))))))