TakeV
/
guix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

channels: Warn about missing introductions. 

* guix/channels.scm (latest-channel-instance): Warn when CHANNEL has no
introduction and CHECKOUT contains '.guix-authorizations'.
This commit is contained in:
Ludovic Courtès 2022-10-04 09:28:01 +02:00
parent ae1af5d787
commit 5bc4b8e8e3
No known key found for this signature in database
GPG Key ID: 090B11993D9AEBB5
1 changed files with 19 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
guix/channels.scm
View File

@ -419,19 +419,28 @@ their relation. When AUTHENTICATE? is false, CHANNEL is not authenticated."
(if authenticate?
(if (channel-introduction channel)
(authenticate-channel channel checkout commit)
;; TODO: Warn for all the channels once the authentication interface
;; is public.
(when (guix-channel? channel)
(raise (make-compound-condition
(formatted-message (G_ "channel '~a' lacks an \
(begin
(when (file-exists?
(string-append checkout "/.guix-authorizations"))
(warning (and=> (channel-location channel)
source-properties->location)
(G_ "channel '~a' lacks 'introduction' field but \
'.guix-authorizations' found\n")
(channel-name channel)))
;; TODO: Warn for all the channels once the authentication interface
;; is public.
(when (guix-channel? channel)
(raise (make-compound-condition
(formatted-message (G_ "channel '~a' lacks an \
introduction and cannot be authenticated~%")
(channel-name channel))
(condition
(&fix-hint
(hint (G_ "Add the missing introduction to your
(channel-name channel))
(condition
(&fix-hint
(hint (G_ "Add the missing introduction to your
channels file to address the issue. Alternatively, you can pass
@option{--disable-authentication}, at the risk of running unauthenticated and
thus potentially malicious code."))))))))
thus potentially malicious code.")))))))))
(warning (G_ "channel authentication disabled~%")))
(when (guix-channel? channel)