TakeV
/
guix
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

* Actually check that the result of fixed-output derivations matches 

the specified hash.
This commit is contained in:
Eelco Dolstra 2005-01-17 19:01:48 +00:00
parent f3dc231250
commit 32aac8748a
1 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/libstore/normalise.cc
View File

@ -1088,6 +1088,31 @@ void NormalisationGoal::createClosure()
}
nf.closure.roots.insert(path);
/* Check that fixed-output derivations produced the right
outputs (i.e., the content hash should match the specified
hash). */
if (i->second.hash != "") {
HashType ht = parseHashType(i->second.hashAlgo);
if (ht == htUnknown)
throw Error(format("unknown hash algorithm `%1%'") % i->second.hashAlgo);
Hash h = parseHash(ht, i->second.hash);
Hash h2 = hashFile(ht, path);
if (h != h2)
throw Error(
format("output path `%1% should have %2% hash `%3%', instead has `%4%'")
% path % i->second.hashAlgo % printHash(h) % printHash(h2));
/* Also, the output path should be a regular file withouth
execute permission. */
struct stat st;
if (lstat(path.c_str(), &st))
throw SysError(format("getting attributes of path `%1%'") % path);
if (!S_ISREG(st.st_mode) || (st.st_mode & S_IXUSR) != 0)
throw Error(
format("output path `%1% should be a non-executable regular file")
% path);
}
canonicalisePathMetaData(path);
/* For this output path, find the references to other paths contained