diff --git a/src/libexpr/eval.cc b/src/libexpr/eval.cc index 5aee3f05ea..d0bdaf2382 100644 --- a/src/libexpr/eval.cc +++ b/src/libexpr/eval.cc @@ -431,17 +431,19 @@ Value * EvalState::maybeThunk(Env & env, Expr * expr) void EvalState::evalFile(const Path & path, Value & v) { - startNest(nest, lvlTalkative, format("evaluating file `%1%'") % path); - - Expr * e = parseExprFromFile(path); - - try { - /* !!! Maybe we should cache the evaluation result. */ - eval(e, v); - } catch (Error & e) { - addErrorPrefix(e, "while evaluating the file `%1%':\n", path); - throw; - } + FileEvalCache::iterator i = fileEvalCache.find(path); + if (i == fileEvalCache.end()) { + startNest(nest, lvlTalkative, format("evaluating file `%1%'") % path); + Expr * e = parseExprFromFile(path); + try { + eval(e, v); + } catch (Error & e) { + addErrorPrefix(e, "while evaluating the file `%1%':\n", path); + throw; + } + fileEvalCache[path] = v; + } else + v = i->second; } diff --git a/src/libexpr/eval.hh b/src/libexpr/eval.hh index 413234f2bf..694d4407b8 100644 --- a/src/libexpr/eval.hh +++ b/src/libexpr/eval.hh @@ -211,8 +211,17 @@ private: bool allowUnsafeEquality; + /* A cache from path names to parse trees. */ std::map parseTrees; + /* A cache from path names to values. */ +#if HAVE_BOEHMGC + typedef std::map, gc_allocator > > FileEvalCache; +#else + typedef std::map FileEvalCache; +#endif + FileEvalCache fileEvalCache; + typedef list > SearchPath; SearchPath searchPath; SearchPath::iterator searchPathInsertionPoint;