This repository has been archived on 2024-01-04. You can view files and clone it, but cannot push or open issues or pull requests.
forgejo/models/issues
Jason Song 477a1cc40e
Improve utils of slices (#22379)
- Move the file `compare.go` and `slice.go` to `slice.go`.
- Fix `ExistsInSlice`, it's buggy
  - It uses `sort.Search`, so it assumes that the input slice is sorted.
- It passes `func(i int) bool { return slice[i] == target })` to
`sort.Search`, that's incorrect, check the doc of `sort.Search`.
- Conbine `IsInt64InSlice(int64, []int64)` and `ExistsInSlice(string,
[]string)` to `SliceContains[T]([]T, T)`.
- Conbine `IsSliceInt64Eq([]int64, []int64)` and `IsEqualSlice([]string,
[]string)` to `SliceSortedEqual[T]([]T, T)`.
- Add `SliceEqual[T]([]T, T)` as a distinction from
`SliceSortedEqual[T]([]T, T)`.
- Redesign `RemoveIDFromList([]int64, int64) ([]int64, bool)` to
`SliceRemoveAll[T]([]T, T) []T`.
- Add `SliceContainsFunc[T]([]T, func(T) bool)` and
`SliceRemoveAllFunc[T]([]T, func(T) bool)` for general use.
- Add comments to explain why not `golang.org/x/exp/slices`.
- Add unit tests.
2023-01-11 13:31:16 +08:00
..
assignees.go Improve utils of slices (#22379) 2023-01-11 13:31:16 +08:00
assignees_test.go
comment.go
comment_list.go
comment_test.go
content_history.go
content_history_test.go
dependency.go
dependency_test.go
issue.go Improve utils of slices (#22379) 2023-01-11 13:31:16 +08:00
issue_index.go
issue_list.go
issue_list_test.go
issue_lock.go
issue_project.go
issue_test.go
issue_user.go
issue_user_test.go
issue_watch.go
issue_watch_test.go
issue_xref.go
issue_xref_test.go
label.go
label_test.go
main_test.go
milestone.go
milestone_test.go
pull.go
pull_list.go
pull_test.go
reaction.go
reaction_test.go
review.go
review_test.go
stopwatch.go
stopwatch_test.go
tracked_time.go
tracked_time_test.go