TakeV/forgejo
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
This repository has been archived on 2024-01-04. You can view files and clone it, but cannot push or open issues or pull requests.
forgejo/templates/repo/diff
History
wxiaoguang 1fcf96ad01
Improve PR Review Box UI (#22986) 
This PR follows: 
* #22950

### Before

The Review Box has many problems:

* It doesn't work for small screens.
* It has an anonying animation which makes the UI laggy.
* It uses "custom dropdown menu" which is very difficult to fine tune.
* `$().toggle('visible')` is not a correct call 
* jQuery just accepts any invalid `duration` argument:
`$().toggle('anyting')`
* The button is not a button.

<details>

![image](https://user-images.githubusercontent.com/2114189/219948865-6da3f39c-6fde-4c86-9e42-da5020f3d0c3.png)

</details>

### After

These problems are fixed, and eliminate many `!important` games.

<details>

![image](https://user-images.githubusercontent.com/2114189/219952744-8862fe1a-7ef1-49e4-bf92-2d0c1f104ee4.png)

![image](https://user-images.githubusercontent.com/2114189/219952771-be169a76-45fd-47a8-8f9c-b447d064f4ca.png)

![image](https://user-images.githubusercontent.com/2114189/219952784-3f52e9b7-64ce-4ad1-9553-64c33fb83042.png)

</details>

And most dropdown icons still looks good:

<details>

![image](https://user-images.githubusercontent.com/2114189/219952942-52866a00-e0f9-4af7-8fb5-eb1a8cad1ff3.png)

![image](https://user-images.githubusercontent.com/2114189/219948909-b3bfb844-f84e-4b79-ab1f-382ec66dec31.png)

</details>

Co-authored-by: delvh <leon@kske.dev>
2023-02-21 21:36:53 +08:00
..
blob_excerpt.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
box.tmpl Improve PR Review Box UI (#22986) 2023-02-21 21:36:53 +08:00
comment_form.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
comment_form_datahandler.tmpl
comments.tmpl Fix broken pull request files (#22962) 2023-02-20 09:57:16 +08:00
compare.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
conversation.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
csv_diff.tmpl
escape_title.tmpl
image_diff.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
new_comment.tmpl
new_review.tmpl Improve PR Review Box UI (#22986) 2023-02-21 21:36:53 +08:00
options_dropdown.tmpl
section_code.tmpl
section_split.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
section_unified.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
stats.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
whitespace_dropdown.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00