This repository has been archived on 2024-01-04. You can view files and clone it, but cannot push or open issues or pull requests.
forgejo/cmd
mrsdizzie ca46385637 Clean up various use of escape/unescape functions for URL generation (#6334)
* Use PathUnescape instead of QueryUnescape when working with branch names

Currently branch names with a '+' fail in certain situations because
QueryUnescape replaces the + character with a blank space.

Using PathUnescape should be better since it is defined as:

// PathUnescape is identical to QueryUnescape except that it does not
// unescape '+' to ' ' (space).

Fixes #6333

* Change error to match new function name

* Add new util function PathEscapeSegments

This function simply runs PathEscape on each segment of a path without
touching the forward slash itself. We want to use this instead of
PathEscape/QueryEscape in most cases because a forward slash is a valid name for a
branch etc... and we don't want that escaped in a URL.

Putting this in new file url.go and also moving a couple similar
functions into that file as well.

* Use EscapePathSegments where appropriate

Replace various uses of EscapePath/EscapeQuery with new
EscapePathSegments. Also remove uncessary uses of various
escape/unescape functions when the text had already been escaped or was
not escaped.

* Reformat comment to make drone build happy

* Remove no longer used url library

* Requested code changes
2019-03-18 10:00:23 -04:00
..
admin.go Allow for user specific themes (#5668) 2019-01-09 12:22:57 -05:00
cert.go General refactor of the cmd package (#3328) 2018-01-12 23:16:49 +01:00
cmd.go Disallow empty titles (#5785) 2019-01-21 13:45:32 +02:00
dump.go Add flag to skip repository dumping (#5695) 2019-01-13 16:52:25 -05:00
generate.go Integrate OAuth2 Provider (#5378) 2019-03-08 11:42:50 -05:00
hook.go Clean up various use of escape/unescape functions for URL generation (#6334) 2019-03-18 10:00:23 -04:00
keys.go Create AuthorizedKeysCommand (#5236) 2018-11-01 09:41:07 -04:00
migrate.go Add command for migrating database (#4954) 2018-10-30 23:14:42 -04:00
serv.go Fix ssh deploy and user key constraints (#1357) (#5939) 2019-02-03 23:56:53 +00:00
web.go Remove a double slash in the HTTPS redirection when Let's Encrypt is enabled (#5537) 2018-12-12 23:00:24 +02:00
web_graceful.go refactor: show command help message. (#1486) 2017-04-12 15:44:54 +08:00
web_windows.go fix windows build broken by #416 2016-12-31 17:16:02 +08:00