This repository has been archived on 2024-01-04. You can view files and clone it, but cannot push or open issues or pull requests.
forgejo/models/asymkey
zeripath 716fcfcf72
Make every not exist error unwrappable to a fs.ErrNotExist (#20891)
A lot of our code is repeatedly testing if individual errors are
specific types of Not Exist errors. This is repetitative and unnecesary.
`Unwrap() error` provides a common way of labelling an error as a
NotExist error and we can/should use this.

This PR has chosen to use the common `io/fs` errors e.g.
`fs.ErrNotExist` for our errors. This is in some ways not completely
correct as these are not filesystem errors but it seems like a
reasonable thing to do and would allow us to simplify a lot of our code
to `errors.Is(err, fs.ErrNotExist)` instead of
`package.IsErr...NotExist(err)`

I am open to suggestions to use a different base error - perhaps
`models/db.ErrNotExist` if that would be felt to be better.


Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: delvh <dev.lh@web.de>
2022-10-18 07:50:37 +02:00
..
error.go Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
gpg_key.go Increase Content field size of gpg_key and public_key to MEDIUMTEXT (#20896) 2022-08-22 14:32:28 +01:00
gpg_key_add.go Move almost all functions' parameter db.Engine to context.Context (#19748) 2022-05-20 22:08:52 +08:00
gpg_key_commit_verification.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
gpg_key_common.go
gpg_key_import.go
gpg_key_test.go Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
gpg_key_verify.go
main_test.go Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
ssh_key.go Increase Content field size of gpg_key and public_key to MEDIUMTEXT (#20896) 2022-08-22 14:32:28 +01:00
ssh_key_authorized_keys.go Move almost all functions' parameter db.Engine to context.Context (#19748) 2022-05-20 22:08:52 +08:00
ssh_key_authorized_principals.go Move almost all functions' parameter db.Engine to context.Context (#19748) 2022-05-20 22:08:52 +08:00
ssh_key_commit_verification.go
ssh_key_deploy.go Move some repository related code into sub package (#19711) 2022-06-06 16:01:49 +08:00
ssh_key_fingerprint.go Fix order by parameter (#19849) 2022-06-04 20:18:50 +01:00
ssh_key_parse.go Fix various typos (#18219) 2022-01-10 17:32:37 +08:00
ssh_key_principals.go Move almost all functions' parameter db.Engine to context.Context (#19748) 2022-05-20 22:08:52 +08:00
ssh_key_test.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
ssh_key_verify.go Migration 204 use Sync2 (#18044) 2021-12-20 18:58:38 +01:00