This repository has been archived on 2024-01-04. You can view files and clone it, but cannot push or open issues or pull requests.
forgejo/templates
Yarden Shoham 5ddf67a9c2
Make issue meta dropdown support Enter, confirm before reloading (#23014) (#23102)
Backport #23014

As the title. Label/assignee share the same code.

* Close #22607
* Close #20727

Also:

* partially fix for #21742, now the comment reaction and menu work with
keyboard.
* partially fix for #17705, in most cases the comment won't be lost.
* partially fix for #21539
* partially fix for #20347
* partially fix for #7329

### The `Enter` support

Before, if user presses Enter, the dropdown just disappears and nothing
happens or the window reloads.

After, Enter can be used to select/deselect labels, and press Esc to
hide the dropdown to update the labels (still no way to cancel ....
maybe you can do a Cmd+R or F5 to refresh the window to discard the
changes .....)


This is only a quick patch, the UX is still not perfect, but it's much
better than before.


### The `confirm` before reloading

And more fixes for the `reload` problem, the new behaviors:

* If nothing changes (just show/hide the dropdown), then the page won't
be reloaded.
* If there are draft comments, show a confirm dialog before reloading,
to avoid losing comments.

That's the best effect can be done at the moment, unless completely
refactor these dropdown related code.

Screenshot of the confirm dialog:

<details>


![image](https://user-images.githubusercontent.com/2114189/220538288-e2da8459-6a4e-43cb-8596-74057f8a03a2.png)

</details>

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Brecht Van Lommel <brecht@blender.org>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-02-24 17:40:36 +08:00
..
admin Fix some more hidden problems (#23074) (#23075) 2023-02-22 15:26:48 +00:00
api/packages/pypi
base Add accessibility to the menu on the navbar (#23059) (#23095) 2023-02-23 20:56:03 +08:00
code Remove Fomantic-UI's `.hidden` CSS class for menu elements (#22895) 2023-02-14 19:53:54 +08:00
custom
explore Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
mail
org Hide 2FA status from other members in organization members list (#22999) 2023-02-20 17:16:29 -06:00
package Introduce customized HTML elements, fix incorrect AppUrl usages in templates (#22861) 2023-02-17 22:02:20 +08:00
projects Scoped labels (#22585) 2023-02-18 21:17:39 +02:00
repo Make issue meta dropdown support Enter, confirm before reloading (#23014) (#23102) 2023-02-24 17:40:36 +08:00
shared Fix no user listed in org teams page (#22979) 2023-02-19 12:57:49 +08:00
status
swagger Add scopes to API to create token and display them (#22989) 2023-02-20 15:28:44 -06:00
user Add scopes to API to create token and display them (#22989) 2023-02-20 15:28:44 -06:00
home.tmpl
install.tmpl Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
post-install.tmpl Introduce customized HTML elements, fix incorrect AppUrl usages in templates (#22861) 2023-02-17 22:02:20 +08:00