TakeV/forgejo
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
This repository has been archived on 2024-01-04. You can view files and clone it, but cannot push or open issues or pull requests.
forgejo/services/webhook
History
qwerty287 9d943bf374
Add missing X-Total-Count and fix some related bugs (#17968) 
* Add missing `X-Total-Count` and fix some related bugs

Adds `X-Total-Count` header to APIs that return a list but doesn't have it yet.
Fixed bugs:
* not returned after reporting error (39eb82446c/routers/api/v1/user/star.go (L70))
* crash with index out of bounds, API issue/issueSubscriptions

I also found various endpoints that return lists but do not apply/support pagination yet:
```
/repos/{owner}/{repo}/issues/{index}/labels
/repos/{owner}/{repo}/issues/comments/{id}/reactions
/repos/{owner}/{repo}/branch_protections
/repos/{owner}/{repo}/contents
/repos/{owner}/{repo}/hooks/git
/repos/{owner}/{repo}/issue_templates
/repos/{owner}/{repo}/releases/{id}/assets
/repos/{owner}/{repo}/reviewers
/repos/{owner}/{repo}/teams
/user/emails
/users/{username}/heatmap
```
If this is not expected, an new issue should be opened.

Closes #13043

* fmt

* Update routers/api/v1/repo/issue_subscription.go

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

* Use FindAndCount

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
2021-12-15 13:39:34 +08:00
..
deliver.go Use hostmatcher to replace matchlist, improve security (#17605) 2021-11-20 17:34:05 +08:00
deliver_test.go A better go code formatter, and now make fmt can run in Windows (#17684) 2021-11-17 20:34:35 +08:00
dingtalk.go Multiple Escaping Improvements (#17551) 2021-11-16 18:18:25 +00:00
dingtalk_test.go Move webhook into models/webhook/ (#17579) 2021-11-10 13:13:16 +08:00
discord.go Multiple Escaping Improvements (#17551) 2021-11-16 18:18:25 +00:00
discord_test.go Move webhook into models/webhook/ (#17579) 2021-11-10 13:13:16 +08:00
feishu.go Move webhook into models/webhook/ (#17579) 2021-11-10 13:13:16 +08:00
feishu_test.go Move webhook into models/webhook/ (#17579) 2021-11-10 13:13:16 +08:00
general.go Multiple Escaping Improvements (#17551) 2021-11-16 18:18:25 +00:00
general_test.go Add tests for all webhooks (#16214) 2021-06-20 22:12:19 -04:00
main_test.go Add missing X-Total-Count and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
matrix.go Multiple Escaping Improvements (#17551) 2021-11-16 18:18:25 +00:00
matrix_test.go Move webhook into models/webhook/ (#17579) 2021-11-10 13:13:16 +08:00
msteams.go Multiple Escaping Improvements (#17551) 2021-11-16 18:18:25 +00:00
msteams_test.go Move webhook into models/webhook/ (#17579) 2021-11-10 13:13:16 +08:00
payloader.go Move webhook into models/webhook/ (#17579) 2021-11-10 13:13:16 +08:00
slack.go Move webhook into models/webhook/ (#17579) 2021-11-10 13:13:16 +08:00
slack_test.go Move webhook into models/webhook/ (#17579) 2021-11-10 13:13:16 +08:00
telegram.go Move webhook into models/webhook/ (#17579) 2021-11-10 13:13:16 +08:00
telegram_test.go Move webhook into models/webhook/ (#17579) 2021-11-10 13:13:16 +08:00
webhook.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
webhook_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
wechatwork.go Move webhook into models/webhook/ (#17579) 2021-11-10 13:13:16 +08:00