This repository has been archived on 2024-01-04. You can view files and clone it, but cannot push or open issues or pull requests.

sillyguodong 3dc2724d36 Fix cannot reopen after pushing commits to a closed PR (#23189) (#23322) ... Backport: #23189 Close: #22784 1. On GH, we can reopen a PR which was closed before after pushing commits. After reopening PR, we can see the commits that were pushed after closing PR in the time line. So the case of [issue](https://github.com/go-gitea/gitea/issues/22784) is a bug which needs to be fixed. 2. After closing a PR and pushing commits, `headBranchSha` is not equal to `sha`(which is the last commit ID string of reference). If the judgement exists, the button of reopen will not display. So, skip the judgement if the status of PR is closed.  3. Even if PR is already close, we should still insert comment record into DB when we push commits. So we should still call function `CreatePushPullComment()`. 067b0c2664/services/pull/pull.go (L260-L282) So, I add a switch(`includeClosed`) to the `GetUnmergedPullRequestsByHeadInfo` func to control whether the status of PR must be open. In this case, by setting `includeClosed` to `true`, we can query the closed PR.  4. In the loop of comments, I use the`latestCloseCommentID` variable to record the last occurrence of the close comment. In the go template, if the status of PR is closed, the comments whose type is `CommentTypePullRequestPush(29)` after `latestCloseCommentID` won't be rendered.  e.g. 1). The initial status of the PR is opened.  2). Then I click the button of `Close`. PR is closed now.  3). I try to push a commit to this PR, even though its current status is closed.  But in comments list, this commit do not display.This is as expected ：）  4). Click the `Reopen` button, the commit which is pushed after closing PR display now. 		2023-03-06 11:38:45 -06:00
..
assignees.go	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2022-10-24 20:29:17 +01:00
assignees_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797)	2022-08-16 10:22:25 +08:00
comment.go	some refactor about code comments(#20821) (#22707)	2023-02-16 21:21:25 +08:00
comment_code.go	some refactor about code comments(#20821) (#22707)	2023-02-16 21:21:25 +08:00
comment_list.go	Add generic set type (#21408)	2022-10-12 13:18:26 +08:00
comment_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797)	2022-08-16 10:22:25 +08:00
content_history.go	Make every not exist error unwrappable to a fs.ErrNotExist (#20891)	2022-10-18 07:50:37 +02:00
content_history_test.go	Move issues related files into models/issues (#19931)	2022-06-13 17:37:59 +08:00
dependency.go	Make every not exist error unwrappable to a fs.ErrNotExist (#20891)	2022-10-18 07:50:37 +02:00
dependency_test.go	Move issues related files into models/issues (#19931)	2022-06-13 17:37:59 +08:00
issue.go	fix incorrect role labels for migrated issues and comments (#22914) (#22923)	2023-02-16 11:19:46 +08:00
issue_index.go	Refactor GetNextResourceIndex to make it work properly with transaction (#21469)	2022-10-16 18:44:16 +08:00
issue_list.go	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2022-10-24 20:29:17 +01:00
issue_list_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797)	2022-08-16 10:22:25 +08:00
issue_lock.go	Move issues related files into models/issues (#19931)	2022-06-13 17:37:59 +08:00
issue_project.go	Fix missed sort bug (#20996)	2022-08-31 14:15:12 -04:00
issue_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797)	2022-08-16 10:22:25 +08:00
issue_user.go	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2022-10-24 20:29:17 +01:00
issue_user_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797)	2022-08-16 10:22:25 +08:00
issue_watch.go	Add more linters to improve code readability (#19989)	2022-06-20 12:02:49 +02:00
issue_watch_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797)	2022-08-16 10:22:25 +08:00
issue_xref.go	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2022-10-24 20:29:17 +01:00
issue_xref_test.go	Refactor GetNextResourceIndex to make it work properly with transaction (#21469)	2022-10-16 18:44:16 +08:00
label.go	Fix DBConsistency checks on MSSQL (#23132) (#23133)	2023-02-25 21:17:14 +02:00
label_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797)	2022-08-16 10:22:25 +08:00
main_test.go	Move tests as seperate sub packages to reduce duplicated file names (#19951)	2022-06-15 09:02:00 +02:00
milestone.go	Make every not exist error unwrappable to a fs.ErrNotExist (#20891)	2022-10-18 07:50:37 +02:00
milestone_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797)	2022-08-16 10:22:25 +08:00
pull.go	Improve trace logging for pulls and processes (#22633) (#22812)	2023-02-13 11:17:36 +08:00
pull_list.go	Fix cannot reopen after pushing commits to a closed PR (#23189) (#23322)	2023-03-06 11:38:45 -06:00
pull_test.go	Fix cannot reopen after pushing commits to a closed PR (#23189) (#23322)	2023-03-06 11:38:45 -06:00
reaction.go	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2022-10-24 20:29:17 +01:00
reaction_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797)	2022-08-16 10:22:25 +08:00
review.go	some refactor about code comments(#20821) (#22707)	2023-02-16 21:21:25 +08:00
review_test.go	Restore previous official review when an official review is deleted (#22449) (#22460)	2023-01-15 20:47:54 +01:00
stopwatch.go	Make every not exist error unwrappable to a fs.ErrNotExist (#20891)	2022-10-18 07:50:37 +02:00
stopwatch_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797)	2022-08-16 10:22:25 +08:00
tracked_time.go	Use GhostUser if needed for TrackedTimes (#22021) (#22029)	2022-12-05 14:20:37 +02:00
tracked_time_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797)	2022-08-16 10:22:25 +08:00