This repository has been archived on 2024-01-04. You can view files and clone it, but cannot push or open issues or pull requests.
forgejo/services/pull
zeripath 3d8b5ad5f3
Fix a couple of CommentAsPatch issues. (#14804)
* CutDiffAroundLine makes the incorrect assumption that `---` and `+++` always represent part of the header of a diff.

This PR adds a flag to its parsing to prevent this problem and adds a streaming parsing technique to CutDiffAroundLine using an io.pipe instead of just sending data to an unbounded buffer.

Fix #14711

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Handle unquoted comment patch files

When making comment patches unfortunately the patch does not always quote the filename
This makes the diff --git header ambiguous again.

This PR finally adds handling for ambiguity in to parse patch

Fix #14812

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Add in testing for no error

There is no way currently for CutDiffAroundLine in this test to cause an
error however, it should still be tested.

Signed-off-by: Andrew Thornton <art27@cantab.net>
2021-02-27 19:46:14 +01:00
..
check.go migrate from com.* to alternatives (#14103) 2020-12-25 11:59:32 +02:00
check_test.go migrate from com.* to alternatives (#14103) 2020-12-25 11:59:32 +02:00
commit_status.go
lfs.go
main_test.go
merge.go
patch.go
pull.go [API] Add pagination to ListBranches (#14524) 2021-02-03 20:06:13 +01:00
pull_test.go
review.go Fix a couple of CommentAsPatch issues. (#14804) 2021-02-27 19:46:14 +01:00
temp_repo.go
update.go