This repository has been archived on 2024-01-04. You can view files and clone it, but cannot push or open issues or pull requests.
forgejo/models/issues
Lunny Xiao c53ad052d8
Refactor the setting to make unit test easier (#22405)
Some bugs caused by less unit tests in fundamental packages. This PR
refactor `setting` package so that create a unit test will be easier
than before.

- All `LoadFromXXX` files has been splited as two functions, one is
`InitProviderFromXXX` and `LoadCommonSettings`. The first functions will
only include the code to create or new a ini file. The second function
will load common settings.
- It also renames all functions in setting from `newXXXService` to
`loadXXXSetting` or `loadXXXFrom` to make the function name less
confusing.
- Move `XORMLog` to `SQLLog` because it's a better name for that.

Maybe we should finally move these `loadXXXSetting` into the `XXXInit`
function? Any idea?

---------

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: delvh <dev.lh@web.de>
2023-02-20 00:12:01 +08:00
..
assignees.go Improve utils of slices (#22379) 2023-01-11 13:31:16 +08:00
assignees_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
comment.go Rename repo.GetOwner to repo.LoadOwner (#22967) 2023-02-18 20:11:03 +08:00
comment_code.go some refactor about code comments (#20821) 2023-01-17 15:03:44 -06:00
comment_list.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
comment_test.go Support importing comment types (#22510) 2023-01-18 21:14:56 -05:00
content_history.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
content_history_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
dependency.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
dependency_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
issue.go Scoped labels (#22585) 2023-02-18 21:17:39 +02:00
issue_index.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_list.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
issue_list_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_lock.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
issue_project.go Support org/user level projects (#22235) 2023-01-20 19:42:33 +08:00
issue_test.go Scoped labels (#22585) 2023-02-18 21:17:39 +02:00
issue_user.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_user_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_watch.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_watch_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_xref.go Fix more HTMLURL in templates (#22831) 2023-02-09 11:31:30 -05:00
issue_xref_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
label.go Scoped labels (#22585) 2023-02-18 21:17:39 +02:00
label_test.go Scoped labels (#22585) 2023-02-18 21:17:39 +02:00
main_test.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
milestone.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
milestone_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
pull.go Rename repo.GetOwner to repo.LoadOwner (#22967) 2023-02-18 20:11:03 +08:00
pull_list.go Set PR for issue when load attributes for PRs (#22766) 2023-02-05 08:24:43 -06:00
pull_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
reaction.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
reaction_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
review.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
review_test.go Restore previous official review when an official review is deleted (#22449) 2023-01-15 07:00:09 +02:00
stopwatch.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
stopwatch_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
tracked_time.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
tracked_time_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00