affdd40296
Replace #19922 , which is stale since my last review: https://github.com/go-gitea/gitea/pull/19922#pullrequestreview-1003546506 and https://github.com/go-gitea/gitea/pull/19922#issuecomment-1153181546 Close #19769 Changes: 1. Use `<button>` instead of `<div>` for buttons 2. Prevent default event handler in `initGlobalButtonClickOnEnter` 3. Fix the incorrect call to `pullrequest_targetbranch_change` 4. Add a slight margin-left to the input element to make UI look better The logic in repo-issue.js is not ideal, but this PR isn't going to touch the logic. This is also an example for future developers to understand how to make buttons work properly. ### Before ![image](https://user-images.githubusercontent.com/2114189/217262515-ec0462f7-7051-46a5-bfa2-2f6c6a807b7d.png) ### After * Add a slight margin-left. * The `Cancel` button is focused. ![image](https://user-images.githubusercontent.com/2114189/217264891-934c9c8d-d190-4866-98b5-666cea57e28d.png) Co-authored-by: techknowlogick <techknowlogick@gitea.io> |
||
---|---|---|
.. | ||
admin | ||
comp | ||
aria.js | ||
aria.md | ||
captcha.js | ||
citation.js | ||
clipboard.js | ||
codeeditor.js | ||
colorpicker.js | ||
common-global.js | ||
common-issue.js | ||
common-organization.js | ||
contextpopup.js | ||
copycontent.js | ||
dropzone.js | ||
emoji.js | ||
eventsource.sharedworker.js | ||
file-fold.js | ||
formatting.js | ||
heatmap.js | ||
imagediff.js | ||
install.js | ||
notification.js | ||
org-team.js | ||
pull-view-file.js | ||
repo-branch.js | ||
repo-code.js | ||
repo-code.test.js | ||
repo-commit.js | ||
repo-common.js | ||
repo-diff-filetree.js | ||
repo-diff.js | ||
repo-editor.js | ||
repo-findfile.js | ||
repo-findfile.test.js | ||
repo-graph.js | ||
repo-home.js | ||
repo-issue-content.js | ||
repo-issue-pr-form.js | ||
repo-issue.js | ||
repo-legacy.js | ||
repo-migrate.js | ||
repo-migration.js | ||
repo-projects.js | ||
repo-release.js | ||
repo-settings.js | ||
repo-template.js | ||
repo-unicode-escape.js | ||
repo-wiki.js | ||
serviceworker.js | ||
sshkey-helper.js | ||
stopwatch.js | ||
tablesort.js | ||
tribute.js | ||
user-auth-webauthn.js | ||
user-auth.js | ||
user-settings.js |