dxx-rebirth/similar
Kp ffb4240710 Report failure when a mission is not found in the mission list
AlumiuN reported a crash when a save game is unable to load the
underlying mission.  The crash is because the game proceeds to load the
savegame onto whatever level was loaded before this mission, which will
usually result in fatal inconsistencies in the data.

This commit does not fix the cause of the inability to load the mission,
but instead fixes the logic so that the user gets a reasonable error
message advising that the mission failed to load.  This was
unintentionally broken in db80a88ad2 when the sense of the return
value was inverted, and the fallthrough case was not adjusted.  This
impacts all uses of `load_mission_by_name`, though in practice restoring
from a savegame is the most obvious way to hit the problem.

Reported-by: AlumiuN <https://github.com/dxx-rebirth/dxx-rebirth/issues/486> (indirectly)
Fixes: db80a88ad2 ("Improve error message on failure to load mission")
2020-01-06 01:25:35 +00:00
..
2d Downgrade PCX failures from Error to CON_URGENT 2019-07-07 22:00:02 +00:00
3d Use xrange for loops with zero start and simple identifier end 2019-05-04 18:27:37 +00:00
arch Call arch_close before atexit hooks begin 2020-01-06 01:25:35 +00:00
editor Use susegment for WALL_IS_DOORWAY 2019-12-27 02:02:23 +00:00
main Report failure when a mission is not found in the mission list 2020-01-06 01:25:35 +00:00
misc Fix externally reported Mac OS X build break 2019-10-23 03:02:16 +00:00