dxx-rebirth/similar/arch/sdl
Kp 9e0431b861 digi_win32_play_midi_song: write hmp_open result directly to global
Commit 3b5b69cb97 changed the logic to store the result of hmp_open
into a local that was destroyed at the end of the function.  This was
incorrect, as destruction of the returned value will immediately halt
the music.  Revert to the previous behavior, where the result is written
to the global `cur_hmp` so that it persists past the end of the
function.

Reported-by: norbert79 <https://github.com/dxx-rebirth/dxx-rebirth/issues/634>
Analyzed-by: AlumiuN <https://github.com/dxx-rebirth/dxx-rebirth/issues/634#issuecomment-1110510761>
Proposed-fix-by: AlumiuN <https://github.com/dxx-rebirth/dxx-rebirth/issues/634#issuecomment-1110510761>
Fixes: 3b5b69cb97 ("Improve error reporting for hmp_open / hmp2mid")
2022-04-28 02:19:26 +00:00
..
digi.cpp digi_win32_play_midi_song: write hmp_open result directly to global 2022-04-28 02:19:26 +00:00
digi_audio.cpp Use enum class for sound angle parameter 2021-06-28 03:37:51 +00:00
digi_mixer.cpp Avoid double-scaling sounds at start time 2021-06-28 03:37:51 +00:00
gr.cpp Fix SDL-only build 2021-11-01 03:37:20 +00:00
init.cpp Delegate PCX loading to SDL_image 2020-05-17 23:35:26 +00:00
jukebox.cpp Always check return value of PHYSFSX_getRealPath 2022-03-19 22:55:58 +00:00