TakeV/dxx-rebirth
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity
dxx-rebirth/similar/main
History
Kp c26fd86450 Keep builtin movies loaded until the end of main 
Commit d0d7545ec1 ("Unload robot movies on exit") intended to shorten
the lifetime of the loaded data, but failed to save the unique_ptr, so
the lifetime was shortened more than intended.  Save the unique_ptr so
that the movies remain loaded.

Also, add a [[nodiscard]] annotation so that the compiler can warn if
this mistake is repeated.

Reported-by: Q3BFG10K <https://github.com/dxx-rebirth/dxx-rebirth/issues/599>
Fixes: d0d7545ec1 ("Unload robot movies on exit")
2021-07-25 23:00:56 +00:00
..
ai.cpp Link robot sounds to the object, not a position 2021-06-28 03:37:51 +00:00
aipath.cpp Use structured bindings to access enumerated ranges 2021-06-28 03:37:50 +00:00
automap.cpp Remove unused subfunction_handler 2021-06-28 03:37:50 +00:00
bm.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
bmread.cpp Use structured bindings to access enumerated ranges 2021-06-28 03:37:50 +00:00
cntrlcen.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
collide.cpp Move collision functions into namespaces 2021-06-28 03:37:51 +00:00
config.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
console.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
controls.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
credits.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
digiobj.cpp Split digi_get_sound_loc 2021-06-28 03:37:51 +00:00
dumpmine.cpp Use structured bindings to access enumerated ranges 2021-06-28 03:37:50 +00:00
effects.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
endlevel.cpp Use structured bindings to access enumerated ranges 2021-06-28 03:37:50 +00:00
fireball.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
fuelcen.cpp Use structured bindings to access enumerated ranges 2021-06-28 03:37:50 +00:00
fvi.cpp Replace __attribute_warn_unused_result with C++17 [[nodiscard]] 2021-06-28 03:37:51 +00:00
game.cpp Use structured bindings to access enumerated ranges 2021-06-28 03:37:50 +00:00
gamecntl.cpp Remove unused subfunction_handler 2021-06-28 03:37:50 +00:00
gamefont.cpp Use structured bindings to access enumerated ranges 2021-06-28 03:37:50 +00:00
gamemine.cpp Override mapping of D1 secret door texture 2021-04-04 22:01:25 +00:00
gamerend.cpp Replace __attribute_warn_unused_result with C++17 [[nodiscard]] 2021-06-28 03:37:51 +00:00
gamesave.cpp Use structured bindings to access enumerated ranges 2021-06-28 03:37:50 +00:00
gameseg.cpp Use structured bindings for more zip calls 2021-06-28 03:37:51 +00:00
gameseq.cpp Reduce intensity of player spawn sound 2021-06-28 03:37:51 +00:00
gauges.cpp Replace __attribute_warn_unused_result with C++17 [[nodiscard]] 2021-06-28 03:37:51 +00:00
generate-kconfig-udlr.py Convert kconfig array lookups to require correct enumerated type 2020-07-05 23:34:33 +00:00
hostage.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
hud.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
iff.cpp Reduce uses of RAIIdmem for local variables 2021-06-28 03:37:49 +00:00
inferno.cpp Keep builtin movies loaded until the end of main 2021-07-25 23:00:56 +00:00
kconfig.cpp Clamp kconfig window size to screen size 2021-02-25 03:53:49 +00:00
kconfig.ui-table.cpp Merge 'refs/pull/516/head' into master 2020-07-09 02:47:18 +00:00
kmatrix.cpp Construct nm_item_menu in place 2021-06-28 03:37:49 +00:00
laser.cpp Reduce intensity of weapon fire sounds 2021-06-28 03:37:51 +00:00
lighting.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
menu.cpp Transpose returned values for enumerate() of non-tuple 2021-06-28 03:37:50 +00:00
mglobal.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
mission.cpp Use structured bindings to access enumerated ranges 2021-06-28 03:37:50 +00:00
morph.cpp Use structured bindings to access enumerated ranges 2021-06-28 03:37:50 +00:00
multi.cpp Use structured bindings to access enumerated ranges 2021-06-28 03:37:50 +00:00
multibot.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
net_udp.cpp Transpose returned values for enumerate() of non-tuple 2021-06-28 03:37:50 +00:00
newdemo.cpp Use enum class for sound angle parameter 2021-06-28 03:37:51 +00:00
newmenu.cpp Convert nm_messagebox_str to use messagebox_newmenu 2021-06-28 03:37:50 +00:00
object.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
paging.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
physics.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
piggy.cpp Remove write-only field digi_sound::bits 2021-06-28 03:37:49 +00:00
player.cpp Add experimental support for guidebot in multiplayer 2019-06-27 03:26:20 +00:00
playsave.cpp Convert some uses of nm_messagebox_str to run_blocking_newmenu 2021-06-28 03:37:49 +00:00
polyobj.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
powerup.cpp Reduce use of global structures in cheat functions 2021-04-04 22:01:25 +00:00
render.cpp Use structured bindings for more zip calls 2021-06-28 03:37:51 +00:00
robot.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
scores.cpp Convert high score saying dialog to use run_blocking_newmenu 2021-06-28 03:37:50 +00:00
segment.cpp Use susegment for references introduced by valptridx conversion 2019-12-22 05:34:08 +00:00
slew.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
songs.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
state.cpp Make savegame menu inherit from newmenu 2021-06-28 03:37:51 +00:00
switch.cpp Convert some uses of nm_messagebox_str to run_blocking_newmenu 2021-06-28 03:37:49 +00:00
terrain.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
texmerge.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
text.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
titles.cpp Use enum class for sound angle parameter 2021-06-28 03:37:51 +00:00
vclip.cpp optimize include files (include what you use) 2021-02-06 21:38:50 +01:00
vers_id.cpp Switch most in-tree http:// links to https:// 2018-09-02 00:57:29 +00:00
wall.cpp Use structured bindings to access enumerated ranges 2021-06-28 03:37:50 +00:00
weapon.cpp Halve the volume of weapon changes 2021-06-28 03:37:51 +00:00