dxx-rebirth/common
Kp 7ac4016f55 Remove DXX_VALPTRIDX_STATIC_CHECK
clang-14 is detected as being able to optimize out unreachable paths,
but then triggers a build error reporting an unspecified invalid use
somewhere in multi.cpp.

Remove the static check, and rely on -Wsuggest-attribute=noreturn to
report any functions which are guaranteed to fail.  This is a weaker
check, but over the course of development, the static check has been hit
rarely, if ever, so keeping it provides little value.

```
In file included from similar/main/multi.cpp:38:
In file included from common/main/game.h:32:
In file included from common/main/robot.h:34:
In file included from common/main/object.h:40:
common/include/valptridx.h:229:2: error: call to unsigned int valptridx<dcx::player>::check_index_range_size<valptridx<dcx::player>::index_range_exception, std::__1::less>(char const*, unsigned int, unsigned long, valptridx<dcx::player>::array_managed_type const*)::DXX_ALWAYS_ERROR_FUNCTION::dxx_trap_handle_index_range_error() declared with 'error' attribute: invalid index used in array subscript
    DXX_VALPTRIDX_CHECK(Compare<std::size_t>()(s, array_size), handle_index_range_error, "invalid index used in array subscript", a, s);
    ^
common/include/valptridx.h:37:3: note: expanded from macro 'DXX_VALPTRIDX_CHECK'
        DXX_VALPTRIDX_STATIC_CHECK(dxx_valptridx_check_success_condition, dxx_trap_##ERROR, FAILURE_STRING);    \
        ^
common/include/valptridx.h:20:5: note: expanded from macro 'DXX_VALPTRIDX_STATIC_CHECK'
            (DXX_ALWAYS_ERROR_FUNCTION(FAILURE_FUNCTION, FAILURE_STRING), 0)    \
             ^
build/ulinux-clang++-14-64b10d04-ogl/dxxsconf.h:84:2: note: expanded from macro 'DXX_ALWAYS_ERROR_FUNCTION'
    DXX_ALWAYS_ERROR_FUNCTION::F(); \
    ^
1 error generated.
```
2022-08-22 01:24:49 +00:00
..
2d Prefer C++20 std::span over internal span for decode_row 2022-07-30 17:42:59 +00:00
3d Move various static functions into anonymous namespace 2022-07-09 13:39:29 +00:00
arch Move various static functions into anonymous namespace 2022-07-09 13:39:29 +00:00
editor Move various static functions into anonymous namespace 2022-07-09 13:39:29 +00:00
include Remove DXX_VALPTRIDX_STATIC_CHECK 2022-08-22 01:24:49 +00:00
main Add stub definitions of enum vertnum_t,wallnum_t 2022-08-22 01:24:49 +00:00
maths Remove quadint members low, high 2022-05-24 02:32:58 +00:00
mem Refer to <array> directly, not through "compiler-array.h" 2020-05-02 21:18:42 +00:00
misc Move various static functions into anonymous namespace 2022-07-09 13:39:29 +00:00
music Rework ADL dynamic loader 2018-10-15 00:51:53 +00:00
texmap Require support for C++17 attribute [[fallthrough]] 2022-01-09 15:25:42 +00:00
ui Move various static functions into anonymous namespace 2022-07-09 13:39:29 +00:00
unittest Add unit tests for enumerate 2022-02-13 19:13:38 +00:00