dxx-rebirth/common/main/d_array.h
Kp fcb6beb3e8 Add check that d_array<E> is not unsigned int or unsigned long
`std::size_t` is `unsigned int` on i686-pc-linux-gnu, but is `unsigned
long` on x86_64-pc-linux-gnu.  This mismatch allows d_array<E =
std::size_t> to be well-formed on x86_64, but trigger a duplicate
definition of operator[](E) on i686.  Add a requires() check that
forbids both types for E, so that code which would break the i686 build
is also diagnosed in the x86_64 build.
2022-10-09 23:15:20 +00:00

64 lines
2 KiB
C++

/*
* This file is part of the DXX-Rebirth project <https://www.dxx-rebirth.com/>.
* It is copyright by its individual contributors, as recorded in the
* project's Git history. See COPYING.txt at the top level for license
* terms and a link to the Git history.
*/
#pragma once
#include "dxxsconf.h"
#include <array>
#include "fwd-d_array.h"
namespace dcx {
/* Wrap a std::array and override the normal indexing operations to take
* an instance of type `E`. This is intended for use where `E` is an
* instance of `enum class`. When `E` is an `enum class`, instances of
* `E` cannot implicitly convert to `std::array::size_type`, and so
* would require a cast in the caller if this wrapper were not used.
* Using this wrapper moves the casts into the wrapper, after the
* compiler has checked that the argument is the right type of `enum
* class`. This prevents accidentally using an incorrect `enum class`.
*
* Other types for E are not likely to be useful, but are not blocked.
*/
template <typename T, std::size_t N, typename E>
requires(!std::is_same<unsigned, E>::value && !std::is_same<unsigned long, E>::value)
struct enumerated_array : std::array<T, N>
{
using base_type = std::array<T, N>;
using index_type = E;
using typename base_type::reference;
using typename base_type::const_reference;
constexpr reference at(E position)
{
return this->base_type::at(static_cast<std::size_t>(position));
}
constexpr const_reference at(E position) const
{
return this->base_type::at(static_cast<std::size_t>(position));
}
constexpr reference operator[](E position)
{
return this->base_type::operator[](static_cast<std::size_t>(position));
}
constexpr const_reference operator[](E position) const
{
return this->base_type::operator[](static_cast<std::size_t>(position));
}
const_reference operator[](std::size_t) const = delete;
[[nodiscard]]
static constexpr bool valid_index(std::size_t s)
{
return s < N;
}
[[nodiscard]]
static constexpr bool valid_index(E e)
{
return valid_index(static_cast<std::size_t>(e));
}
};
}