dxx-rebirth/similar
Kp 45362ac37b Fix guest loading of multiplayer saved games
Using `sav_objnum` caused the player to be restored into the object slot
of the pre-load level, in the object table of the post-load level.  This
was harmless when the slots were the same, and wrong when they were not.
It became noticeably wrong when more player data was moved into the
object.  After those changes, the player's data was stored into the
correct post-load slot, but the ship was assigned to the pre-load slot.

Remove the incorrect slot switch, and add an assert that the object
being overwritten is a player ghost.  With the incorrect switch present,
this assert will catch most (but not all)[1] cases of the incorrect
restore.  With the incorrect switch removed, this assert succeeds.

[1] In the unlikely case that the post-load slot was a player start, but
for a different player, the assert could succeed despite the slot
mismatch bug.  In the common case, the post-load slot would not be a
start of a different player; it would either be the correct player slot,
in which case `sav_objnum` was harmless, or it would be some other
object, such as a robot.
2022-09-11 17:00:45 +00:00
..
2d Rename font underline to draw_full_width_as_fg_color 2022-07-02 18:10:45 +00:00
3d Move rotate_point_list inline in g3_interpreter_draw_base 2021-11-01 03:37:20 +00:00
arch Add Windows version resource for Windows build 2022-09-11 17:00:45 +00:00
editor Use auto type for Viewer in more places 2022-07-09 13:39:29 +00:00
main Fix guest loading of multiplayer saved games 2022-09-11 17:00:45 +00:00
misc Set console output priority to highest given option rather than most recently specified 2022-05-16 20:03:34 +12:00