Both callers of ReadIniArgs need the string removed afterward. Prior to 8fb9a0f, only the parser for `-ini` needed the string removed. The caller for the automatic ini file ended and destroyed the container. As of 8fb9a0f, the container persists. Leaving the string in the container causes a bad error message if the command line is rejected. It is bad form to have ReadIniArgs pop, but the caller push. However, the two callers use different signatures for emplace_back(), so unifying the push would require calling a suboptimal emplace_back. Choose the lesser evil of unbalanced push/pop. Reported-by: zicodxx <https://github.com/dxx-rebirth/dxx-rebirth/issues/198> |
||
---|---|---|
.. | ||
args.cpp | ||
physfsx.cpp |