Kp
f900d4a5ee
Remove RAIIdmem::operator pointer
...
Mac OS X defines uint_fast32_t to unsigned int, causing ambiguous
overloads between RAIIdmem::operator[](std::size_t) and
RAIIdmem::operator[](int). Adding a disambiguating overload for OS X
breaks Windows. Remove operator pointer and operator[]. Rely on the
inherited operator[] for indexing. Require users to call ->get() to
convert to a simple pointer.
First btb ambiguity reported: https://github.com/dxx-rebirth/dxx-rebirth/pull/34
Second btb ambiguity reported: https://github.com/dxx-rebirth/dxx-rebirth/pull/43
2015-02-17 03:52:59 +00:00
Kp
68e2168377
Use array<> for bitmap_index arrays
2015-02-14 22:48:30 +00:00
Kp
f17458d353
Explicitly delete valptridx inequality operators
2015-02-14 22:48:30 +00:00
Kp
91cc111295
Provide SndDisableSdlMixer=true if !USE_SDLMIXER
...
Accept -nosdlmixer as a no-op in !USE_SDLMIXER builds.
2015-02-08 17:43:29 +00:00
Kp
d0de0cf963
Use unique_ptr for SDL_RWops
2015-02-08 17:43:29 +00:00
Kp
abb0d86696
Only close opened movies
2015-02-08 17:43:29 +00:00
Kp
99a4a0ed62
Capture range_for by-value temporaries as const
...
Modifying a by-value temporary does not affect the underlying container,
so modifying it is almost always a bug. Require use of a by-reference
capture when modification is desired.
sed -i -e 's/range_for\s*(\s*\(const\s\+\)\?auto\s\+\([[:alpha:]_]\)/range_for (const auto \2/g'
2015-02-05 03:03:49 +00:00
Kp
c2aa2c2e4b
Rename space to space_tab
...
Name space is too simple and causes conflicts elsewhere.
2015-01-29 04:27:35 +00:00
Kp
ff4a0ccd70
Fix RAIIdmem array usage
...
Some RAIIdmem instances managed a T[], but were declared to manage a T.
2015-01-28 03:42:53 +00:00
Kp
786b7c35a5
Use unique_ptr for mve_audio_spec
2015-01-28 03:42:53 +00:00
Kp
accd1db476
Use unique_ptr for mve_audio_buffers
2015-01-28 03:42:52 +00:00
Kp
a3edc2b4f8
Use unique_ptr for MVEFILE::cur_chunk
2015-01-28 03:42:52 +00:00
Kp
77d25fd6d2
Fix uninitialized access in exists_in_mine_2
...
Objects of type OBJ_NONE have no guaranteed values in any other field.
Check curobjp->type before examining the object.
2015-01-28 03:42:52 +00:00
Kp
0ea95e87e7
Pass array<> to create_bfs_list
2015-01-28 03:42:52 +00:00
Kp
fa73ca8a17
Pass gr_remap_bitmap_good arg by &
2015-01-25 05:32:45 +00:00
Kp
31450e4843
Pass iff_read_bitmap arg by &
2015-01-25 05:32:44 +00:00
Kp
922a7b7dc9
Pass grs_main_bitmap to iff_read_animbrush
2015-01-25 05:32:44 +00:00
Kp
40fd988a0f
Hide local classes in anonymous namespaces
2015-01-23 03:55:06 +00:00
Kp
a6884e77db
Unpack robot_info
2015-01-23 03:55:04 +00:00
Kp
84e3a03451
Remove unused parameters
2015-01-18 01:58:33 +00:00
Kp
c6664a45a6
Add newmenu_do helper for array<newmenu_item, N>
2015-01-18 01:58:32 +00:00
Kp
f8163957ef
Add helper nm_item_input
2015-01-18 01:58:31 +00:00
Kp
547193c591
Compile out unused bm_write_all
...
Unused since e2a2cc579a
deleted caller
piggy_dump_all.
2015-01-17 18:31:43 +00:00
Kp
f7815810e8
Use RAIIPHYSFS_File to manage PHYSFS_File
...
Fixes a few leaks on error paths.
2015-01-17 18:31:42 +00:00
Kp
68d705a85a
Use bool conversion to test PHYSFS_File pointer
2015-01-17 18:31:42 +00:00
Kp
28a31a223f
Centralize window_close calls
2015-01-17 18:31:41 +00:00
Chris Taylor
aee62be433
Merge branch 'btb-xcode' into unification/master
2015-01-14 19:42:16 +08:00
Kp
61ba3d1ba2
Centralize buddy search
2015-01-12 00:26:04 +00:00
Kp
846b6b4b82
Improve buddy message suppression
2015-01-12 00:26:03 +00:00
Kp
12770802ab
Use ntstring for guidebot name
2015-01-12 00:26:02 +00:00
Chris Taylor
d302a40662
Merge branch 'xcode' of https://github.com/btb/dxx-rebirth into btb-xcode
2015-01-10 18:54:13 +08:00
Kp
76bec9f31f
Fix spelling of "available" in help text
2015-01-03 23:44:31 +00:00
Bradley Bell
cf3ba80824
Merge branch 'unification/master' of https://github.com/dxx-rebirth/dxx-rebirth into xcode
2015-01-02 21:11:14 -08:00
Kp
fbac119095
Propagate use of objptridx_t
2014-12-23 04:20:27 +00:00
Kp
0f30d4eb72
Use PHYSFSX_gets_line_t for Current_level_palette
2014-12-20 04:36:08 +00:00
Kp
5867b5d690
Remove useless bmread whitespace loop
...
Obsolete since 44bbb66101
.
2014-12-18 04:12:39 +00:00
Kp
da6632a917
Use array<> for Robot_joints
2014-12-18 04:12:38 +00:00
Kp
4af33f12a4
Fix gcc-4.7 -Wmissing-braces warning
2014-12-15 03:59:15 +00:00
Bradley Bell
f897688c12
delete old broken XCode project files
2014-12-06 22:43:12 -08:00
Kp
73b0a016a8
Fix loading robots-?.mvl
...
Rework movie loading to fix loading built-in robot movies. The previous
code always ignored loading the last entry in the movie array, which was
blank until 18f6919b33
. The last entry
was unused after d38a3d1362
, so it was
removed, which caused the code to skip the robots entry.
Commit d38a3d1362
broke unloading add-on
movies by removing the strcpy which saved their name. Add code to save
the name to extra_robot_movie_mission and call it when switching
missions.
Reported by btb: https://github.com/dxx-rebirth/dxx-rebirth/pull/17
2014-12-06 17:56:56 +00:00
Bradley Bell
3daa0f63b1
Add search SDL_mixer framework paths for headers instead of using <Framework/Header.h> notation
2014-12-03 15:14:18 -08:00
Kp
0375876a08
Pass gr_bm_ubitbltm arg by &
2014-12-02 03:35:01 +00:00
Kp
e7aae37c8d
Pass ogl_ubitblt_i arg by &
2014-12-02 03:35:01 +00:00
Kp
91a2eb8491
Include <vector> in mveplay.cpp for std::vector
...
Reported by btb: https://github.com/dxx-rebirth/dxx-rebirth/pull/12
Fixed by btb: f502740fdd
2014-11-30 17:01:39 +00:00
Kp
5aaf847c41
Fix various -Wnarrowing errors
2014-11-26 03:39:21 +00:00
Kp
d63be88eb0
Propagate use of vsegptridx_t
2014-11-23 04:58:45 +00:00
Kp
a17cf6f808
Avoid slicing into objnum_t local
2014-11-20 03:00:41 +00:00
Kp
2c349136cc
Avoid slicing into segnum_t local
2014-11-20 03:00:36 +00:00
Kp
ad527a7551
Use unique_ptr for MVEFILE
2014-11-01 15:04:30 +00:00
Kp
a42e7c3db1
Use unique_ptr for MVESTREAM
2014-11-01 15:00:48 +00:00
Kp
279233cf24
Use std::vector for MVE buffer
2014-11-01 15:00:04 +00:00
Kp
9aa0cf0b89
Pass read_model_guns vector as array &
2014-11-01 03:08:27 +00:00
Kp
6d61198130
Pass compute_segment_center vector by &
2014-10-30 03:32:51 +00:00
Kp
5bb9c88979
Add vm_vec_sub that returns result
2014-10-29 03:24:31 +00:00
Kp
fb1704780b
Move pMovie into local data structures
2014-10-29 03:01:18 +00:00
Kp
d8024d4d26
Use RAII to manage MVESTREAM
2014-10-29 02:59:08 +00:00
Kp
19bb554f31
Move MVESTREAM pointer up one layer
2014-10-29 02:57:52 +00:00
Kp
53aa70cecb
Use vsegptridx_t
2014-10-28 03:08:51 +00:00
Kp
b871228f92
Pass create_morph_robot vector by const &
2014-10-28 01:47:18 +00:00
Kp
8a0582766a
Pass drop_powerup vector by const &
2014-10-28 01:46:07 +00:00
Kp
d14c0ba71c
Pass do_snipe_frame vector by &
2014-10-28 01:45:53 +00:00
Kp
ad717e59e8
Pass laser vectors as const &
2014-10-26 21:37:27 +00:00
Kp
a32547af16
Pass position-related vms_vector arg by &
2014-10-22 02:46:03 +00:00
Kp
019b572c0e
Remove #define Segment2s Segments
2014-10-21 03:15:12 +00:00
Kp
e7e23eb92e
Make unused_window_userdata_t const
2014-10-16 02:30:29 +00:00
Kp
6934dc863c
Fix gcc 4.6 build of libmve
2014-10-16 01:40:48 +00:00
Kp
7f648c0f5f
Wrap segment iteration idiom
2014-10-12 23:10:05 +00:00
Kp
fb641b3250
Wrap object iteration idiom
2014-10-12 23:05:46 +00:00
Kp
4e368ac946
Make mve args const
2014-10-10 02:57:07 +00:00
Kp
6943024647
Fix signaure of mve_cb_Alloc
2014-10-10 02:43:40 +00:00
Kp
a8f853aa7a
Pass d_event arg by const&
2014-10-04 22:36:13 +00:00
Kp
ec1eb03cc2
Move d2x-rebirth/main/segment.cpp -> similar/main/segment.cpp
2014-10-04 17:53:09 +00:00
Kp
6971dfbf4a
Use symbolic *_none constants for -1
2014-10-04 17:31:13 +00:00
Kp
184f828a91
Move iff_read_animbrush array<unique_ptr<grs_bitmap>> down
2014-10-04 15:02:03 +00:00
Kp
5b97433ce5
Make various ai functions take const vms_vector&
2014-10-02 03:02:36 +00:00
Kp
1fff2db9a8
Pass vm_vec_dist_quick arg by &
2014-10-01 02:28:41 +00:00
Kp
0b2636d535
Pass vm_vec_add2 arguments by &
2014-09-28 21:43:00 +00:00
Kp
00b59c3058
Pass vm_vec_dot arguments by &
2014-09-28 21:11:48 +00:00
Kp
321bbe37d8
Pass vm_vec_sub arguments by &
2014-09-28 21:11:45 +00:00
Kp
a620a59bda
Pass vm_vec_normalize_quick v by &
2014-09-28 21:11:04 +00:00
Kp
c0023cad51
Fix memory leak writing hoard data
2014-09-27 23:14:50 +00:00
Kp
dc511d0a5c
Pass array<> to iff_read_animbrush
2014-09-27 23:06:33 +00:00
Kp
78ad2adabf
Write weapon_info carefully
2014-09-27 22:46:25 +00:00
Kp
afd995aa22
Centralize N_D2_* constants in bm.h
2014-09-27 15:42:45 +00:00
Kp
22b836147d
Propagate for variables in d2x-rebirth/main/movie.cpp
2014-09-26 02:42:16 +00:00
Kp
c58d9c72a8
Propagate for variables in d2x-rebirth/main/escort.cpp
2014-09-26 02:42:16 +00:00
Kp
2d7ce50951
Propagate for variables in d2x-rebirth/libmve/mveplay.cpp
2014-09-26 02:42:16 +00:00
Kp
301629be91
Propagate for variables in d2x-rebirth/libmve/mve_audio.cpp
2014-09-26 02:42:16 +00:00
Kp
c79281de1e
Propagate for variables in d2x-rebirth/libmve/decoder8.cpp
2014-09-26 02:42:15 +00:00
Kp
9eda412dff
Use symbolic constant wall_none
2014-09-21 23:05:14 +00:00
Kp
703f60ac3f
Fix -Wtype-limits warnings
2014-09-21 21:41:55 +00:00
Kp
039bf2f0b7
Fix crash on failure to create afterburner blob
...
Fix crash on failure to recreate thief.
2014-09-13 22:01:17 +00:00
Kp
e8f4b20d1d
Use special type for PHYSFSX_fgets
2014-09-07 20:07:20 +00:00
Kp
a02f78a171
Move saving window pointer into helper
2014-09-07 19:04:07 +00:00
Kp
fea751bc62
Use std::string for mission path
2014-08-24 17:45:30 +00:00
Kp
b95759aecc
Propagate use of objptridx
2014-08-23 23:53:56 +00:00
Kp
54da3b386b
Copy bmread strings to local storage
2014-08-23 17:06:44 +00:00
Kp
66cb80c343
Propagate use of objptridx
2014-08-17 20:31:18 +00:00
Kp
414cf3b29b
Remove useless buddy rediscovery loop
...
Assume Buddy_objnum will be set right.
2014-08-14 02:03:27 +00:00
Kp
bf8d29b348
Remove useless buddy bot checks
...
These are only hit after the condition is assumed true.
2014-08-13 22:17:38 +00:00