Kp
28a83aa43f
Harden D2 loading of D1 texture numbers
2023-01-07 22:17:31 +00:00
Kp
06bb1b74ad
Harden bm_read_alias against bad input
2023-01-07 22:17:31 +00:00
Kp
2a4a06aca0
Use enum class for pigfile_size
2023-01-07 22:17:31 +00:00
Kp
91496e1d4a
Use enum class for properties_init result
2023-01-07 22:17:31 +00:00
Kp
5ce4d49004
Use enum class for sound_sample_rate
2023-01-07 22:17:31 +00:00
Kp
08cc393e74
Return DiskSoundHeader from DiskSoundHeader_read
...
This allows the structure to be const in the caller.
2023-01-07 22:17:31 +00:00
Kp
66d588c624
Use bitmap name in place for non-animated bitmaps
2023-01-07 22:17:31 +00:00
Kp
c428fdee0f
Pass ranges::subrange to bitmap_index_read_n
2022-12-31 16:21:47 +00:00
Kp
e3553586c1
Use enum class for bitmap_index
2022-12-31 16:21:47 +00:00
Kp
0fd5ea2972
Inline PHYSFSX_fseek(..., SEEK_SET)
...
When using SEEK_SET, the call passed through to PhysFS after truncating
the offset. Call PhysFS directly in this case, bypassing the wrapper.
2022-12-18 23:10:39 +00:00
Kp
64eae78dcc
Prefer direct initialization for bitmap_index
2022-12-18 18:32:14 +00:00
Kp
8d691aa080
Pass std::span to piggy_is_substitutable_bitmap
2022-12-17 13:16:28 +00:00
Kp
eda958280e
Return DiskBitmapHeader from DiskBitmapHeader_read
...
This allows the structure to be const in the caller.
2022-12-17 13:16:28 +00:00
Kp
cba14b91e4
Pass std::span to piggy_find_sound
2022-12-17 13:16:28 +00:00
Kp
102d19ec28
Pass std::span to piggy_find_bitmap
2022-12-17 13:16:28 +00:00
Kp
8bd94c4f5c
Pass std::span to piggy_register_sound
2022-12-17 13:16:28 +00:00
Kp
030897e911
Avoid temporary copy when generating abmname
...
Use printf `%.*s` with an appropriate length, instead of copying the
appropriate number of bytes into a temporary, null terminating it, and
relying on the terminator for printf.
2022-12-17 13:16:28 +00:00
Kp
1b92a56648
Use unique_ptr to manage digi_sound allocation
2022-12-10 18:09:54 +00:00
Kp
9716d42ea0
Use enum class for pig_hamfile_version
2022-10-09 23:15:20 +00:00
Kp
0ebcc64ac5
Test whether change_filename_extension succeeded before using its output
2022-10-09 23:15:20 +00:00
Kp
a9142bb65a
Use std::span for change_filename_extension arguments
2022-10-09 23:15:20 +00:00
Kp
7c0fb7b12a
Use std::span for load_bitmap_replacements argument level_name
2022-10-09 23:15:20 +00:00
Kp
38adcc7729
Simplify change_filename_extension
...
The called function skipped over a leading dot in the extension. Remove
that logic and change all callers not to supply a leading dot.
2022-10-09 23:15:20 +00:00
Kp
e0123dead5
Remove special case for 0 argument PHYSFSX_printf
...
Fix the remaining sites that were redirected by this. Remove the
redirection macro.
2022-10-02 19:51:36 +00:00
Kp
e499dd55f7
Use std::span for piggy_write_pigfile argument filename
2022-10-02 19:51:35 +00:00
Kp
aaac0e69fa
Use std::span for piggy_new_pigfile argument pigname
2022-10-02 19:51:35 +00:00
Kp
eca189e8aa
Use enum class for SoundOffset
...
Change piggy_register_sound to take the sound offset as a parameter,
rather than assuming the caller will set SoundOffset accordingly.
Remove a spurious sound reset in piggy_register_bitmap. Based on the
duplicated comment, this was probably incorrectly copied from
piggy_register_sound, where it made sense, into piggy_register_bitmap,
where it does not.
2022-10-02 19:51:35 +00:00
Kp
14bf2dc59a
Pass std::span to piggy_register_bitmap
2022-10-02 19:51:35 +00:00
Kp
8fe9b8322d
Check return value of PHYSFSX_fgets
2022-10-02 19:51:35 +00:00
Kp
b1da47a34b
Compare d1 extra pig in place
...
Instead of creating a copy, modifying the copy, and comparing to it, use
std::span to pass down the maximum allowed length for comparison.
2022-09-24 17:47:52 +00:00
Kp
af8efbf830
Clear GameSounds, SoundOffset in bulk
2022-09-24 17:47:52 +00:00
Kp
a70188e7a5
Move various static functions into anonymous namespace
2022-07-09 13:39:29 +00:00
Kp
6215ef8e06
Pass LevelSharedRobotInfoState to various functions that need it
2022-07-09 13:39:29 +00:00
Kp
a1bdd81d41
Exclude unused code from D2 non-editor build
...
gamedata_read_tbl is only called if (D1 || (D2 && EDITOR)). Exclude
defining it for (D2 && !EDITOR). From there, also exclude defining or
reading the alias list, which is only written by a function
called by gamedata_read_tbl.
Reported-by: heftig <https://github.com/dxx-rebirth/dxx-rebirth/issues/642 >
2022-06-11 15:00:02 +00:00
Kp
522c696af0
Remove unnecessary members in splitpath_t
...
splitpath_t is designed for MS-DOS paths, even though Rebirth now runs
on many platforms that never used DOS conventions. Most of the members
of splitpath_t are unused on all platforms. Remove them, and switch to
returning an initialized version of the structure.
2022-06-11 15:00:02 +00:00
Kp
11a0aae9ee
Pass GameBitmaps to piggy_bitmap_page_in
2022-06-05 17:44:52 +00:00
Kp
12cca97870
Remove unused piggy_new_pigfile local char tempname[20]
...
gcc-12 warns that the snprintf to initialize `tempname` may be
truncated. The variable is never used after it is initialized, so
delete the initialization and declaration.
2022-05-28 21:04:37 +00:00
Kp
d2478d0708
Require support for C++17 attribute [[fallthrough]]
2022-01-09 15:25:42 +00:00
Kp
4d5488e493
Remove unused-but-set variable similar/main/piggy.cpp: sbytes
2022-01-07 04:26:22 +00:00
Kp
2da07e75e5
Fix gcc-7 editor build
...
gcc-7 warns if a structured binding defines a variable, and then does
not use it. Suppress the warning, since the binding is needed in the
non-editor build.
2021-09-12 16:20:52 +00:00
Kp
56c98f5345
Improve error reporting for PHYSFSX_openWriteBuffered
...
Return the PHYSFS error code on failure, so that callers can report why
the open failed.
2021-07-25 23:00:56 +00:00
Kp
1c13d3c8d3
Improve error reporting for PHYSFSX_openReadBuffered
...
Return the PHYSFS error code on failure, so that callers can report why
the open failed.
2021-07-25 23:00:56 +00:00
Kp
b2968c55da
Improve error reporting for read_sndfile
...
Move error reporting down into read_sndfile, so that individual failure
paths can have specific error messages.
2021-07-25 23:00:56 +00:00
Kp
6e12644620
Remove write-only field digi_sound::bits
2021-06-28 03:37:49 +00:00
Kp
73c3474f8e
Reduce uses of RAIIdmem for local variables
2021-06-28 03:37:49 +00:00
Kp
d0a8cf7769
Avoid unnecessary reallocations in D1 shareware sound decompression
...
lastsize was never updated from 0, so every pass would reallocate the
buffer. Switch to a std::vector and rely on it to remember the size.
Manually tracking the size would be slightly more efficient, but this is
not a hot path and the vector approach is easier to review.
2021-06-28 03:37:48 +00:00
Dmitry Grigoryev
fbd05a1592
optimize include files (include what you use)
2021-02-06 21:38:50 +01:00
Kp
9c5f7b1248
Fix incorrect read length in D1 piggy_read_sounds
...
Reported-by: Kreeblah <https://github.com/dxx-rebirth/dxx-rebirth/issues/542 >
Fixes: faf37e3c14
2020-09-11 03:08:03 +00:00
Kp
da66b1d9b8
Move d1_tmap_num_unique to piggy.cpp
...
It is only used in one file. Move it there and make it static.
2020-08-24 01:31:28 +00:00
Kp
9c3fc7523c
Make extra_bitmap_num static
...
Modify read_extra_bitmap_d1_pig to take the bitmap-to-write as a
parameter, instead of computing it from extra_bitmap_num.
2020-08-24 01:31:28 +00:00
